Skip to content

Commit 34fd37e

Browse files
authored
[cuegui] Remove check for source waiting frames on redirect (#1648)
Checking for if the source job has waiting frames makes no sense as the job is giving up its resources. This unnecessary check was preventing operations from redirecting resources from jobs that were fully booked but still running.
1 parent 49b6b32 commit 34fd37e

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

cuegui/cuegui/Redirect.py

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -604,7 +604,7 @@ def __isBurstSafe(self, alloc, procs, show):
604604
@classmethod
605605
def __isAllowed(cls, procs, targetJob):
606606
"""Checks if the follow criteria are met to allow redirect to target job:
607-
- if source/target job have waiting frames
607+
- if target job have waiting frames
608608
- if target job hasn't reached maximum cores
609609
- check if adding frames will push target job over it's max cores
610610
@@ -627,19 +627,10 @@ def __isAllowed(cls, procs, targetJob):
627627
targetJob.maxCores())
628628

629629
# Case 2: 1. Check target job for waiting frames
630-
# 2. Check source procs for waiting frames
631630
if allowed and targetJob.waitingFrames() <= 0:
632631
allowed = False
633632
errMsg = "Target job %s has no waiting frames" % targetJob.name()
634633

635-
if allowed:
636-
for proc in procs:
637-
job = proc.getJob()
638-
if job.waitingFrames() <= 0:
639-
allowed = False
640-
errMsg = "Source job %s has no waiting frames" % job.name()
641-
break
642-
643634
# Case 3: Check if each proc or summed up procs will
644635
# push targetJob over it's max cores
645636
if allowed:

0 commit comments

Comments
 (0)