[rqd] Ensure logdir is owned by job user (#1742)

Failing to do so causes problems if other frames from the same job were
executed on docker, which may lead to the log dir to be owned by root.

This change attempts to change the logdir ownership prior to
initializing `RqdLogger`. Handling this internally on the initialization
logic would be preferred, but is not possible as the initialization
needs to run as the job user and the chown logic needs to happen on
permissionHigh mode.

---------

Signed-off-by: Diego Tavares <[email protected]>
Co-authored-by: Ramon Figueiredo <[email protected]>

Author: DiegoTavares

rqd/rqd/rqcore.py

@@ -1402,6 +1402,7 @@ def setup(self):
                                                 runFrame.uid,
                                                 runFrame.gid)
                 if not run_on_docker:
+                    self.ownFrameDir()
                     # Do everything as launching user:
                     runFrame.gid = rqd.rqconstants.LAUNCH_FRAME_USER_GID
                     rqd.rqutil.permissionsUser(runFrame.uid, runFrame.gid)
@@ -1420,6 +1421,22 @@ def setup(self):
         finally:
             rqd.rqutil.permissionsLow()
 
+    def ownFrameDir(self):
+        """Chown the frame's log_dir"""
+        if not self.runFrame.loki_url:
+            # Ensure logdir is owned by this job user. If it doesn't exist it will get
+            # created under the correct user when RqdLogger is initialized
+            if os.path.isdir(self.runFrame.log_dir):
+                try:
+                    rqd.rqutil.permissionsHigh()
+                    os.chown(self.runFrame.log_dir, self.runFrame.uid, self.runFrame.gid)
+                # pylint: disable=broad-except
+                except Exception:
+                    # Don't bail on this exception as rqlogging initialization might
+                    # still work depending on the logdir permissions
+                    log.warning("Failed to chown dir name %s", self.runFrame.log_dir)
+                finally:
+                    rqd.rqutil.permissionsLow()
 
     def runUnknown(self):
         """The steps required to handle a frame under an unknown OS."""