Skip to content

Commit f62858a

Browse files
authored
[rqd] Fix typo that was causing rqconstants.RQD_USE_ALL_HOST_ENV_VARS to never get overriden by rqd.conf (#1754)
**Link the Issue(s) this Pull Request is related to.** N/A **Summarize your change.** After a healthy amount of head-banging I noticed that the value of `rqconstants.RQD_USE_ALL_HOST_ENV_VARS` was always `False` regardless of the overrides I had in my `rqd.conf`. It appears the variable `rqconstants.RQD_USE_HOST_ENV_VARS` (never used) was being updated instead of `rqconstants.RQD_USE_ALL_HOST_ENV_VARS`. `rqconstants.RQD_USE_ALL_HOST_ENV_VARS` is only ever used once throughout the codebase, in rqd/rqcore.py, so this change should be safe. https://github.com/AcademySoftwareFoundation/OpenCue/blob/9b3e02abb3898ef77201d6d705ed18b4f85d5143/rqd/rqd/rqcore.py#L795
1 parent 9b3e02a commit f62858a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

rqd/rqd/rqconstants.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
if config.has_option(__override_section, "RQD_USE_PATH_ENV_VAR"):
226226
RQD_USE_PATH_ENV_VAR = config.getboolean(__override_section, "RQD_USE_PATH_ENV_VAR")
227227
if config.has_option(__override_section, "RQD_USE_ALL_HOST_ENV_VARS"):
228-
RQD_USE_HOST_ENV_VARS = config.getboolean(__override_section,
228+
RQD_USE_ALL_HOST_ENV_VARS = config.getboolean(__override_section,
229229
"RQD_USE_ALL_HOST_ENV_VARS")
230230
if config.has_option(__override_section, "RQD_BECOME_JOB_USER"):
231231
RQD_BECOME_JOB_USER = config.getboolean(__override_section, "RQD_BECOME_JOB_USER")

0 commit comments

Comments
 (0)