Skip to content

Commit 2b46566

Browse files
SG-41787: Add undo/redo/clear UI update event for Live Review (#1070)
### [SG-41787](https://jira.autodesk.com/browse/SG-41787): Add undo/redo/clear UI update event for Live Review ### Summarize your change. Add an undo/redo/clear UI update event in Annotate mode. ### Describe the reason for the change. In an OTIO-based Live Review session, the state of the buttons in the Annotate mode is not updated when receiving a clear or delete event from another participant. The per-user undo-redo stack is updated properly but not the UI, giving the impression that something could still be undone or redone when there is nothing. ### Describe what you have tested and on which operating system. Making the host of the session clear or submit annotations made by RV was successfully tested on macOS using this fix and another one in the Commercial RV repo. Signed-off-by: Éloïse Brosseau <eloise.brosseau@autodesk.com>
1 parent e74ebd2 commit 2b46566

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

src/plugins/rv-packages/annotate/annotate_mode.mu

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2318,6 +2318,7 @@ class: AnnotateMinorMode : MinorMode
23182318
method: redoEvent (void; Event event) { redoSlot(true); }
23192319
method: clearEvent (void; Event event) { clearSlot(true); }
23202320
method: clearAllEvent (void; Event event) { clearAllSlot(true); }
2321+
method: undoRedoClearUpdateEvent (void; Event event) { undoRedoClearUpdate(); }
23212322

23222323
method: keyUndoEvent (void; Event event)
23232324
{
@@ -3206,6 +3207,7 @@ class: AnnotateMinorMode : MinorMode
32063207
("clear-annotations-current-frame", clearEvent, "Clear annotations on current frame"),
32073208
("clear-annotations-all-frames", clearAllEvent, "Clear annotations on all frames"),
32083209
("set-current-annotate-mode-node", setCurrentNodeEvent, "Set current paint node"),
3210+
("undo-redo-clear-ui-update", undoRedoClearUpdateEvent, "Update the undo, redo and clear state"),
32093211
// --------------------------------------------------------------
32103212
// For NDC drawing support used in automated testing
32113213
("stylus-color-rgb", setColorRGB, "Select color RGB"),

0 commit comments

Comments
 (0)