fix: complete todo to turn cache path in environment variable

Signed-off-by: deltag0 <ioan.1931@gmail.com>

Author: deltag0

src/lib/image/MovieFFMpeg/MovieFFMpeg.cpp

@@ -23,7 +23,6 @@
 #include <boost/thread/lock_algorithms.hpp>
 #include <boost/thread/mutex.hpp>
 #include <cstddef>
-#include <filesystem>
 #include <iostream>
 #include <iomanip>
 #include <algorithm>
@@ -66,6 +65,7 @@ extern "C"
 #endif
 
 static ENVVAR_BOOL(evUseUploadedMovieForStreaming, "RV_SHOTGRID_USE_UPLOADED_MOVIE_FOR_STREAMING", false);
+static ENVVAR_STRING(evStreamCachePath, "RV_STREAM_CACHE_PATH", "/tmp");
 
 namespace TwkMovie
 {
@@ -1359,12 +1359,10 @@ namespace TwkMovie
         if (filepathIsURL)
         {
             safe_path = "shared:" + safe_path;
-            //!TODO turn this into a env variable
-            const std::string cachePath = (std::filesystem::path("/").root_path() / "tmp").string();
             av_dict_set_int(&fmtOptions, "seekable", 1, 0);
             av_dict_set_int(&fmtOptions, "reconnect", 1, 0);
             av_dict_set_int(&fmtOptions, "multiple_requests", 1, 0);
-            av_dict_set(&fmtOptions, "cache_dir", cachePath.c_str(), 0);
+            av_dict_set(&fmtOptions, "cache_dir", evStreamCachePath.getValue().c_str(), 0);
 
             for (int i = 0; i < m_request.parameters.size(); i++)
             {

src/lib/image/TwkMovie/MovieIO.cpp

@@ -9,7 +9,6 @@
 #include <TwkUtil/File.h>
 #include <TwkUtil/PathConform.h>
 #include <stream/StreamPreloadPool.h>
-#include <filesystem>
 #include <boost/algorithm/string/replace.hpp>
 #include <TwkUtil/EnvVar.h>
 #include <stdarg.h>
@@ -32,6 +31,7 @@
 #endif
 
 static ENVVAR_BOOL(evUseUploadedMovieForStreaming, "RV_SHOTGRID_USE_UPLOADED_MOVIE_FOR_STREAMING", false);
+static ENVVAR_STRING(evStreamCachePath, "RV_STREAM_CACHE_PATH", "/tmp");
 
 static std::mutex plugin_mutex;
 
@@ -112,11 +112,8 @@ namespace TwkMovie
 
         url = "shared:" + url;
 
-        // TODO: turn this into an env variable
-        const std::filesystem::path cachePath = std::filesystem::path("/").root_path() / "tmp";
-
         StreamerPool::Options options;
-        options.push_back(std::make_pair("cache_dir", cachePath.string()));
+        options.push_back(std::make_pair("cache_dir", evStreamCachePath.getValue()));
         options.push_back(std::make_pair("seekable", "1"));
         options.push_back(std::make_pair("reconnect", "1"));
         options.push_back(std::make_pair("multiple_requests", "1"));