Commit a7b9e17
<!--
Thanks for your contribution! Please read this comment in its entirety.
It's quite important.
When a contributor merges the pull request, the title and the
description will be used to build the merge commit!
### Pull Request TITLE
It should be in the following format:
[ 12345: Summary of the changes made ] Where 12345 is the corresponding
Github Issue
OR
[ Summary of the changes made ] If it's solving something trivial, like
fixing a typo.
-->
### Linked issues
<!--
Link the Issue(s) this Pull Request is related to.
Each PR should link to at least one issue, in the form:
Use one line for each Issue. This allows auto-closing the related issue
when the fix is merged.
Fixes #12345
Fixes #54345
-->
### Summarize your change.
This update includes Alt in handling that already exists for clearing
modifiers after a modifier mismatch occurs.
### Describe the reason for the change.
`Alt` + `Shift` modifier key-down was incorrectly identifying as `Meta`
+ `Shift` on key-up. As a result, `Alt` state continued after key up,
which caused operators to think RV was hung -- spacebar wouldn't
play/pause, dragging cursor on screen wouldn't scrub timeline, etc.
### Describe what you have tested and on which operating system.
Reproduced Alt+Shift issue on Linux RHEL 9.4 and RHEL 7.2, using:
* Latest OpenRV main branch
* RV 2023.0.3
* RV 7.2.6
Confirmed it did not happen on MacOS Sequoia.
### Add a list of changes, and note any that might need special
attention during the review.
### If possible, provide screenshots.
Signed-off-by: Will Wira <[email protected]>
Signed-off-by: pbergeron-adsk <[email protected]>
Co-authored-by: pbergeron-adsk <[email protected]>
1 parent 09aea51 commit a7b9e17
1 file changed
+4
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
133 | 133 | | |
134 | 134 | | |
135 | 135 | | |
136 | | - | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
137 | 140 | | |
138 | 141 | | |
139 | 142 | | |
| |||
0 commit comments