[Bug]: Building OpenRV on RHEL 9.6, hitting an error with the AJA driver

[TonyKaap]

What happened?

From @williamwira:
When I build OpenRV on a RHEL 9.6 machine, I get this error in AJA. Did the signature for get_user_pages change somehow?

/disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.c: In function 'dmaPageLock': /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.c:2799:21: error: too many arguments to function 'get_user_pages' 2799 | numPinned = get_user_pages( | ^~~~~~~~~~~~~~ In file included from ./include/linux/pagemap.h:8, from /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.c:17: ./include/linux/mm.h:2561:6: note: declared here 2561 | long get_user_pages(unsigned long start, unsigned long nr_pages, | ^~~~~~~~~~~~~~ make[5]: *** [scripts/Makefile.build:249: /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.o] Error 1 make[4]: *** [Makefile:1947: /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux] Error 2 make[3]: *** [Makefile:238: default] Error 2 gmake[2]: *** [driver/CMakeFiles/driver_linux.dir/build.make:71: driver/CMakeFiles/driver_linux] Error 2 gmake[1]: *** [CMakeFiles/Makefile2:209: driver/CMakeFiles/driver_linux.dir/all] Error 2

Kernel number for this machine:
% uname -r 5.14.0-570.49.1.el9_6.x86_64

List all the operating systems versions where this is happening

RHEL 9.6

On what computer hardware is this happening?

23 Intel Xeon cpu, 86Gb Ram, Nvidia A40

Relevant console log output

/disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.c: In function 'dmaPageLock':
/disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.c:2799:21: error: too many arguments to function 'get_user_pages'
 2799 |         numPinned = get_user_pages(
      |                     ^~~~~~~~~~~~~~
In file included from ./include/linux/pagemap.h:8,
                 from /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.c:17:
./include/linux/mm.h:2561:6: note: declared here
 2561 | long get_user_pages(unsigned long start, unsigned long nr_pages,
      |      ^~~~~~~~~~~~~~
make[5]: *** [scripts/Makefile.build:249: /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.o] Error 1
make[4]: *** [Makefile:1947: /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux] Error 2
make[3]: *** [Makefile:238: default] Error 2
gmake[2]: *** [driver/CMakeFiles/driver_linux.dir/build.make:71: driver/CMakeFiles/driver_linux] Error 2
gmake[1]: *** [CMakeFiles/Makefile2:209: driver/CMakeFiles/driver_linux.dir/all] Error 2

Environment variables

No response

Extra information

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[cedrik-fuoco-adsk]

I did not have time to try yet, but upgrading to the latest version of AJA might fix the issue.

[sohovfx]

Hi Tony,
You will need to modify the file /disk1/scratch/wwira/git_repo/OpenRV/_build/RV_DEPS_AJA/src/driver/linux/ntv2dma.c around line 2799 based on the OS you are using.

This section bifurcates a call to get_user_pages based on the OS kernel level. The number and placement of the arguments has changed, just comment the lines that don't apply to your kernel version.

[TonyKaap]

Thanks! (Will has the testbed, and it will be December before he has time to test this again)

[williamwira]

@cedrik-fuoco-adsk Thanks for your idea! Looks like upgrading to AJA 17.5.0 resolves this build issue. (Note: I hit other build errors on RHEL 9.6 in the OTIO step, but that's a separate issue).

I can put in the PR for the upgrade if that helps, or if you guys are already making the change (I think I heard updating AJA was in progress), I can wait on that. Let me know what you think -- thanks!

[cedrik-fuoco-adsk]

Hi @williamwira,

You can open the PR but we won't be merging it before the next quarter since we won't have the capacity to tests the new version fully.

Thank you for testing it!

[bernie-laberge]

@cedrik-fuoco-adsk : How come we don't have this build issue in github actions or in our Autodesk jenkins agents ?

[cedrik-fuoco-adsk]

@bernie-laberge I think the issue is only with Rocky Linux 9.6 (due to kernel change?). Both Github action and Autodesk Jenkins is using the container image rockylinux:9.

[williamwira]

@cedrik-fuoco-adsk I can confirm the other build issue I hit has been resolved with a recent commit. So building with AJA 17.5 is all that's needed for RHEL 9.6.

I'll put in the commit, and it's all good if you want to wait until the right time to merge it. Thanks!