#604: Fix Blackmagic Video Output plugin build on Windows #605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernie-laberge
requested review from
cedrik-fuoco-adsk and
eloisebrosseau
as code owners
eloisebrosseau
approved these changes
Oct 17, 2024
Contributor
eloisebrosseau
left a comment
eloisebrosseau
left a comment
There was a problem hiding this comment.
Small typo in the comment, but otherwise LGTM!
Signed-off-by: Bernard Laberge <[email protected]>
cedrik-fuoco-adsk
approved these changes
Oct 18, 2024
bernie-laberge
merged commit bb5ea87
into
AcademySoftwareFoundation:main
11 checks passed
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Nov 7, 2024
…ld on Windows (AcademySoftwareFoundation#605) ### 604: Fix Blackmagic Video Output plugin build on Windows ### Linked issues Fixes AcademySoftwareFoundation#604 ### Summarize your change. Added a post-install step in the BlackMagicDevice cmake file (bmd.cmake) to generate the DeckLinkAPI.h header file via midl.exe which is required to build the Blackmagic Video Output plugin on Windows. Note that the BlackMagic SDK only provides .idl files on Windows (not .h header files). Since that we are building OpenRV in a non managed way, we need to generate a DesktopLinkAPI.h header file from the provided .idl files. ### Describe the reason for the change. The Blackmagic Video Output plugin build on Windows was broken. ### Describe what you have tested and on which operating system. Successfully tested on Windows. Note that this commit is Windows specific so it should not impact any other OS. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 25, 2025
…ld on Windows (AcademySoftwareFoundation#605) ### 604: Fix Blackmagic Video Output plugin build on Windows ### Linked issues Fixes AcademySoftwareFoundation#604 ### Summarize your change. Added a post-install step in the BlackMagicDevice cmake file (bmd.cmake) to generate the DeckLinkAPI.h header file via midl.exe which is required to build the Blackmagic Video Output plugin on Windows. Note that the BlackMagic SDK only provides .idl files on Windows (not .h header files). Since that we are building OpenRV in a non managed way, we need to generate a DesktopLinkAPI.h header file from the provided .idl files. ### Describe the reason for the change. The Blackmagic Video Output plugin build on Windows was broken. ### Describe what you have tested and on which operating system. Successfully tested on Windows. Note that this commit is Windows specific so it should not impact any other OS. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 28, 2025
…ld on Windows (AcademySoftwareFoundation#605) ### 604: Fix Blackmagic Video Output plugin build on Windows ### Linked issues Fixes AcademySoftwareFoundation#604 ### Summarize your change. Added a post-install step in the BlackMagicDevice cmake file (bmd.cmake) to generate the DeckLinkAPI.h header file via midl.exe which is required to build the Blackmagic Video Output plugin on Windows. Note that the BlackMagic SDK only provides .idl files on Windows (not .h header files). Since that we are building OpenRV in a non managed way, we need to generate a DesktopLinkAPI.h header file from the provided .idl files. ### Describe the reason for the change. The Blackmagic Video Output plugin build on Windows was broken. ### Describe what you have tested and on which operating system. Successfully tested on Windows. Note that this commit is Windows specific so it should not impact any other OS. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
cedrik-fuoco-adsk
pushed a commit
to cedrik-fuoco-adsk/OpenRV
that referenced
this pull request
Apr 28, 2025
…ld on Windows (AcademySoftwareFoundation#605) ### 604: Fix Blackmagic Video Output plugin build on Windows ### Linked issues Fixes AcademySoftwareFoundation#604 ### Summarize your change. Added a post-install step in the BlackMagicDevice cmake file (bmd.cmake) to generate the DeckLinkAPI.h header file via midl.exe which is required to build the Blackmagic Video Output plugin on Windows. Note that the BlackMagic SDK only provides .idl files on Windows (not .h header files). Since that we are building OpenRV in a non managed way, we need to generate a DesktopLinkAPI.h header file from the provided .idl files. ### Describe the reason for the change. The Blackmagic Video Output plugin build on Windows was broken. ### Describe what you have tested and on which operating system. Successfully tested on Windows. Note that this commit is Windows specific so it should not impact any other OS. ### Add a list of changes, and note any that might need special attention during the review. ### If possible, provide screenshots. Signed-off-by: Bernard Laberge <[email protected]> Signed-off-by: Cédrik Fuoco <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
604: Fix Blackmagic Video Output plugin build on Windows
Linked issues
Fixes #604
Summarize your change.
Added a post-install step in the BlackMagicDevice cmake file (bmd.cmake) to generate the DeckLinkAPI.h header file via midl.exe which is required to build the Blackmagic Video Output plugin on Windows.
Note that the BlackMagic SDK only provides .idl files on Windows (not .h header files). Since that we are building OpenRV in a non managed way, we need to generate a DesktopLinkAPI.h header file from the provided .idl files.
Describe the reason for the change.
The Blackmagic Video Output plugin build on Windows was broken.
Describe what you have tested and on which operating system.
Successfully tested on Windows.
Note that this commit is Windows specific so it should not impact any other OS.
Add a list of changes, and note any that might need special attention during the review.
If possible, provide screenshots.