Fixes for C++ examples (#1967)

* Fix include directories
* Change conditional for VS
* Enable examples in CI
* Fix warning about ignored return variable

Signed-off-by: Darby Johnston <[email protected]>

Author: darbyjohnston

.github/workflows/python-package.yml

@@ -55,7 +55,7 @@ jobs:
         run: |
           cmake -E make_directory ${{ env.OTIO_BUILD_DIR }}
           cd ${{ env.OTIO_BUILD_DIR }}
-          cmake ${{ github.workspace }} -DCMAKE_INSTALL_PREFIX=${{ env.OTIO_INSTALL_DIR }} -DOTIO_SHARED_LIBS=OFF -DOTIO_CXX_COVERAGE=ON
+          cmake ${{ github.workspace }} -DCMAKE_INSTALL_PREFIX=${{ env.OTIO_INSTALL_DIR }} -DOTIO_SHARED_LIBS=OFF -DOTIO_CXX_COVERAGE=ON -DOTIO_CXX_EXAMPLES=ON
           cmake --build . --config ${{ env.OTIO_BUILD_CONFIG }}
       - name: Run tests
         run: |

examples/CMakeLists.txt

@@ -1,8 +1,7 @@
 find_package(PythonLibs REQUIRED)
 
 include_directories(${PROJECT_SOURCE_DIR}/src
-    ${PROJECT_SOURCE_DIR}/src/deps
-    ${PROJECT_SOURCE_DIR}/src/deps/optional-lite/include
+    ${CMAKE_CURRENT_BINARY_DIR}/../src
     ${PYTHON_INCLUDE_DIRS})
 
 list(APPEND examples conform)

examples/flatten_video_tracks.cpp

@@ -38,7 +38,7 @@ int main(int argc, char** argv)
     // into a single track.
     std::cout << "Flattening " << video_tracks.size() << " video tracks into one..." << std::endl;
     auto onetrack = otio::flatten_stack(video_tracks, &error_status);
-    if (!onetrack or is_error(error_status))
+    if (!onetrack || is_error(error_status))
     {
         examples::print_error(error_status);
         return 1;

examples/util.cpp

@@ -132,7 +132,10 @@ std::string normalize_path(std::string const& in)
 std::string absolute(std::string const& in)
 {
     char buf[PATH_MAX];
-    realpath(in.c_str(), buf);
+    if (NULL == realpath(in.c_str(), buf))
+    {
+        buf[0] = 0;
+    }
     return buf;
 }