Skip to content

Commit e713155

Browse files
committed
updated smoketest and testonly targets to build off sdist
Signed-off-by: Eric Reinecke <[email protected]>
1 parent 1af7f5e commit e713155

File tree

1 file changed

+16
-7
lines changed

1 file changed

+16
-7
lines changed

.github/workflows/python-package.yml

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,7 @@ jobs:
8989
cmake ${{ github.workspace }}/tests/consumer -DCMAKE_PREFIX_PATH=${{ env.OTIO_INSTALL_DIR }}
9090
9191
py_smoketest_build:
92+
needs: package_sdist
9293
# Ideally this would be ${{ env.GH_COV_OS }} - but github doens't allow it
9394
runs-on: ubuntu-latest
9495
strategy:
@@ -104,9 +105,13 @@ jobs:
104105
OTIO_CXX_BUILD_TMP_DIR: ${{ github.workspace }}/build
105106

106107
steps:
107-
- uses: actions/checkout@v4
108+
- name: Get tests and requirements from source
109+
uses: actions/checkout@v4
110+
- name: Get sdist source
111+
uses: actions/download-artifact@v5
108112
with:
109-
submodules: "recursive"
113+
name: sdist
114+
path: 'sdist'
110115
- name: Set up Python ${{ matrix.python-version }}
111116
uses: actions/[email protected]
112117
with:
@@ -126,7 +131,7 @@ jobs:
126131
python -m pip install --upgrade -r tests/requirements.txt
127132
- name: Build and Install OpenTimelineIO
128133
run: |
129-
python -m pip install . -v --break-system-packages
134+
python -m pip install sdist/opentimelineio-*.tar.gz -v --break-system-packages
130135
- name: Run tests w/ python coverage
131136
run: make ci-postbuild
132137
# (only on GH_COV_OS and GH_COV_PY)
@@ -145,6 +150,7 @@ jobs:
145150

146151
# This is for platforms where we build and test, but don't make wheels
147152
py_testonly_build:
153+
needs: package_sdist
148154
# Ideally this would be ${{ env.GH_COV_OS }} - but github doens't allow it
149155
runs-on: ${{ matrix.os }}
150156
strategy:
@@ -163,9 +169,11 @@ jobs:
163169
OTIO_CXX_BUILD_TMP_DIR: ${{ github.workspace }}/build
164170

165171
steps:
166-
- uses: actions/checkout@v4
172+
- name: Get sdist source
173+
uses: actions/download-artifact@v5
167174
with:
168-
submodules: "recursive"
175+
name: sdist
176+
path: 'sdist'
169177
- name: Set up MSYS2
170178
if: matrix.python-version == 'mingw64'
171179
uses: msys2/setup-msys2@v2
@@ -186,12 +194,14 @@ jobs:
186194
- name: Install python build dependencies
187195
run: |
188196
python -m pip install --upgrade pip setuptools wheel "flake8>=3.5" check-manifest
197+
- name: Get source
198+
uses: actions/checkout@v4
189199
- name: Install test dependencies
190200
run: |
191201
python -m pip install --break-system-packages --upgrade -r tests/requirements.txt
192202
- name: Build and Install OpenTimelineIO
193203
run: |
194-
python -m pip install . -v --break-system-packages
204+
python -m pip install sdist/opentimelineio-*.tar.gz -v --break-system-packages
195205
- name: Run tests w/ python coverage
196206
run: make ci-postbuild
197207

@@ -275,7 +285,6 @@ jobs:
275285
run: make ci-postbuild
276286

277287
package_sdist:
278-
needs: py_smoketest_build
279288
runs-on: ubuntu-latest
280289
steps:
281290
- uses: actions/checkout@v4

0 commit comments

Comments
 (0)