Skip to content

Commit d3f7dc8

Browse files
committed
Don't always rebuilt ci-baseos-gl-conan
- ci-baseos-gl-conan is used to build all Conan packages, make sure it gets pull from Docker Hub instead of constantly rebuilding it (10 minutes per trivial Conan wrapper package...) - force Conan packages to always rebuild in release.yml GHA workflow - move ninja version override to correct place in ci_commonX and fix typo Signed-off-by: Jean-Francois Panisset <[email protected]>
1 parent 0061062 commit d3f7dc8

File tree

15 files changed

+15
-13
lines changed

15 files changed

+15
-13
lines changed

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ jobs:
2323
build: true
2424
push_description: true
2525
- group: conan
26-
args: --use-conan --conan-login --build-missing
26+
args: --use-conan --conan-login
2727
build: ${{ contains(github.ref, '/ci-package') }}
2828
push_description: false
2929

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
All notable changes to this project will be documented in this file.
44

5-
# 2025-09-01
5+
# 2025-09-03
66

77
2024.4 / 2025.3 / 2026.1 releases to address issues in the previous set of releases encountered by consumer
88
ASWF projects. This highlights the need for more thorough testing of non-Conan project builds in the
@@ -20,6 +20,8 @@ resulting ci-XXXX images.
2020
- Fix some discrepancies in the Conan 2 environment files (we really need a single
2121
source of truth for all version information).
2222
- Build command line utilities and Ax when building OpenVDB package, and install missing dependencies for these additional components (glfw3). Ax cannot be built with OpenVDB older than 12.1.0 since this is where support for clang/llvm 16 or newer shows up.
23+
- Dockerfile to build ci-baseos-gl-conan image should how pull from Docker Hub instead of always rebuilding locally
24+
- release.yml GHA workflow should now always rebuild even if an existing binary package exists in the Conan repository
2325
- 2024.4
2426
- revert to MaterialX 1.39.1 which is complatible with USD 24.08
2527
- install MaterialX CMake files in expected location

packages/common/Dockerfile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ ARG ASWF_BASEOS_IMAGE
2121

2222

2323
#################### ci-baseos-gl-os ####################
24-
FROM ${ASWF_BASEOS_IMAGE}:${ASWF_CUDA_VERSION}-runtime-${ASWF_BASEOS_DISTRO} AS ci-baseos-gl-os
24+
FROM ${ASWF_BASEOS_IMAGE}:${ASWF_CUDA_VERSION}-runtime-${ASWF_BASEOS_DISTRO} AS ci-baseos-gl-conan
2525

2626
ARG CI_COMMON_VERSION
2727
ENV CI_COMMON_VERSION=${CI_COMMON_VERSION}
@@ -91,13 +91,13 @@ COPY scripts/common/install_yq.sh /tmp/
9191

9292
RUN /tmp/install_yq.sh
9393

94-
#################### ci-baseos-gl-conan ####################
95-
FROM ci-baseos-gl-os AS ci-baseos-gl-conan
94+
# Merge the previously separate ci-baseos-gl-os and ci-baseos-gl-conan stages:
95+
# we are unlikely to want to iterate on Conan versions separately from the base image,
96+
# and we want to make sure that ci-conan-package-builder always pulls a pre-built
97+
# ci-baseos-gl-conan from Docker Hub rather than rebuilding it locally.
9698

9799
ARG ASWF_CONAN_VERSION
98100
ARG ASWF_CONAN_PYTHON_VERSION
99-
ARG ASWF_DTS_VERSION
100-
ARG ASWF_DTS_PREFIX
101101

102102
ENV ASWF_CONAN_ROOT=/opt/conan
103103

packages/conan/settings/profiles_aswf/ci_common4

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ clang/*:shared=False
1414
[replace_requires]
1515
[replace_tool_requires]
1616
cmake/*: cmake/3.31.7@aswf/ci_common4
17+
ninja/*: ninja/1.13.1@aswf/ci_common4
1718
[platform_requires]
1819
[buildenv]
1920
GCC_INSTALL_DIR=/opt/rh/gcc-toolset-11/root/lib/gcc/x86_64-redhat-linux/11

packages/conan/settings/profiles_aswf/ci_common5

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ clang/*:shared=False
1414
[replace_requires]
1515
[replace_tool_requires]
1616
cmake/*: cmake/3.31.7@aswf/ci_common5
17+
ninja/*: ninja/1.13.1@aswf/ci_common5
1718
[platform_requires]
1819
[buildenv]
1920
GCC_INSTALL_DIR=/opt/rh/gcc-toolset-11/root/lib/gcc/x86_64-redhat-linux/11

packages/conan/settings/profiles_aswf/ci_common6

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ clang/*:shared=False
1414
[replace_requires]
1515
[replace_tool_requires]
1616
cmake/*: cmake/4.0.2@aswf/ci_common6
17+
ninja/*: ninja/1.13.1@aswf/ci_common6
1718
[platform_requires]
1819
[buildenv]
1920
GCC_INSTALL_DIR=/opt/rh/gcc-toolset-14/root/lib/gcc/x86_64-redhat-linux/14

packages/conan/settings/profiles_aswf/vfx2024

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ gperf/*: gperf/3.1@system
109109
libtool/*: libtool/2.4.6@system
110110
mesno/*: meson/0.58.2@system
111111
nasm/*: nasm/system@aswf/vfx2024
112-
ninja/*: ninja/1.13.1@aswf/ci_common5
113112
nodejs/*: nodejs/18.20.4@system
114113
pkgconf/*: pkgconf/1.4.2@system
115114
wayland/*: wayland/1.21.0@system

packages/conan/settings/profiles_aswf/vfx2025

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ gperf/*: gperf/3.1@system
109109
libtool/*: libtool/2.4.6@system
110110
meson/*: meson/0.58.2@system
111111
nasm/*: nasm/system@aswf/vfx2025
112-
ninja/*: ninja/1.13.1@aswf/ci_common5
113112
nodejs/*: nodejs/18.20.4@system
114113
pkgconf/*: pkgconf/1.4.2@system
115114
wayland/*: wayland/1.21.0@system

packages/conan/settings/profiles_aswf/vfx2026

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ gperf/*: gperf/3.1@system
111111
libtool/*: libtool/2.4.6@system
112112
meson/*: meson/0.58.2@system
113113
nasm/*: nasm/system@aswf/vfx2026
114-
ninja/*: ninja/1.13.1@aswf/ci_common6
115114
nodejs/*: nodejs/18.20.4@system
116115
pkgconf/*: pkgconf/1.4.2@system
117116
wayland/*: wayland/1.21.0@system

packages/conan/settings/profiles_aswftesting/ci_common4

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ clang/*:shared=False
1414
[replace_requires]
1515
[replace_tool_requires]
1616
cmake/*: cmake/3.31.7@aswftesting/ci_common4
17+
ninja/*: ninja/1.13.1@aswftesting/ci_common4
1718
[platform_requires]
1819
[buildenv]
1920
GCC_INSTALL_DIR=/opt/rh/gcc-toolset-11/root/lib/gcc/x86_64-redhat-linux/11

0 commit comments

Comments
 (0)