Skip to content

Commit f1123da

Browse files
committed
OCIO 2024 vs minizip-ng
Update patch to CMake modules to reflect minizip-ng conan package name Signed-off-by: Jean-Francois Panisset <[email protected]>
1 parent c02f5a7 commit f1123da

File tree

2 files changed

+84
-1
lines changed

2 files changed

+84
-1
lines changed

packages/conan/recipes/ocio/conandata.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ patches:
4646
patch_description: "use cci package, use PROJECT_BINARY_DIR/PROJECT_SOURCE_DIR"
4747
patch_type: "conan"
4848
"2.3.2":
49-
- patch_file: "patches/2.3.1-0001-fix-cmake-source-dir-and-targets.patch"
49+
- patch_file: "patches/2.3.2-0001-fix-cmake-source-dir-and-targets.patch"
5050
patch_description: "use cci package, use PROJECT_BINARY_DIR/PROJECT_SOURCE_DIR"
5151
patch_type: "conan"
5252
- patch_file: "patches/2.3.2-0004-find-python.patch"
Lines changed: 83 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,83 @@
1+
diff --git CMakeLists.txt CMakeLists.txt
2+
index 7b62a993..5ea33694 100755
3+
--- CMakeLists.txt
4+
+++ CMakeLists.txt
5+
@@ -511,7 +511,7 @@ install(
6+
FILE ${OCIO_TARGETS_EXPORT_NAME}
7+
)
8+
9+
-if (NOT BUILD_SHARED_LIBS)
10+
+if (0)
11+
# Install custom macros used in the find modules.
12+
install(FILES
13+
${CMAKE_CURRENT_LIST_DIR}/share/cmake/macros/VersionUtils.cmake
14+
diff --git share/cmake/modules/FindExtPackages.cmake share/cmake/modules/FindExtPackages.cmake
15+
index 2625242c..dcb41cf2 100644
16+
--- share/cmake/modules/FindExtPackages.cmake
17+
+++ share/cmake/modules/FindExtPackages.cmake
18+
@@ -63,7 +63,7 @@ ocio_handle_dependency( expat REQUIRED ALLOW_INSTALL
19+
# https://github.com/jbeder/yaml-cpp
20+
ocio_handle_dependency( yaml-cpp REQUIRED ALLOW_INSTALL
21+
MIN_VERSION 0.6.3
22+
- RECOMMENDED_VERSION 0.7.0
23+
+ RECOMMENDED_VERSION 0.8.0
24+
RECOMMENDED_VERSION_REASON "Latest version tested with OCIO")
25+
26+
# pystring
27+
@@ -112,7 +112,7 @@ ocio_handle_dependency( ZLIB REQUIRED ALLOW_INSTALL
28+
# https://github.com/zlib-ng/minizip-ng
29+
ocio_handle_dependency( minizip-ng REQUIRED ALLOW_INSTALL
30+
MIN_VERSION 3.0.6
31+
- RECOMMENDED_VERSION 3.0.7
32+
+ RECOMMENDED_VERSION 4.0.10
33+
RECOMMENDED_VERSION_REASON "Latest version tested with OCIO")
34+
35+
###############################################################################
36+
@@ -131,7 +131,7 @@ if(OCIO_BUILD_APPS)
37+
38+
# lcms2
39+
# https://github.com/mm2/Little-CMS
40+
- ocio_handle_dependency( lcms2 REQUIRED ALLOW_INSTALL
41+
+ ocio_handle_dependency( lcms REQUIRED ALLOW_INSTALL
42+
MIN_VERSION 2.2
43+
RECOMMENDED_VERSION 2.2
44+
RECOMMENDED_VERSION_REASON "Latest version tested with OCIO")
45+
diff --git share/cmake/utils/CppVersion.cmake share/cmake/utils/CppVersion.cmake
46+
index 175d89c2..ac93b87a 100644
47+
--- share/cmake/utils/CppVersion.cmake
48+
+++ share/cmake/utils/CppVersion.cmake
49+
@@ -16,7 +16,7 @@ elseif(NOT CMAKE_CXX_STANDARD IN_LIST SUPPORTED_CXX_STANDARDS)
50+
"CMAKE_CXX_STANDARD=${CMAKE_CXX_STANDARD} is unsupported. Supported standards are: ${SUPPORTED_CXX_STANDARDS_STR}.")
51+
endif()
52+
53+
-set_property(CACHE CMAKE_CXX_STANDARD PROPERTY STRINGS "${SUPPORTED_CXX_STANDARDS}")
54+
+# set_property(CACHE CMAKE_CXX_STANDARD PROPERTY STRINGS "${SUPPORTED_CXX_STANDARDS}")
55+
56+
include(CheckCXXCompilerFlag)
57+
58+
diff --git src/OpenColorIO/CMakeLists.txt src/OpenColorIO/CMakeLists.txt
59+
index 26b4bb4c..d54cff3d 100755
60+
--- src/OpenColorIO/CMakeLists.txt
61+
+++ src/OpenColorIO/CMakeLists.txt
62+
@@ -309,7 +309,7 @@ target_link_libraries(OpenColorIO
63+
"$<BUILD_INTERFACE:utils::from_chars>"
64+
"$<BUILD_INTERFACE:utils::strings>"
65+
"$<BUILD_INTERFACE:xxHash>"
66+
- ${YAML_CPP_LIBRARIES}
67+
+ PUBLIC yaml-cpp
68+
MINIZIP::minizip-ng
69+
)
70+
71+
diff --git src/apps/ociobakelut/CMakeLists.txt src/apps/ociobakelut/CMakeLists.txt
72+
index 3d6e586b..f7069a1f 100755
73+
--- src/apps/ociobakelut/CMakeLists.txt
74+
+++ src/apps/ociobakelut/CMakeLists.txt
75+
@@ -29,7 +29,7 @@ set_target_properties(ociobakelut
76+
target_link_libraries(ociobakelut
77+
PRIVATE
78+
apputils
79+
- lcms2::lcms2
80+
+ lcms::lcms
81+
OpenColorIO
82+
)
83+

0 commit comments

Comments
 (0)