Bug: The family parameter is missing from oapve_param_parse

[richardssam]

Ffmpeg is is unable to encode based on the "family" parameter, since its not actually passed through oapve_param_parse.

For example, ffmpeg -i "INPUTFILE.dpx" -vframes 1 -c:v liboapv -pix_fmt yuv422p10le -oapv-params family=422-HQ -preset fast -y "OUTPUTFILE.mov"
with ffmpeg-8.0 produces an error:
[liboapv @ 0x13d105030] Error parsing option 'family = 422-HQ'.

Looking at the function, family is missing.

Sam.

[dkozinski]

The error is thrown by the liboapv library. When calling the ffmpeg oapv-params "key=value" command, the parameters following the oapv-params option are passed directly to the oapve_param_parse library function.

[richardssam]

Exactly, oapve_param_parse is missing support for the "family" parameter that is in oapv_app_enc application. I think we need to move the logic for that argument from the oapv_app_enc.c to oapv.c and oapv_param.c

[dkozinski]

The APV family is not formally defined in the APV specification. Information regarding achieving desired quality and defining typical setups is available through apv_family.md and name-levels-and-bands.

For example for a UHD 4K 60p video for preservig the high quality video (4:2:2 HQ), a 1,592 Mb/s bitrate is needed (target-bitrates-of-apv-family).
Since luma sample rate for UHD 4K 60p video is 3840x2160x60=497,664,000 samples/sec, corresponding max luma sample rate is 530,841,600, and max coded data rate is 1,784 Mb/s, which sets level to 4.1 and band_idc to 2.

[dkozinski]

Work is in progress to add support for the APV family in FFmpeg.
https://github.com/openapv/ffapv/pull/89

[richardssam]

Thanks!