Skip to content

Commit 78a3b11

Browse files
committed
Fix spec and host support lib to return proper val for host type
Image Effect Host objects must have `OfxPropType` with value "OfxTypeImageEffectHost" (== `kOfxTypeImageEffectHost`). The host support lib was incorrectly returning the string "Host" here. Fixes #186. Signed-off-by: Gary Oberbrunner <[email protected]>
1 parent 80a1ade commit 78a3b11

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Documentation/sources/Reference/ofxPropertiesByObject.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,11 @@ Properties on the Image Effect Host
1515
- kOfxPropAPIVersion
1616
- (read only) the version of the API implemented by the host. If not present, it is safe to assume "1.0"
1717
- kOfxPropType
18-
- (read only) set to "host"
18+
- (read only) type of the object. Set to kOfxTypeImageEffectHost
1919
- kOfxPropName
2020
- (read only) the globally unique name of the application, eg: "com.acmesofware.funkyCompositor"
2121
- kOfxPropLabel
22-
- (read only) the user visible name of the appliaction,
22+
- (read only) the user visible name of the application
2323
- kOfxPropVersion
2424
- (read only) the version number of the host
2525
- kOfxPropVersionLabel

HostSupport/src/ofxhHost.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ namespace OFX {
5656

5757
static const Property::PropSpec hostStuffs[] = {
5858
{ kOfxPropAPIVersion, Property::eInt, 0, false, "" },
59-
{ kOfxPropType, Property::eString, 1, false, "Host" },
59+
{ kOfxPropType, Property::eString, 1, false, kOfxTypeImageEffectHost },
6060
{ kOfxPropName, Property::eString, 1, false, "UNKNOWN" },
6161
{ kOfxPropLabel, Property::eString, 1, false, "UNKNOWN" },
6262
{ kOfxPropVersion, Property::eInt, 0, false, "0" },

release-notes.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,9 @@ This is version 1.6 of the OpenFX API.
1919

2020
## Fixes in OpenFX Version 1.6:
2121

22+
- Clarify that Image Effect Hosts property `kOfxPropType` must have the value
23+
`kOfxTypeImageEffectHost`, and fix host support lib to implement that.
24+
2225
## Deprecations
2326

2427
## Detailed List of Changes

0 commit comments

Comments
 (0)