Skip to content

Commit b932f99

Browse files
committed
Fix doc for clipGetRegionOfDefinition
Signed-off-by: Gary Oberbrunner <[email protected]>
1 parent ebd04b8 commit b932f99

File tree

2 files changed

+6
-16
lines changed

2 files changed

+6
-16
lines changed

Documentation/sources/Guide/ofxExample5_Circle.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -364,7 +364,7 @@ What is this region of definition action? Easy, an effect and a clip
364364
have a region of definition (RoD). This is the maximum rectangle for
365365
which an effect or clip can produce pixels. You can ask for RoD of a
366366
clip via the :cpp:func:`OfxImageEffectSuiteV1::clipGetRegionOfDefinition` function in the image
367-
effect suite. The RoD is currently defined in canonical coordinates [4]_.
367+
effect suite. The RoD is defined in canonical coordinates [4]_.
368368

369369
Note that the RoD is independent of the **bounds** of a image, an
370370
image’s bounds may be less than, more than or equal to the RoD. It is up

include/ofxImageEffect.h

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1582,18 +1582,11 @@ If clipGetImage is called twice with the same parameters, then two separate imag
15821582
*/
15831583
OfxStatus (*clipReleaseImage)(OfxPropertySetHandle imageHandle);
15841584

1585-
15861585
/** @brief Returns the spatial region of definition of the clip at the given time
15871586
1588-
\arg \c clipHandle clip to extract the image from
1589-
\arg \c time time to fetch the image at
1590-
\arg \c region region to fetch the image from (optional, set to NULL to get a 'default' region)
1591-
this is in the \ref CanonicalCoordinates.
1592-
\arg \c imageHandle handle where the image is returned
1593-
1594-
An image is fetched from a clip at the indicated time for the given region and returned in the imageHandle.
1595-
1596-
If the \e region parameter is not set to NULL, then it will be clipped to the clip's Region of Definition for the given time. The returned image will be \em at \em least as big as this region. If the region parameter is not set, then the region fetched will be at least the Region of Interest the effect has previously specified, clipped the clip's Region of Definition.
1587+
\arg \c clipHandle return this clip's region of definition
1588+
\arg \c time time to use when determining clip's region of definition
1589+
\arg \c bounds (out) bounds are returned here -- in \ref CanonicalCoordinates
15971590
15981591
\pre
15991592
- clipHandle was returned by clipGetHandle
@@ -1602,13 +1595,10 @@ If clipGetImage is called twice with the same parameters, then two separate imag
16021595
- bounds will be filled the RoD of the clip at the indicated time
16031596
16041597
@returns
1605-
- ::kOfxStatOK - the image was successfully fetched and returned in the handle,
1606-
- ::kOfxStatFailed - the image could not be fetched because it does not exist in the clip at the indicated time, the plugin
1607-
should continue operation, but assume the image was black and transparent.
1598+
- ::kOfxStatOK - the region was successfully found and returned in the handle,
1599+
- ::kOfxStatFailed - the region could not be determined,
16081600
- ::kOfxStatErrBadHandle - the clip handle was invalid,
16091601
- ::kOfxStatErrMemory - the host had not enough memory to complete the operation, plugin should abort whatever it was doing.
1610-
1611-
16121602
*/
16131603
OfxStatus (*clipGetRegionOfDefinition)(OfxImageClipHandle clip,
16141604
OfxTime time,

0 commit comments

Comments
 (0)