Merge pull request #75 from framestore/per-frame-randomization

joshbainbridge · web-flow · commit 83e39f7e25de · 2025-08-23T21:43:19.000+01:00
Add back per-frame randomization
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 
 - Update org name to AcademySoftwareFoundation.
+- Add back per-frame randomization to sampler state.
 
 ### Deprecated
 ### Removed
diff --git a/images/plots/cornell-box-0-2-dark.png b/images/plots/cornell-box-0-2-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ed5c7547cc6937c610fc3d381a4e1b032a1ae68e8975196eb7e753fa0c887241
+oid sha256:f663b094e42499ec46837ceda859ad3cf92aa9dbf31bf0e00b1ebdbbbf7a3d3e
 size 359142
diff --git a/images/plots/cornell-box-0-2-light.png b/images/plots/cornell-box-0-2-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:86ec260407faae85bd84d8d268d8c4e485543be3bd990566ebc82fe28fc0a535
+oid sha256:6f086e49223da2578e3ce62a9f08659b9737b4dc4a6245fc7d33b832eb3389e6
 size 360114
diff --git a/images/plots/cornell-box-1-2-dark.png b/images/plots/cornell-box-1-2-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:76b7542edb9447cc9914f7f0f4888539ec5ec232ea1ffaec0096de3a28002e50
+oid sha256:de553d52240cfb13503ed679459f3f17f7b209764a7ab2759707bf779139ff1a
 size 916183
diff --git a/images/plots/cornell-box-1-2-light.png b/images/plots/cornell-box-1-2-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:3b28d273782082487ddb478354d9c1599f4ab604181ab8b6ba4828c1f86ed121
+oid sha256:666eaf53b9e085eb4a5b6698b61504df333aed81cc9947ad688486a2b5e039c4
 size 916848
diff --git a/images/plots/cornell-box-1-32-dark.png b/images/plots/cornell-box-1-32-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:bb4fe0a68a3139be1455680a7efbc3e68c36588f6b2152039256ee7fa3fdb513
+oid sha256:2eaa85e17b54de4a884e07438bc09fc01fe9564daa4de75820a0b377430e000e
 size 872498
diff --git a/images/plots/cornell-box-1-32-light.png b/images/plots/cornell-box-1-32-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:4c52edf917d79e244e498965d9b14d6430a86e7e76b4cd632613adf207626319
+oid sha256:0a70cb270e38b6e73c6c53adb7cb842c62ad97f0518fefa4ec31d3227b12cdf7
 size 873326
diff --git a/images/plots/cornell-box-sample-splitting-2-8-dark.png b/images/plots/cornell-box-sample-splitting-2-8-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6f5845a38dec77129dc8d67185b083a6e88c23f0575c39d54ac700152d194577
+oid sha256:5988b39ef452e26b1ffde84242f52c3d6925b7f6dc3f88f1b2048eb370918df5
 size 269953
diff --git a/images/plots/cornell-box-sample-splitting-2-8-light.png b/images/plots/cornell-box-sample-splitting-2-8-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ebb986dabd804ae9e64fa12a6f80364de9ca36f477b0ea311212be04298d6807
+oid sha256:7a98bb30a57c401c5a1cf2cb7733a657b0d61ba525f75200ed7d4eebf61a18f1
 size 271012
diff --git a/images/plots/cornell-box-sample-splitting-8-2-dark.png b/images/plots/cornell-box-sample-splitting-8-2-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:02ecf7662a476c52b60e61f10e016d1723a7fde8e85ba06248522265da8a277b
+oid sha256:79c4c9fcc14a3c87ff82886b651d477d706bdca4fcfaf168df7bbdec4fea486b
 size 269266
diff --git a/images/plots/cornell-box-sample-splitting-8-2-light.png b/images/plots/cornell-box-sample-splitting-8-2-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:1ebd2c0e0866ee20018cfc17785c0cb405ca506a392229c7ac5be83bf04efeaf
+oid sha256:ac5650c362d2515e2242a4ba0d349e26ee03e728a7ad4137a0ab55b2df3479b8
 size 270266
diff --git a/images/plots/error-filter-space-plot-dark.png b/images/plots/error-filter-space-plot-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:a17a22f845d7ce6e007cace5d96eab78767a5fc1e4bdeaff6a0e0a2c5f47e534
+oid sha256:d7552b0ef68588b07f7b4dc8be9c284088257e7465a092018b91d12ffc8eaa7d
 size 623029
diff --git a/images/plots/error-filter-space-plot-light.png b/images/plots/error-filter-space-plot-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:0893edba9c0614aba040b43cf54e47a5e0792e54a411bac09184a9ff08433359
+oid sha256:7e6ccc40f10a621db69bb22922e35df9ddcca57c722ed37cdded4b13c917ef15
 size 628673
diff --git a/images/plots/error-plot-dark.png b/images/plots/error-plot-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:b033ad32a02fb7466fe8c20c74da14c9c4944c3d21f309692a2e10782d213ee8
+oid sha256:4748074a04fec762e18078f44e52894dc9b6e85075887e141bdb844b0ea85552
 size 353902
diff --git a/images/plots/error-plot-light.png b/images/plots/error-plot-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:c1eedf15bc3eaa3cd33b5b61a95e398ddb4dfe4b5ca9ef9008a15d037c2659fb
+oid sha256:35e78a9cde57ad12ca0a93f8ae7dab270ed3da6d055d7aac7e31c4e4931d5e0c
 size 363507
diff --git a/images/plots/mc-qmc-compared-dark.png b/images/plots/mc-qmc-compared-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:69273cf37dfd10aeab994cb61a569c1d0ca5aab60b899ada021723e3fd80a350
+oid sha256:5912f4a669b38bdfb1fb4dd795e91c6e85f37f43aababecc0ea5a38c5a5822b1
 size 203834
diff --git a/images/plots/mc-qmc-compared-light.png b/images/plots/mc-qmc-compared-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:23273b3c650fc5f74e8ff8d1bdff8dd94434e1f7033a0bfc878dd18669e0f278
+oid sha256:6b2f4a284bf827ea144ffa87d7fb461193e8e1e87e247f30acf8dd0bee3533d4
 size 212194
diff --git a/images/plots/openqmc-example-dark.png b/images/plots/openqmc-example-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:6332c2256c45782f240d88020b40a48f507b526360e2cee2c9e3e570bac8f106
+oid sha256:0a6e1c62dffd217532714bf8a0c783df193484a72ed4c52dd05a701cbdc437a1
 size 2749327
diff --git a/images/plots/openqmc-example-light.png b/images/plots/openqmc-example-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:ead83370c59d191cd0106c68f2e96859349a7a22308e8d80332ff70fe06d6c30
+oid sha256:5b31b2568113aa7b5fb73a2fc3cf57655b19605ffbb6b5005f01275f700fc9fe
 size 2749840
diff --git a/images/plots/pair-plot-lattice-dark.png b/images/plots/pair-plot-lattice-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:40adc2ae15fe03ccb1197ad3a13216ff6d003fc9f73a3b0aee545f5064f213d1
+oid sha256:38f396a175f671443cc776f92e53a629b92bf1fd107b47e08d977e9d6bdef171
 size 1387873
diff --git a/images/plots/pair-plot-lattice-light.png b/images/plots/pair-plot-lattice-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:fb07393c1e0b16a700d662a216d45dd04375d48b4aa54b5495b030c8c88ece8c
+oid sha256:9f4252b509cd64e47293b3b46f8ff0697ba558c1b8b85d4a44a365b42f008904
 size 1393729
diff --git a/images/plots/pair-plot-pmj-dark.png b/images/plots/pair-plot-pmj-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:c21a5b5570067cd045697bf579a3018033d12ea8cdcc88f6ac85a63e16c44662
+oid sha256:2214dfb049af7d90787f5c3abef629b5a26785b3f8f0231f35136d19a380c735
 size 1434297
diff --git a/images/plots/pair-plot-pmj-light.png b/images/plots/pair-plot-pmj-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7824fdaf70929210d6c1162b19229d0b57270cf57ed04430bca4b5e17e103c89
+oid sha256:fcfb9dc254a8895bc095a5c6e69e30793d02e4cf3f731aad1689bae8dd15cb4c
 size 1449510
diff --git a/images/plots/pair-plot-sobol-dark.png b/images/plots/pair-plot-sobol-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:bdecdb8759bacc834d1e27890c3ebbc0fe90b95a03fe46d7d1e348b4b1384e4e
+oid sha256:52b7efcc6e41e49f4165ebc13bf6fcb60048464cd3168f8cb3434f9a6a0dad1a
 size 1394676
diff --git a/images/plots/pair-plot-sobol-light.png b/images/plots/pair-plot-sobol-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:c071e0c4cfc5df2422565b8b465d67e1615566af04be3e3775dc22f5d6c992e7
+oid sha256:d6ed1878d609cc146eb66d1c8e48482a1c0ccc69d0a31fbc6c19b78e1b7e0cc3
 size 1409445
diff --git a/images/plots/zoneplate-plot-dark.png b/images/plots/zoneplate-plot-dark.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:fd987bce458df4093cbd86c3c7966f370caf8d1d8fad497e02551c0774217066
+oid sha256:64fb5bded2a236a0055918d1ced701855ca1a7feec374ba38497c756cc8dd020
 size 1548093
diff --git a/images/plots/zoneplate-plot-light.png b/images/plots/zoneplate-plot-light.png
@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:19c5194f4631d0ac3abe69b839dcbecf0863dd06e9bc5a22fa57cd0c501707b9
+oid sha256:860f79e299df7d1eb7b38dbd0f17cc84c7cffbf8de62f1fa5ba4f6c5bdf6a284
 size 1551825
diff --git a/include/oqmc/state.h b/include/oqmc/state.h
@@ -119,9 +119,9 @@ inline State64Bit::State64Bit(int x, int y, int frame, int index)
 	constexpr auto xBits = State64Bit::spatialEncodeBitSizeX;
 	constexpr auto yBits = State64Bit::spatialEncodeBitSizeY;
 
-	const auto pixelId = encodeBits16<xBits, yBits, 0>({x, y, frame});
+	const auto pixelId = encodeBits16<xBits, yBits, 0>({x, y, 0});
 
-	this->patternId = pcg::init(indexKey);
+	this->patternId = pcg::init(frame + indexKey);
 	this->sampleId = indexId;
 	this->pixelId = pixelId;
 }
