added more tests of arguments to PolySoupToLevelSet.h

Signed-off-by: Ken Museth <ken.museth@gmail.com>

Author: kmuseth

openvdb/openvdb/tools/PolySoupToLevelSet.h

@@ -264,10 +264,27 @@ PolySoupToLevelSet<GridType>::PolySoupToLevelSet(PolySoup &&poly, int dim, float
     if constexpr(!std::is_floating_point<typename GridType::ValueType>::value) {
         OPENVDB_THROW(TypeError, "polySoupToLevelSet: supported only for scalar floating-point grids");
     }
+    if (!(mHalfWidth > 0.0f)) {
+        OPENVDB_THROW(ValueError, "polySoupToLevelSet: halfWidth must be positive");
+    }
     if (!mPoly.bbox) mPoly.bbox = PolySoupToLevelSet::getBBox(mPoly.vtx);
+    // The largest extent is what the algorithm divides by; requiring it to be
+    // positive rejects both empty geometry (an unpopulated bbox has a negative
+    // extent) and a single degenerate point, while still allowing a flat/planar
+    // mesh (zero extent along one axis is fine for shrink wrapping).
     const float maxLength = mPoly.bbox.extents()[mPoly.bbox.maxExtent()];
+    if (!(maxLength > 0.0f)) {
+        OPENVDB_THROW(ValueError, "polySoupToLevelSet: bounding box has non-positive extent (no input geometry?)");
+    }
     mMinVoxelSize = maxLength/(float(dim) - 2.0f*(mHalfWidth + 1.0f));// +1 since final surface is dilated by dx
     mMaxVoxelSize = maxLength / 2.0f;
+    // A too-small dim relative to halfWidth drives the denominator above to zero
+    // or negative, yielding a non-finite or non-positive voxel size.
+    if (!math::isFinite(mMinVoxelSize) || !(mMinVoxelSize > 0.0f) ||
+        !math::isFinite(mMaxVoxelSize) || !(mMaxVoxelSize > 0.0f)) {
+        OPENVDB_THROW(ArithmeticError, "polySoupToLevelSet: computed voxel size is not "
+            "finite and positive (is dim too small for the given halfWidth?)");
+    }
     OPENVDB_ASSERT(2*mMinVoxelSize <= mMaxVoxelSize);
 }// tools::PolySoupToLevelSet::PolySoupToLevelSet()
 
@@ -280,9 +297,23 @@ PolySoupToLevelSet<GridType>::PolySoupToLevelSet(PolySoup &&poly, float voxelSiz
     if constexpr(!std::is_floating_point<typename GridType::ValueType>::value) {
         OPENVDB_THROW(TypeError, "polySoupToLevelSet: supported only for scalar floating-point grids");
     }
+    if (!(mHalfWidth > 0.0f)) {
+        OPENVDB_THROW(ValueError, "polySoupToLevelSet: halfWidth must be positive");
+    }
+    if (!math::isFinite(mMinVoxelSize) || !(mMinVoxelSize > 0.0f)) {
+        OPENVDB_THROW(ValueError, "polySoupToLevelSet: voxelSize must be finite and positive");
+    }
     if (!mPoly.bbox) mPoly.bbox = PolySoupToLevelSet::getBBox(mPoly.vtx);
+    // See note in the dim-based constructor: the largest extent must be positive
+    // (rejects empty/degenerate geometry) but a flat/planar mesh is allowed.
     const float maxLength = mPoly.bbox.extents()[mPoly.bbox.maxExtent()];
+    if (!(maxLength > 0.0f)) {
+        OPENVDB_THROW(ValueError, "polySoupToLevelSet: bounding box has non-positive extent (no input geometry?)");
+    }
     mMaxVoxelSize = maxLength / 2.0f;
+    if (!math::isFinite(mMaxVoxelSize) || !(mMaxVoxelSize > 0.0f)) {
+        OPENVDB_THROW(ArithmeticError, "polySoupToLevelSet: computed voxel size is not finite and positive");
+    }
     OPENVDB_ASSERT(2*mMinVoxelSize <= mMaxVoxelSize);
 }// tools::PolySoupToLevelSet::PolySoupToLevelSet()