PR review comment address

Signed-off-by: Aleksandr Motsjonov <[email protected]>

Author: soswow

src/rawtoaces_core/rawtoaces_core.cpp

@@ -416,7 +416,7 @@ bool SpectralSolver::calculate_WB()
     {
         std::cerr << "ERROR: camera needs to be initialised prior to calling "
                   << "SpectralSolver::calculate_WB()" << std::endl;
-        // TODO: Should here be return false?
+        return false;
     }
 
     if ( illuminant.data.count( "main" ) == 0 ||

src/rawtoaces_util/image_converter.cpp

@@ -338,13 +338,9 @@ bool prepare_transform_spectral(
 
         success = solver.find_illuminant( tmp_wb_multipliers );
 
-        if ( !success )
-        {
-            // TODO: Potentially remove, since this code path is not reachable due to camera lookup success in the previous step.
-            std::cerr << "ERROR: Failed to find a suitable illuminant."
-                      << std::endl;
-            return false;
-        }
+        // Expected to be true due to camera lookup success in the previous step,
+        // since lack of camera is the only way for find_illuminant to return false;
+        assert( success );
 
         if ( settings.verbosity > 0 )
         {