Added basic python test for ImageConverter bindings

Signed-off-by: hyi18 <[email protected]>

Author: hyi18

.github/workflows/ci.yml

@@ -65,7 +65,7 @@ jobs:
         shell: bash
         run: |
             sudo yum install --setopt=tsflags=nodocs -y eigen3-devel ceres-solver-devel json-devel
-            sudo python -m pip install nanobind
+            sudo python -m pip install nanobind pytest
 
       - name: Configure CMake
         # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
@@ -153,7 +153,7 @@ jobs:
         shell: bash
         run: |
             sudo yum install --setopt=tsflags=nodocs -y eigen3-devel ceres-solver-devel json-devel
-            sudo python -m pip install nanobind
+            sudo python -m pip install nanobind pytest
 
       - name: Configure CMake
         # Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.

.gitignore

@@ -1,4 +1,5 @@
 .DS_Store
 build/
 build-coverage/
-tests/materials/*.exr
+tests/materials/*.exr
+__pycache__/

build_scripts/install_deps_linux.bash

@@ -10,3 +10,5 @@ time sudo apt-get -q -f install -y \
     libopencv-dev \
     openimageio-tools libopenimageio-dev \
     nanobind-dev
+
+pip3 install pytest

build_scripts/install_deps_mac.bash

@@ -3,3 +3,5 @@
 set -ex
 
 brew install ceres-solver nlohmann-json openimageio nanobind robin-map
+
+python3 -m pip install --break-system-packages pytest

build_scripts/install_deps_windows.bash

@@ -7,3 +7,5 @@ vcpkg install \
     nlohmann-json:x64-windows \
     openimageio:x64-windows \
     nanobind:x64-windows
+
+pip install pytest

tests/CMakeLists.txt

@@ -200,6 +200,30 @@ target_link_libraries(
 setup_test_coverage(Test_ImageConverter)
 add_test ( NAME Test_ImageConverter COMMAND Test_ImageConverter )
 
+################################################################################
+# Python tests
+if(RTA_BUILD_PYTHON_BINDINGS)
+    if(Python_EXECUTABLE)
+        add_test(
+            NAME Test_Python_ImageConverter
+            COMMAND ${Python_EXECUTABLE} -m pytest ${CMAKE_CURRENT_SOURCE_DIR}/python/test_image_converter.py -v
+            WORKING_DIRECTORY ${CMAKE_SOURCE_DIR}
+        )
+
+        # Set environment for Python test to find the compiled module
+        # Handle both single-config (Linux/macOS) and multi-config (Windows) generators
+        if(WIN32)
+            set_tests_properties(Test_Python_ImageConverter PROPERTIES
+                ENVIRONMENT "PYTHONPATH=${CMAKE_BINARY_DIR}/src/bindings/Release;${CMAKE_BINARY_DIR}/src/bindings;$ENV{PYTHONPATH}"
+            )
+        else()
+            set_tests_properties(Test_Python_ImageConverter PROPERTIES
+                ENVIRONMENT "PYTHONPATH=${CMAKE_BINARY_DIR}/src/bindings:$ENV{PYTHONPATH}"
+            )
+        endif()
+    endif()
+endif()
+
 ################################################################################
 # Coverage report generation
 if( ENABLE_COVERAGE AND COVERAGE_SUPPORTED )

tests/python/test_image_converter.py

@@ -0,0 +1,69 @@
+#!/usr/bin/env python3
+# SPDX-License-Identifier: Apache-2.0
+# Copyright Contributors to the rawtoaces Project.
+
+"""
+Unit tests for rawtoaces Python bindings - ImageConverter class
+"""
+
+import pytest
+
+# The PYTHONPATH should be set by CMake to find the compiled module
+# No need to manually add paths here as CMake handles this via environment variables
+
+try:
+    import rawtoaces
+except ImportError as e:
+    pytest.skip(f"rawtoaces module not found. Build the Python bindings first: {e}", allow_module_level=True)
+
+
+class TestImageConverter:
+    """Test cases for the ImageConverter class"""
+
+    def test_converter_creation(self):
+        """Test that ImageConverter can be instantiated"""
+        converter = rawtoaces.ImageConverter()
+        assert converter is not None
+        assert isinstance(converter, rawtoaces.ImageConverter)
+
+    def test_converter_has_settings(self):
+        """Test that ImageConverter has a settings attribute"""
+        converter = rawtoaces.ImageConverter()
+        assert hasattr(converter, "settings")
+        assert converter.settings is not None
+
+    def test_converter_has_process_image_method(self):
+        """Test that ImageConverter has process_image method"""
+        converter = rawtoaces.ImageConverter()
+        assert hasattr(converter, "process_image")
+        assert callable(converter.process_image)
+
+    def test_process_image_with_invalid_path(self):
+        """Test process_image with non-existent file returns False"""
+        converter = rawtoaces.ImageConverter()
+        result = converter.process_image("/nonexistent/file.txt")
+        assert result is False
+
+        result = converter.process_image("")
+        assert result is False
+
+
+class TestSettings:
+    """Test cases for the ImageConverter.Settings class"""
+
+    def test_settings_creation(self):
+        """Test that Settings can be instantiated"""
+        converter = rawtoaces.ImageConverter()
+        settings = converter.settings
+        assert settings is not None
+        assert isinstance(settings, rawtoaces.ImageConverter.Settings)
+
+    def test_settings_direct_creation(self):
+        """Test that Settings can be created directly"""
+        settings = rawtoaces.ImageConverter.Settings()
+        assert settings is not None
+        assert isinstance(settings, rawtoaces.ImageConverter.Settings)
+
+
+if __name__ == "__main__":
+    pytest.main([__file__])