analysis

Signed-off-by: Anton Dukhovnikov <[email protected]>

Author: antond-weta

include/rawtoaces/image_converter.h

@@ -3,8 +3,8 @@
 
 #pragma once
 
-#include <OpenImageIO/imagebuf.h> // NOLINT
-#include <OpenImageIO/argparse.h> // NOLINT
+#include <OpenImageIO/imagebuf.h>
+#include <OpenImageIO/argparse.h>
 
 namespace rta
 {

include/rawtoaces/rawtoaces_core.h

@@ -170,7 +170,7 @@ class SpectralSolver
     std::vector<SpectralData> _all_illuminants;
 
     std::vector<double>              _wb_multipliers;
-    std::vector<std::vector<double>> _idt_matrix;
+    std::vector<std::vector<double>> _IDT_matrix;
 };
 
 /// DNG metadata required to calculate an input transform.

src/rawtoaces_core/rawtoaces_core.cpp

@@ -163,15 +163,15 @@ SpectralSolver::SpectralSolver(
     : _search_directories( search_directories )
 {
     verbosity = 0;
-    _idt_matrix.resize( 3 );
+    _IDT_matrix.resize( 3 );
     _wb_multipliers.resize( 3 );
     for ( int i = 0; i < 3; i++ )
     {
-        _idt_matrix[i].resize( 3 );
+        _IDT_matrix[i].resize( 3 );
         _wb_multipliers[i] = 1.0;
         for ( size_t j = 0; j < 3; j++ )
         {
-            _idt_matrix[i][j] = neutral3[i][j];
+            _IDT_matrix[i][j] = neutral3[i][j];
         }
     }
 }
@@ -744,7 +744,7 @@ bool SpectralSolver::calculate_IDT_matrix()
     auto RGB = calculate_RGB( camera, _wb_multipliers, TI );
     auto XYZ = calculate_XYZ( observer, illuminant, TI );
 
-    return curveFit( RGB, XYZ, beta_params_start, verbosity, _idt_matrix );
+    return curveFit( RGB, XYZ, beta_params_start, verbosity, _IDT_matrix );
 }
 
 //	=====================================================================
@@ -758,7 +758,7 @@ bool SpectralSolver::calculate_IDT_matrix()
 
 const vector<vector<double>> &SpectralSolver::get_IDT_matrix() const
 {
-    return _idt_matrix;
+    return _IDT_matrix;
 }
 
 const vector<double> &SpectralSolver::get_WB_multipliers() const

src/rawtoaces_util/image_converter.cpp

@@ -8,9 +8,9 @@
 #include <set>
 #include <filesystem>
 
-#include <OpenImageIO/imageio.h> // NOLINT
-#include <OpenImageIO/imagebuf.h> // NOLINT
-#include <OpenImageIO/imagebufalgo.h> // NOLINT
+#include <OpenImageIO/imageio.h>
+#include <OpenImageIO/imagebuf.h>
+#include <OpenImageIO/imagebufalgo.h>
 
 namespace rta
 {

tests/static_analysis/codechecker_skipfile.txt

@@ -0,0 +1,3 @@
+# The paths are based on Ubuntu builds
+-/usr/include/OpenImageIO/detail/fmt/format.h
+-/usr/lib/llvm-22/lib/clang/22/include/cetintrin.h

tests/test_SpectralData.cpp

@@ -7,7 +7,7 @@
 #endif
 
 #include <filesystem>
-#include <OpenImageIO/unittest.h> // NOLINT
+#include <OpenImageIO/unittest.h>
 
 #include "../src/rawtoaces_core/mathOps.h"
 #include <rawtoaces/rawtoaces_core.h>