Skip to content

Commit f17f012

Browse files
authored
replace boost::unittest with oiio::unittest (#170)
* replace boost::unittest with oiio::unittest Signed-off-by: Anton Dukhovnikov <[email protected]>
1 parent 9e37226 commit f17f012

21 files changed

+468
-377
lines changed

build_scripts/install_deps_linux.bash

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@ set -ex
55
time sudo apt-get update
66

77
time sudo apt-get -q -f install -y \
8-
libimath-dev \
9-
libboost-dev \
10-
libboost-system-dev \
11-
libboost-test-dev \
128
libceres-dev \
139
nlohmann-json3-dev \
1410
libopencv-dev \

build_scripts/install_deps_mac.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@
22

33
set -ex
44

5-
brew install ceres-solver imath boost nlohmann-json openimageio
5+
brew install ceres-solver nlohmann-json openimageio

build_scripts/install_deps_windows.bash

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,5 @@ set -ex
44

55
vcpkg install \
66
ceres:x64-windows \
7-
imath:x64-windows \
8-
boost-system:x64-windows \
9-
boost-foreach:x64-windows \
10-
boost-test:x64-windows \
11-
boost-property-tree:x64-windows \
127
nlohmann-json:x64-windows \
138
openimageio:x64-windows

config/RAWTOACESConfig.cmake.in

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ include(CMakeFindDependencyMacro)
1010

1111
find_dependency ( Eigen3 )
1212
find_dependency ( Ceres )
13-
find_dependency ( Boost COMPONENTS system )
1413
find_dependency ( OpenImageIO )
1514

1615

configure.cmake

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,6 @@ set(CMAKE_MODULE_PATH ${CMAKE_MODULE_PATH} "${CMAKE_INSTALL_PREFIX}/share/CMake"
55
find_package ( nlohmann_json CONFIG REQUIRED )
66
find_package ( OpenImageIO CONFIG REQUIRED )
77
find_package ( Eigen3 CONFIG REQUIRED )
8-
#find_package ( Imath CONFIG REQUIRED )
9-
find_package ( Boost CONFIG REQUIRED
10-
COMPONENTS
11-
system
12-
unit_test_framework
13-
)
148

159
if (RTA_CENTOS7_CERES_HACK)
1610
find_package ( Ceres MODULE REQUIRED )

src/rawtoaces_core/CMakeLists.txt

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,6 @@ add_library( ${RAWTOACES_CORE_LIB} ${DO_SHARED}
2020
target_link_libraries(
2121
${RAWTOACES_CORE_LIB}
2222
PUBLIC
23-
Boost::boost
24-
Boost::system
25-
Imath::Imath
26-
Imath::ImathConfig
2723
Eigen3::Eigen
2824
)
2925

src/rawtoaces_util/acesrender.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,6 @@ bool configure_solver(
309309
{
310310
bool success = true;
311311

312-
313312
auto camera_files = collect_data_files( directories, "camera" );
314313
for ( auto &camera_file: camera_files )
315314
{

unittest/CMakeLists.txt

Lines changed: 7 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
cmake_minimum_required(VERSION 3.12)
22

3-
add_definitions (-DBOOST_TEST_DYN_LINK)
4-
53
################################################################################
64

75
add_executable (
@@ -13,7 +11,7 @@ target_link_libraries(
1311
Test_SpectralData
1412
PUBLIC
1513
${RAWTOACES_CORE_LIB}
16-
Boost::unit_test_framework
14+
OpenImageIO::OpenImageIO
1715
)
1816

1917
add_test ( NAME Test_SpectralData COMMAND Test_SpectralData )
@@ -29,7 +27,7 @@ target_link_libraries(
2927
Test_IDT
3028
PUBLIC
3129
${RAWTOACES_CORE_LIB}
32-
Boost::unit_test_framework
30+
OpenImageIO::OpenImageIO
3331
)
3432

3533
add_test ( NAME Test_IDT COMMAND Test_IDT )
@@ -45,7 +43,7 @@ target_link_libraries(
4543
Test_Illum
4644
PUBLIC
4745
${RAWTOACES_CORE_LIB}
48-
Boost::unit_test_framework
46+
OpenImageIO::OpenImageIO
4947
)
5048

5149
add_test ( NAME Test_Illum COMMAND Test_Illum )
@@ -61,7 +59,6 @@ target_link_libraries(
6159
Test_DNGIdt
6260
PUBLIC
6361
${RAWTOACES_CORE_LIB}
64-
Boost::unit_test_framework
6562
OpenImageIO::OpenImageIO
6663
)
6764

@@ -78,7 +75,7 @@ target_link_libraries(
7875
Test_Math
7976
PUBLIC
8077
${RAWTOACES_CORE_LIB}
81-
Boost::unit_test_framework
78+
OpenImageIO::OpenImageIO
8279
)
8380

8481
add_test ( NAME Test_Math COMMAND Test_Math )
@@ -94,7 +91,7 @@ target_link_libraries(
9491
Test_Logic
9592
PUBLIC
9693
${RAWTOACES_CORE_LIB}
97-
Boost::unit_test_framework
94+
OpenImageIO::OpenImageIO
9895
)
9996

10097
add_test ( NAME Test_Logic COMMAND Test_Logic )
@@ -110,7 +107,7 @@ target_link_libraries(
110107
Test_Misc
111108
PUBLIC
112109
${RAWTOACES_CORE_LIB}
113-
Boost::unit_test_framework
110+
OpenImageIO::OpenImageIO
114111
)
115112

116113
add_test ( NAME Test_Misc COMMAND Test_Misc )
@@ -126,7 +123,7 @@ target_link_libraries(
126123
Test_UsageTimer
127124
PUBLIC
128125
${RAWTOACES_UTIL_LIB}
129-
Boost::unit_test_framework
126+
OpenImageIO::OpenImageIO
130127
)
131128

132129
add_test ( NAME Test_UsageTimer COMMAND Test_UsageTimer )

unittest/config_tests/CMakeLists.txt

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,16 +22,10 @@ if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
2222
add_compile_definitions( NOMINMAX )
2323
endif()
2424

25-
find_package ( Boost REQUIRED
26-
COMPONENTS
27-
system
28-
unit_test_framework
29-
)
30-
3125
# the Ceres::ceres alias in not getting defined on the config side
32-
find_package ( Ceres CONFIG REQUIRED )
33-
34-
find_package(RAWTOACES CONFIG REQUIRED)
26+
find_package ( Ceres CONFIG REQUIRED )
27+
find_package ( OpenImageIO CONFIG REQUIRED )
28+
find_package ( RAWTOACES CONFIG REQUIRED )
3529

3630
enable_testing()
3731
add_subdirectory(core)

unittest/config_tests/core/CMakeLists.txt

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,7 @@ target_link_libraries(
1212
test_core
1313
PUBLIC
1414
rawtoaces_core
15-
Boost::boost
16-
Boost::unit_test_framework
15+
OpenImageIO::OpenImageIO
1716
)
1817

1918
add_test ( NAME test_core COMMAND test_core )

0 commit comments

Comments
 (0)