-added subprocess.Popen wrapper

-ported to wrapper

Author: ajohns

src/rez/bind/_utils.py

@@ -6,6 +6,7 @@
 from rez.exceptions import RezBindError
 from rez.config import config
 from rez.util import which
+from rez.utils.system import popen
 from rez.utils.logging_ import print_debug
 from pipes import quote
 import subprocess
@@ -117,8 +118,7 @@ def _run_command(args):
     cmd_str = ' '.join(quote(x) for x in args)
     log("running: %s" % cmd_str)
 
-    p = subprocess.Popen(args, stdout=subprocess.PIPE,
-                         stderr=subprocess.PIPE)
+    p = popen(args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     stdout, stderr = p.communicate()
     return stdout, stderr, p.returncode
 

src/rez/developer_package.py

@@ -3,7 +3,7 @@
 from rez.serialise import load_from_file, FileFormat
 from rez.packages_ import create_package
 from rez.exceptions import PackageMetadataError, InvalidPackageError
-from rez.utils.syspath import add_sys_paths
+from rez.utils.system import add_sys_paths
 from rez.utils.sourcecode import SourceCode
 from rez.utils.logging_ import print_info, print_error
 from inspect import isfunction

src/rez/package_help.py

@@ -1,6 +1,7 @@
 from rez.packages_ import iter_packages
 from rez.config import config
 from rez.rex_bindings import VersionBinding
+from rez.utils.system import popen
 from rez.utils.backcompat import convert_old_command_expansions
 from rez.utils.scope import scoped_formatter
 from rez.system import system
@@ -92,7 +93,8 @@ def open(self, section_index=0):
         else:
             if self._verbose:
                 print "running command: %s" % uri
-            subprocess.Popen(uri, shell=True).wait()
+            p = popen(uri, shell=True)
+            p.wait()
 
     def print_info(self, buf=None):
         """Print help sections."""
@@ -112,7 +114,8 @@ def _open_url(cls, url):
             cmd = [config.browser, url]
             if not config.quiet:
                 print "running command: %s" % " ".join(cmd)
-            subprocess.Popen(cmd).communicate()
+            p = popen(cmd)
+            p.communicate()
         else:
             if not config.quiet:
                 print "opening URL in browser: %s" % url

src/rez/package_py_utils.py

@@ -7,7 +7,7 @@
 """
 
 # these imports just forward the symbols into this module's namespace
-from rez.utils.sourcecode import late
+from rez.utils.system import popen
 from rez.exceptions import InvalidPackageError
 
 
@@ -165,7 +165,7 @@ def exec_command(attr, cmd):
     """
     import subprocess
 
-    p = subprocess.Popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+    p = popen(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     out, err = p.communicate()
 
     if p.returncode:
@@ -192,9 +192,8 @@ def exec_python(attr, src, executable="python"):
     if isinstance(src, basestring):
         src = [src]
 
-    p = subprocess.Popen(
-        [executable, "-c", "; ".join(src)],
-        stdout=subprocess.PIPE, stderr=subprocess.PIPE)
+    p = popen([executable, "-c", "; ".join(src)],
+              stdout=subprocess.PIPE, stderr=subprocess.PIPE)
     out, err = p.communicate()
 
     if p.returncode:
@@ -233,8 +232,8 @@ def find_site_python(module_name, paths=None):
 
     py_cmd = 'import {x}; print {x}.__path__'.format(x=module_name)
 
-    p = subprocess.Popen(["python", "-c", py_cmd], stdout=subprocess.PIPE,
-                         stderr=subprocess.PIPE)
+    p = popen(["python", "-c", py_cmd], stdout=subprocess.PIPE,
+               stderr=subprocess.PIPE)
     out, err = p.communicate()
 
     if p.returncode:

src/rez/pip.py

@@ -6,6 +6,7 @@
 from rez.vendor.distlib.util import parse_name_and_version
 from rez.vendor.enum.enum import Enum
 from rez.resolved_context import ResolvedContext
+from rez.system import popen
 from rez.utils.logging_ import print_debug, print_info, print_warning
 from rez.exceptions import BuildError, PackageFamilyNotFoundError, \
     PackageNotFoundError, convert_errors
@@ -97,7 +98,7 @@ def run_pip_command(command_args, pip_version=None, python_version=None):
     command = [pip_exe] + list(command_args)
 
     if context is None:
-        return subprocess.Popen(command)
+        return popen(command)
     else:
         return context.execute_shell(command=command, block=False)
 
@@ -349,7 +350,7 @@ def _cmd(context, command):
     _log("running: %s" % cmd_str)
 
     if context is None:
-        p = subprocess.Popen(command)
+        p = popen(command)
     else:
         p = context.execute_shell(command=command, block=False)
 

src/rez/release_vcs.py

@@ -1,6 +1,7 @@
 from rez.exceptions import ReleaseVCSError
 from rez.packages_ import get_developer_package
 from rez.util import which
+from rez.utils.system import popen
 from rez.utils.logging_ import print_debug
 from rez.utils.filesystem import walk_up_dirs
 import subprocess
@@ -204,9 +205,10 @@ def _cmd(self, *nargs):
         if self.package.config.debug("package_release"):
             print_debug("Running command: %s" % cmd_str)
 
-        p = subprocess.Popen(nargs, stdout=subprocess.PIPE,
-                             stderr=subprocess.PIPE, cwd=self.pkg_root)
+        p = popen(nargs, stdout=subprocess.PIPE, stderr=subprocess.PIPE,
+                  cwd=self.pkg_root)
         out, err = p.communicate()
+
         if p.returncode:
             print_debug("command stdout:")
             print_debug(out)

src/rez/rex.py

@@ -12,6 +12,7 @@
 from rez.exceptions import RexError, RexUndefinedVariableError, RezSystemError
 from rez.util import shlex_join
 from rez.utils import reraise
+from rez.system import popen
 from rez.utils.sourcecode import SourceCode, SourceCodeError
 from rez.utils.data_utils import AttrDictWrapper
 from rez.utils.formatting import expandvars
@@ -612,10 +613,10 @@ def subprocess(self, args, **subproc_kwargs):
             self.target_environ.update(self.manager.environ)
 
         shell_mode = not hasattr(args, '__iter__')
-        return subprocess.Popen(args,
-                                shell=shell_mode,
-                                env=self.target_environ,
-                                **subproc_kwargs)
+        return popen(args,
+                     shell=shell_mode,
+                     env=self.target_environ,
+                     **subproc_kwargs)
 
     def command(self, value):
         if self.passive:

src/rez/serialise.py

@@ -8,7 +8,7 @@
 from rez.utils.filesystem import TempDirs
 from rez.exceptions import ResourceError, InvalidPackageError
 from rez.utils.memcached import memcached
-from rez.utils.syspath import add_sys_paths
+from rez.utils.system import add_sys_paths
 from rez.config import config
 from rez.vendor.enum import Enum
 from rez.vendor import yaml

src/rez/shells.py

@@ -7,7 +7,7 @@
 from rez.exceptions import RezSystemError
 from rez.rex import EscapedString
 from rez.config import config
-from rez.system import system
+from rez.system import system, popen
 import subprocess
 import os.path
 import pipes
@@ -345,7 +345,7 @@ def _create_ex():
         cmd.extend([self.executable, target_file])
 
         try:
-            p = subprocess.Popen(cmd, env=env, **Popen_args)
+            p = popen(cmd, env=env, **Popen_args)
         except Exception as e:
             cmd_str = ' '.join(map(pipes.quote, cmd))
             raise RezSystemError("Error running command:\n%s\n%s"

src/rez/utils/_version.py

@@ -1,7 +1,7 @@
 
 
 # Update this value to version up Rez. Do not place anything else in this file.
-_rez_version = "2.15.0"
+_rez_version = "2.16.0"
 
 try:
     from rez.vendor.version.version import Version