Add ability to change the executable_fullpath setting for the gitbash shell plugin (#1938)

* change to use super() method,
so the inherited method will use GitBash.name(), via cls.name() to access config settings in rez.shells.Shell.find_executable()

Signed-off-by: george.ridal <[email protected]>

* Added test to check find_executable config override works correctly

Signed-off-by: george.ridal <[email protected]>

* removed white space

Signed-off-by: george.ridal <[email protected]>

---------

Signed-off-by: george.ridal <[email protected]>

Author: vanridal

src/rez/tests/test_shells.py

@@ -641,6 +641,18 @@ def _make_alias(ex):
         out, _ = p.communicate()
         self.assertEqual(1, p.returncode)
 
+    @per_available_shell()
+    def test_find_executable_config_override(self, shell):
+        """Test the shell plugin returns correct exec override from settings."""
+        config.override("default_shell", shell)
+        override_attr = "plugins.shell.{}.executable_fullpath".format(shell)
+        cls = type(create_shell(shell))
+        with tempfile.TemporaryDirectory() as td:
+            exe_path = os.path.join(td, cls.executable_name())
+            with open(exe_path, 'w'):
+                config.override(override_attr, exe_path)
+                assert cls.find_executable(cls.executable_name()) == exe_path
+
 
 if __name__ == '__main__':
     unittest.main()

src/rezplugins/shell/gitbash.py

@@ -37,7 +37,7 @@ def executable_name(cls):
 
     @classmethod
     def find_executable(cls, name, check_syspaths=False):
-        exepath = Bash.find_executable(name, check_syspaths=check_syspaths)
+        exepath = super(GitBash, cls).find_executable(name, check_syspaths=check_syspaths)
 
         if exepath and "system32" in exepath.lower():
             print_warning(