cmake module ExternalProject running with extra `make install` command

[arubertoson]

From what I gather when using the cmake module ExternalProject the building and installation is taken care of without any outside input. When using rez-build --install we can utilize the REZ_BUILD_INSTALL variable to query for in the CMakeLists file to help create commands.

When executing rez-build --install it seems that rez wants to perform a make install as well causing a error output:

make[3]: *** No rule to make target `install'.  Stop.
make[2]: *** [boost/src/boost-stamp/boost-install] Error 2
make[1]: *** [CMakeFiles/boost.dir/all] Error 2
make: *** [all] Error 2
10:15:06 ERROR    BuildError: The cmake build system failed.

I guess it makes sense that we would want to have make install if we were performing something else outside of the ExteralProject but when we are just using that operation everything is already taken care of as I can comment out the code block performing the make install command from the CMakeBuildSystem.build function in cmake.py without causing any issues.

        if not retcode and install and "install" not in cmd:
            cmd.append("install")

            # execute make install within the build env
            _pr("\nExecuting: %s" % ' '.join(cmd))
            retcode, _, _ = context.execute_shell(command=cmd,
                                                  block=True,
                                                  cwd=build_path,
                                                  actions_callback=callback)

Should there be some way to specify that ExternalProject should handle the execution or have I missed something that already specifies that?

[nerdvegas]

Hi, do you mean that ExternalProject is already doing the installation in this case? Thanks, A

…

On Thu, Feb 1, 2018 at 1:05 AM, Marcus Albertsson ***@***.***> wrote: From what I gather when using the cmake module ExternalProject the building and installation is taken care of without any outside input. When using rez-build --install we can utilize the REZ_BUILD_INSTALL variable to query for in the CMakeLists file to help create commands. When executing rez-build --install it seems that rez wants to perform a make install as well causing a error output: make[3]: *** No rule to make target `install'. Stop.make[2]: *** [boost/src/boost-stamp/boost-install] Error 2make[1]: *** [CMakeFiles/boost.dir/all] Error 2make: *** [all] Error 210:15:06 ERROR BuildError: The cmake build system failed. I guess it makes sense that we would want to have make install if we were performing something else outside of the ExteralProject but when we are just using that operation everything is already taken care of as I can comment out the code block performing the make install command from the CMakeBuildSystem.build function in cmake.py without causing any issues. if not retcode and install and "install" not in cmd: cmd.append("install") # execute make install within the build env _pr("\nExecuting: %s" % ' '.join(cmd)) retcode, _, _ = context.execute_shell(command=cmd, block=True, cwd=build_path, actions_callback=callback) Should there be some way to specify that ExternalProject should handle the execution or have I missed something that already specifies that? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#476>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjqSnbahpSoNc9xCEW3lOsoy5oD5m4Oks5tQHM2gaJpZM4R0BTs> .

[nerdvegas]

Sorry meant to add: * Can you include your cmakelists source (or at least the ExternalProject part)? * If ExternalProject does actually do the installation, then what does `rez-build` do (ie no install specified)? A

…

On Thu, Feb 1, 2018 at 8:35 AM, Allan Johns ***@***.***> wrote: Hi, do you mean that ExternalProject is already doing the installation in this case? Thanks, A On Thu, Feb 1, 2018 at 1:05 AM, Marcus Albertsson < ***@***.***> wrote: > From what I gather when using the cmake module ExternalProject the > building and installation is taken care of without any outside input. When > using rez-build --install we can utilize the REZ_BUILD_INSTALL variable > to query for in the CMakeLists file to help create commands. > > When executing rez-build --install it seems that rez wants to perform a make > install as well causing a error output: > > make[3]: *** No rule to make target `install'. Stop.make[2]: *** [boost/src/boost-stamp/boost-install] Error 2make[1]: *** [CMakeFiles/boost.dir/all] Error 2make: *** [all] Error 210:15:06 ERROR BuildError: The cmake build system failed. > > I guess it makes sense that we would want to have make install if we > were performing something else outside of the ExteralProject but when we > are just using that operation everything is already taken care of as I can > comment out the code block performing the make install command from the > CMakeBuildSystem.build function in cmake.py without causing any issues. > > if not retcode and install and "install" not in cmd: > cmd.append("install") > > # execute make install within the build env > _pr("\nExecuting: %s" % ' '.join(cmd)) > retcode, _, _ = context.execute_shell(command=cmd, > block=True, > cwd=build_path, > actions_callback=callback) > > Should there be some way to specify that ExternalProject should handle > the execution or have I missed something that already specifies that? > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <#476>, or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABjqSnbahpSoNc9xCEW3lOsoy5oD5m4Oks5tQHM2gaJpZM4R0BTs> > . >

[arubertoson]

I was following one of the examples that I found in the repositories directory:

if(${REZ_BUILD_INSTALL})
    set(install_cmd ./b2 install ${b2_args})
else()
    set(install_cmd "")
endif()

ExternalProject_add(
    boost
    URL ${url_boost}
    PREFIX boost
    UPDATE_COMMAND ""
    CONFIGURE_COMMAND ./bootstrap.sh
    INSTALL_COMMAND "${install_cmd}"
    BUILD_IN_SOURCE 1
    BUILD_COMMAND ./b2 ${b2_args}
)

This just means that if you just do a rez-build it will only build the source without actually installing any files as install command is empty. If you specify --installl however you create an invalid return code in the cmake.py that raises an error as shown above since it tries to run a make install somewhere where it's invalid. I believe that error makes the rez-build --install exit early since neither package.py nor build.rxt will be copied to the package directory afterwards.

I lack the skillset to come up with a better cmake solution as I'm not experienced with it but commenting out the code block from cmake.py I provided in my first comment removes the issue. This will most likely create problems with cmake files not utilizing the ExternalProject module.

Hope that clarifies the issue a bit.

[nerdvegas]

Hmm ok, I wonder if this is related to a recent release which contains a cmake-related change. I would have thought though that `ExternalProject_add` having an INSTALL_COMMAND specified would create an install target.

…

On Thu, Feb 1, 2018 at 8:48 AM, Marcus Albertsson ***@***.***> wrote: I was following one of the examples that I found in the repositories directory: if(${REZ_BUILD_INSTALL}) set(install_cmd ./b2 install ${b2_args})else() set(install_cmd "")endif() ExternalProject_add( boost URL ${url_boost} PREFIX boost UPDATE_COMMAND "" CONFIGURE_COMMAND ./bootstrap.sh INSTALL_COMMAND "${install_cmd}" BUILD_IN_SOURCE 1 BUILD_COMMAND ./b2 ${b2_args} ) This just means that if you just do a rez-build it will only build the source without actually installing any files as install command is empty. If you specify --installl however you create an invalid return code in the cmake.py that raises an error as shown above since it tries to run a make install somewhere where it's invalid. I believe that error makes the rez-build --install exit early since neither package.py nor build.rxt will be copied to the package directory afterwards. I lack the skillset to come up with a better cmake solution as I'm not experienced with it but commenting out the code block from cmake.py I provided in my first comment removes the issue. This will most likely create problems with cmake files not utilizing the ExternalProject module. Hope that clarifies the issue a bit. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#476 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjqSpoft4bx2Zus7lm7RhrOMMZkJX5Uks5tQN-igaJpZM4R0BTs> .

[smaragden]

This is because there is no install target in the body of the cmake file.
We often install something in the body of the cmake file like cmake/boost.cmake.
That creates a install target and all is good.

But if you want to get past the error you can add some meaningless install target in the body like:
install(CODE "message(STATUS Running Phony install)")
this will make sure there is a install target and all is good.

[nerdvegas]

Ok this makes sense. The recent rez update actually removed a default install target that it used to create - which I think was actually conflicting with actual install target when using cmake-3* (it was actually creating `install` as a custom target though, so I can see why this may have caused problems). I'll test out this `install(CODE ...)` approach and see if that fixes both issues. In any case Marcus I think Fredrik is probably right and this will fix the issue, let us know. Cheers A

…

On Thu, Feb 1, 2018 at 9:32 AM, Fredrik Brännbacka ***@***.*** > wrote: This is because there is no install target in the body of the cmake file. We often install something in the body of the cmake file like cmake/boost.cmake. That creates a install target and all is good. But if you want to get past the error you can add some meaningless install target in the body like: install(CODE "message(STATUS Running Phony install)") this will make sure there is a install target and all is good. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#476 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjqSiJzQzddkY5XckebiEDTAj9_xp8Rks5tQOn8gaJpZM4R0BTs> .

[smaragden]

This should probably be handled more gracefully by rez.
Here's a small example of the issue:

CMakeLists.txt

include(RezBuild)
include(ExternalProject)

ExternalProject_Add(
	test
	DOWNLOAD_COMMAND ""
	CONFIGURE_COMMAND echo "CONFIGURE" >> testfile.txt
	ALWAYS 1
	BUILD_COMMAND echo "BUILD" >> testfile.txt
	INSTALL_COMMAND echo "INSTALL" >> testfile.txt
)

# Comment out the following line to see the issue
install(CODE "message(STATUS Running Phony install)")```

[arubertoson]

Gotcha, it worked as expected.

I don't know what your plan for this issue is, but I'm happy. Might want to include the solution in the cmake files in the repo directory? ... Depending how you move forward that is

[nerdvegas]

Please note.. I think this would also be an acceptable fix, and perhaps less clunky. Simply put in package.py:

build_command = "cmake {root}/CMakeLists.txt"

Lack of {install} means the install target is never specified.

[JasonGilholme]

Hey @nerdvegas,

I just came across this bug when running my build scripts on a new system. I've tried the build_command in the package.py option and it's then unable to find the rez cmake files. As well as that, it dumped a bunch of cmake files in the root dir of the package.

FYI - the dummy install() method worked for me though so I'll run with that for the moment.

rez-2.22.0
cmake-3.11.2
python-2.7.15

Thanks mate
Jase

[nerdvegas]

Hey @JasonGilholme,

I'll look into this - custom build command should be getting run in a build subdir so not sure what's going on here. However I do see why the rez cmake files would not be visible, as only the cmake build system adds those to cmake's module searchpath. An easy fix may be to simply do this in all cases.