Skip to content

Conversation

@zjb0807
Copy link
Member

@zjb0807 zjb0807 commented Sep 29, 2025

https://github.com/AcalaNetwork/bodhi.js/blob/6d4f8232c33cb03eff0dad2d89f0ef3d6412cac3/packages/eth-providers/src/base-provider.ts#L963-L966

Since ExtrinsicV5 has upgraded UncheckedExtrinsic { preamble: Bare, function: <wasm:stripped> }, if the type is Bare, it returns None.

if unchecked_extrinsic.is_bare() {
// Bare extrinsics have no inclusion fee.
FeeDetails {
inclusion_fee: None,
tip,
}

api.call.transactionPaymentApi.queryFeeDetails needs a signature to query fee details.
Therefore, TransactionPaymentCallApi is added to query fee details.

@zjb0807 zjb0807 requested a review from xlc September 29, 2025 14:33
@codecov
Copy link

codecov bot commented Sep 29, 2025

Codecov Report

❌ Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.05%. Comparing base (2c877e1) to head (02423fe).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
modules/transaction-payment/src/lib.rs 83.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2923      +/-   ##
==========================================
+ Coverage   61.92%   62.05%   +0.12%     
==========================================
  Files          69       69              
  Lines        9469     9482      +13     
==========================================
+ Hits         5864     5884      +20     
+ Misses       3605     3598       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@zjb0807 zjb0807 merged commit 20c819c into master Sep 29, 2025
7 checks passed
@zjb0807 zjb0807 deleted the add-TransactionPaymentCallApi branch September 29, 2025 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants