-
Notifications
You must be signed in to change notification settings - Fork 718
Add benchmarks #2947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add benchmarks #2947
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found multiple instances of a typo where Liner is used instead of Linear in benchmarking definitions across several modules. Also noted that pallet_xcm benchmarks are commented out in the runtime configuration, which contradicts the PR description implying they should be added.
Suggestions that couldn't be attached to a specific line
modules/evm/src/benchmarking.rs:324
Typo: Liner should be Linear.
modules/homa/src/benchmarking.rs:37
Typo: Liner should be Linear.
modules/homa/src/benchmarking.rs:139
Typo: Liner should be Linear.
modules/homa/src/benchmarking.rs:228
Typo: Liner should be Linear.
modules/incentives/src/benchmarking.rs:123
Typo: Liner should be Linear.
runtime/mandala/src/lib.rs:2269
The pallet_xcm benchmarks are commented out here and in the dispatch_benchmark implementation (lines 2650-2711 in the diff context), but the PR description mentions adding them. Please confirm if this is intentional.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #2947 +/- ##
==========================================
- Coverage 48.43% 47.86% -0.57%
==========================================
Files 69 83 +14
Lines 9454 9566 +112
==========================================
Hits 4579 4579
- Misses 4875 4987 +112 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
The PR successfully migrates benchmarks to Review Suggestionsruntime/mandala/src/benchmark_common.rs:1105 The use of modules/evm/src/tests.rs:281, 355, 631 Storage usage values have increased significantly (approx +9900) across multiple tests. Verify that this increase is expected and intentional (e.g., due to dependency updates or configuration changes). modules/dex/src/benchmarking.rs:42 The |
nutsfinance/stable-asset#60
Closes: #2793
Closes: #2766