Skip to content

Commit 42019a1

Browse files
author
Piotr Zajac
committed
Remove AutoFixture.Xunit2 dependency from CustomizeAttributeComparer
1 parent bf51a7e commit 42019a1

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

src/Objectivity.AutoFixture.XUnit2.Core.Tests/Comparers/CustomizeAttributeComparerTests.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
[Trait("Category", "Comparers")]
1313
public class CustomizeAttributeComparerTests
1414
{
15-
private static readonly CustomizeAttributeComparer Comparer = new();
15+
private static readonly CustomizeAttributeComparer<FrozenAttribute> Comparer = new();
1616
private static readonly CustomizeWithAttribute CustomizeAttribute = new(typeof(DoNotThrowOnRecursionCustomization));
1717
private static readonly FrozenAttribute FrozenAttribute = new();
1818

src/Objectivity.AutoFixture.XUnit2.Core/Attributes/AutoDataAdapterAttribute.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ private void CustomizeFixture(ParameterInfo p)
4646
{
4747
var customizeAttributes = p.GetCustomAttributes()
4848
.OfType<IParameterCustomizationSource>()
49-
.OrderBy(x => x, new CustomizeAttributeComparer());
49+
.OrderBy(x => x, new CustomizeAttributeComparer<FrozenAttribute>());
5050

5151
foreach (var ca in customizeAttributes)
5252
{

src/Objectivity.AutoFixture.XUnit2.Core/Comparers/CustomizeAttributeComparer.cs

+4-7
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,14 @@
33
using System.Collections.Generic;
44

55
using global::AutoFixture;
6-
using global::AutoFixture.Xunit2;
76

8-
/// <summary>
9-
/// Direct copy from the AutoFixture source code as the original class is internal.
10-
/// </summary>
11-
internal class CustomizeAttributeComparer : Comparer<IParameterCustomizationSource>
7+
internal class CustomizeAttributeComparer<T> : Comparer<IParameterCustomizationSource>
8+
where T : IParameterCustomizationSource
129
{
1310
public override int Compare(IParameterCustomizationSource x, IParameterCustomizationSource y)
1411
{
15-
var isXFrozen = x is FrozenAttribute;
16-
var isYFrozen = y is FrozenAttribute;
12+
var isXFrozen = x is T;
13+
var isYFrozen = y is T;
1714

1815
if (isXFrozen && !isYFrozen)
1916
{

0 commit comments

Comments
 (0)