-
Notifications
You must be signed in to change notification settings - Fork 47
Open
Labels
good first issueGood for newcomersGood for newcomers
Description
Summary
The JSON-RPC communicator currently does not implement any retry mechanism and so a first failing request makes the whole script/test crash.
https://github.com/Ackee-Blockchain/wake/blob/main/wake/development/json_rpc/communicator.py
Basic Example
It should be easy to add a configurable retry parameter with a corresponding setting (config.general.json_rpc_retry for example).
A different retry count for each chain is probably unnecessary.
Drawbacks
There are different communication protocols (IPC, WS, HTTP), and exceptions should be handled for all of them. It might be tricky to select the right exceptions to catch (and possibly status codes).
Unresolved questions
No response
Implementation PR
No response
Reference Issues
No response
innominatissimus
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers