🐛 [BUG] - Graph nodes contain duplicate slashes in paths (`//` instead of `/`)

[PFAhard]

Description

Contracts compilation on windows was failing on compilation_unit.py#L62

Occurs when running VS code extension on c4 contest

I'm not very happy with the use (and existence) of Python, so I don't want to investigate this in detail.
But a quick debug shows that some nodes in self.__unit_graph.nodes contain // instead of /.
The same is true for the function parameter source_unit_name in some calls.

Quick fixed in local fork this way:

    def source_unit_name_to_path(self, source_unit_name: str) -> Path:
        nx.relabel_nodes(self.__unit_graph, {n: n.replace("//", "/") for n in self.__unit_graph if "//" in n}, copy=False)
        return self.__unit_graph.nodes[source_unit_name.replace("//", "/")]["path"]

Works OK.
But proper fix would be great.

Reproduction steps

Clone the linked repo and try using the VS Code extension. I'm not sure if this will always reproduce the issue — it may require specific conditions — but the lack of path normalization is evident.

Reproduction URL

No response

Screenshots

Logs

OS

Windows

[michprev]

Hey @PFAhard,
thanks for reporting.

This is an issue on multiple layers:

• remappings.txt contains incorrect/tricky remappings
  • @solady=lib/solady/src/ should be replaced with @solady/=lib/solady/src/
  • remappings work on a simple replace principle, so @solady/utils/Initializable.sol would be replaced as lib/solady/src//utils/Initializable.sol, thus resulting in the double slashes
• Solidity (Wake) extension incorrectly uses remappings.txt as the best source of truth
  • we should run forge remappings instead
  • this will be fixed
• relative import resolving in Wake has a subtle bug when it doesn't resolve 100% the same as Solidity compiler
  • this leads to the inconsistency lib/solady/src/utils/FixedPointMathLib.sol vs lib/solady//src/utils/FixedPointMathLib.sol and the crash
  • this will also be fixed

As a temporary workaround, you can change the remappings in .vscode/settings.json (or in VS Code UI) that either both parts (before and after =) always have or always don't have trailing slashes.