Fix tests?

Author: ChronosMasterOfAllTime

cmd/meta/getstarted_test.go

@@ -162,7 +162,7 @@ func TestGetStartedCommand_UnknownShell(t *testing.T) {
 	output := buf.String()
 
 	// Should still provide generic instructions
-	assert.False(t, !strings.Contains(output, "eval") || !strings.Contains(output, "init"), "Expected generic init instructions")
+	assert.True(t, strings.Contains(output, "eval") || strings.Contains(output, "init"), "Expected generic init instructions")
 }
 
 func TestGetStartedHelp(t *testing.T) {

internal/sbom/hooks.go

@@ -43,6 +43,12 @@ func DefaultHookConfig() HookConfig {
 
 // NewHookManager creates a new hook manager
 func NewHookManager(repoPath string) (*HookManager, error) {
+	return NewHookManagerWithGoenv(repoPath, "")
+}
+
+// NewHookManagerWithGoenv creates a new hook manager with a specified goenv path
+// If goenvPath is empty, it will attempt to locate it automatically
+func NewHookManagerWithGoenv(repoPath, goenvPath string) (*HookManager, error) {
 	if repoPath == "" {
 		cwd, err := os.Getwd()
 		if err != nil {
@@ -62,10 +68,12 @@ func NewHookManager(repoPath string) (*HookManager, error) {
 		return nil, fmt.Errorf("git hooks directory not found: %w", err)
 	}
 
-	// Find goenv executable
-	goenvPath, err := findGoenvExecutable()
-	if err != nil {
-		return nil, fmt.Errorf("failed to locate goenv: %w", err)
+	// Find goenv executable if not provided
+	if goenvPath == "" {
+		goenvPath, err = findGoenvExecutable()
+		if err != nil {
+			return nil, fmt.Errorf("failed to locate goenv: %w", err)
+		}
 	}
 
 	return &HookManager{

internal/sbom/hooks_test.go

@@ -41,7 +41,8 @@ func TestNewHookManager(t *testing.T) {
 		t.Run(tt.name, func(t *testing.T) {
 			dir := tt.setup(t)
 
-			manager, err := NewHookManager(dir)
+			// Use mock goenv path for testing
+			manager, err := NewHookManagerWithGoenv(dir, "/usr/bin/goenv")
 			if (err != nil) != tt.wantErr {
 				t.Errorf("NewHookManager() error = %v, wantErr %v", err, tt.wantErr)
 				return
@@ -75,7 +76,7 @@ func TestHookManager_InstallHook(t *testing.T) {
 		t.Fatalf("failed to init git repo: %v", err)
 	}
 
-	manager, err := NewHookManager(repoDir)
+	manager, err := NewHookManagerWithGoenv(repoDir, "/usr/bin/goenv")
 	if err != nil {
 		t.Fatalf("NewHookManager() error = %v", err)
 	}
@@ -189,7 +190,7 @@ func TestHookManager_UninstallHook(t *testing.T) {
 		t.Fatalf("failed to init git repo: %v", err)
 	}
 
-	manager, err := NewHookManager(repoDir)
+	manager, err := NewHookManagerWithGoenv(repoDir, "/usr/bin/goenv")
 	if err != nil {
 		t.Fatalf("NewHookManager() error = %v", err)
 	}
@@ -256,7 +257,7 @@ func TestHookManager_IsHookInstalled(t *testing.T) {
 		t.Fatalf("failed to init git repo: %v", err)
 	}
 
-	manager, err := NewHookManager(repoDir)
+	manager, err := NewHookManagerWithGoenv(repoDir, "/usr/bin/goenv")
 	if err != nil {
 		t.Fatalf("NewHookManager() error = %v", err)
 	}
@@ -323,7 +324,7 @@ func TestHookManager_GetHookStatus(t *testing.T) {
 		t.Fatalf("failed to init git repo: %v", err)
 	}
 
-	manager, err := NewHookManager(repoDir)
+	manager, err := NewHookManagerWithGoenv(repoDir, "/usr/bin/goenv")
 	if err != nil {
 		t.Fatalf("NewHookManager() error = %v", err)
 	}
@@ -462,7 +463,7 @@ func TestGenerateHookScript(t *testing.T) {
 		t.Fatalf("failed to init git repo: %v", err)
 	}
 
-	manager, err := NewHookManager(repoDir)
+	manager, err := NewHookManagerWithGoenv(repoDir, "/usr/bin/goenv")
 	if err != nil {
 		t.Fatalf("NewHookManager() error = %v", err)
 	}