Skip to content

Commit b329860

Browse files
fix: Attempting to fix flaky shutdown test (serverpod#3734)
1 parent 0f1db3a commit b329860

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

tests/serverpod_test_server/test_integration/shutdown_test.dart

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,14 @@
11
// ignore_for_file: dead_code
22

33
@Timeout(Duration(minutes: 1))
4-
@Skip('This is skipped due to flaky tests, issue to resolve this is tracked in '
5-
'https://github.com/serverpod/serverpod/issues/3431')
4+
// Note, this test shall run non-concurrently,
5+
// which means the test tag 'integration' is not used.
66

77
import 'dart:async';
88
import 'dart:convert';
99
import 'dart:io';
1010

1111
import 'package:http/http.dart';
12-
import 'package:serverpod_test/serverpod_test.dart';
1312
import 'package:test/test.dart';
1413

1514
void main() {
@@ -46,9 +45,7 @@ void main() {
4645

4746
var exitCode = await processOutput.process.exitCode;
4847
expect(exitCode, 0);
49-
},
50-
timeout: const Timeout(Duration(seconds: 60)),
51-
tags: [defaultIntegrationTestTag]);
48+
}, timeout: const Timeout(Duration(seconds: 60)));
5249

5350
group('Given a running serverpod server', () {
5451
test(
@@ -221,7 +218,7 @@ void main() {
221218
);
222219
expect(exitCode, 130);
223220
}, skip: 'Dart HTTP server does not support this graceful shutdown');
224-
}, tags: [defaultIntegrationTestTag]);
221+
});
225222
}
226223

227224
typedef ProcessOutput = ({

0 commit comments

Comments
 (0)