Skip to content

Commit bd11dba

Browse files
committed
AG-41223 fix pnpm install
Squashed commit of the following: commit a903251 Author: Slava Leleka <[email protected]> Date: Thu Apr 17 17:35:57 2025 -0400 fix comment commit 61f2d96 Author: Slava Leleka <[email protected]> Date: Thu Apr 17 17:34:49 2025 -0400 filter out ignore-scripts from bamboo_varsPnpm commit 82bd8a0 Author: Slava Leleka <[email protected]> Date: Thu Apr 17 16:52:19 2025 -0400 full pnpm install for tests commit 0fdaa27 Author: Slava Leleka <[email protected]> Date: Thu Apr 17 16:42:00 2025 -0400 specify NODE_VERSION commit c66aa56 Author: Slava Leleka <[email protected]> Date: Thu Apr 17 16:40:57 2025 -0400 fix pnpm install in specs
1 parent 61825cc commit bd11dba

File tree

4 files changed

+14
-5
lines changed

4 files changed

+14
-5
lines changed

.github/workflows/release.yml

+4-2
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
name: Github Release
22

33
env:
4-
NODE_VERSION: 22
4+
NODE_VERSION: 22.14.0
55
PNPM_VERSION: 10.7.1
6+
# Forks do not have access to our vars
7+
VARS_PNPM: ${{ vars.VARS_PNPM || '--silent --ignore-scripts' }}
68

79
# Workflow need write access to the repository to create a GitHub release
810
permissions:
@@ -49,7 +51,7 @@ jobs:
4951
cache: pnpm
5052

5153
- name: Install dependencies
52-
run: pnpm install
54+
run: pnpm install ${{ env.VARS_PNPM }}
5355

5456
- name: Run ESLint
5557
run: pnpm lint

.github/workflows/test.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name: Test Scriptlets
22

33
env:
4-
NODE_VERSION: 22
4+
NODE_VERSION: 22.14.0
55
PNPM_VERSION: 10.7.1
66

77
on:

bamboo-specs/build.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ Build:
4040
# Set cache directory
4141
pnpm config set store-dir ${bamboo.cachePnpm}
4242
43-
pnpm install
43+
pnpm install ${bamboo.varsPnpm}
4444
4545
pnpm build
4646

bamboo-specs/test.yaml

+8-1
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,14 @@ Build:
3535
3636
ls -laht
3737
38-
pnpm install
38+
# Exclude '--ignore-scripts' from pnpm arguments
39+
# since it prevents postinstall scripts from running
40+
# so Chrome is not installed which is crucial for tests
41+
originalPnpmArgs="$bamboo_varsPnpm"
42+
modifiedPnpmArgs=$(echo "$originalPnpmArgs" | sed 's/--ignore-scripts//g')
43+
44+
# Install common dependencies
45+
pnpm install ${modifiedPnpmArgs}
3946
4047
# build docs to lint them later
4148
# check compatibility table updates and build it and build wiki docs

0 commit comments

Comments
 (0)