Skip to content

Commit 31e389f

Browse files
gcatanesegcatanese
authored
Initialise List/Set/Map as null (#1461)
* Initialise List/Set/Map as null * Revert unwanted changes (StoredPaymentMethod) * Remove new Donation type from patch
1 parent 2f6003e commit 31e389f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

49 files changed

+103
-117
lines changed

‎src/main/java/com/adyen/model/checkout/Amounts.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class Amounts {
4040
private String currency;
4141

4242
public static final String JSON_PROPERTY_VALUES = "values";
43-
private List<Long> values = new ArrayList<>();
43+
private List<Long> values;
4444

4545
public Amounts() {
4646
}

‎src/main/java/com/adyen/model/checkout/BalanceCheckRequest.java

+5-5
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ public class BalanceCheckRequest {
101101
private Amount additionalAmount;
102102

103103
public static final String JSON_PROPERTY_ADDITIONAL_DATA = "additionalData";
104-
private Map<String, String> additionalData = new HashMap<>();
104+
private Map<String, String> additionalData;
105105

106106
public static final String JSON_PROPERTY_AMOUNT = "amount";
107107
private Amount amount;
@@ -140,7 +140,7 @@ public class BalanceCheckRequest {
140140
private Installments installments;
141141

142142
public static final String JSON_PROPERTY_LOCALIZED_SHOPPER_STATEMENT = "localizedShopperStatement";
143-
private Map<String, String> localizedShopperStatement = new HashMap<>();
143+
private Map<String, String> localizedShopperStatement;
144144

145145
public static final String JSON_PROPERTY_MCC = "mcc";
146146
private String mcc;
@@ -155,13 +155,13 @@ public class BalanceCheckRequest {
155155
private MerchantRiskIndicator merchantRiskIndicator;
156156

157157
public static final String JSON_PROPERTY_METADATA = "metadata";
158-
private Map<String, String> metadata = new HashMap<>();
158+
private Map<String, String> metadata;
159159

160160
public static final String JSON_PROPERTY_ORDER_REFERENCE = "orderReference";
161161
private String orderReference;
162162

163163
public static final String JSON_PROPERTY_PAYMENT_METHOD = "paymentMethod";
164-
private Map<String, String> paymentMethod = new HashMap<>();
164+
private Map<String, String> paymentMethod;
165165

166166
public static final String JSON_PROPERTY_RECURRING = "recurring";
167167
private Recurring recurring;
@@ -282,7 +282,7 @@ public static ShopperInteractionEnum fromValue(String value) {
282282
private String socialSecurityNumber;
283283

284284
public static final String JSON_PROPERTY_SPLITS = "splits";
285-
private List<Split> splits = new ArrayList<>();
285+
private List<Split> splits;
286286

287287
public static final String JSON_PROPERTY_STORE = "store";
288288
private String store;

‎src/main/java/com/adyen/model/checkout/BalanceCheckResponse.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444

4545
public class BalanceCheckResponse {
4646
public static final String JSON_PROPERTY_ADDITIONAL_DATA = "additionalData";
47-
private Map<String, String> additionalData = new HashMap<>();
47+
private Map<String, String> additionalData;
4848

4949
public static final String JSON_PROPERTY_BALANCE = "balance";
5050
private Amount balance;

‎src/main/java/com/adyen/model/checkout/CardDetailsRequest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public class CardDetailsRequest {
5252
private String merchantAccount;
5353

5454
public static final String JSON_PROPERTY_SUPPORTED_BRANDS = "supportedBrands";
55-
private List<String> supportedBrands = new ArrayList<>();
55+
private List<String> supportedBrands;
5656

5757
public CardDetailsRequest() {
5858
}

‎src/main/java/com/adyen/model/checkout/CardDetailsResponse.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
public class CardDetailsResponse {
4242
public static final String JSON_PROPERTY_BRANDS = "brands";
43-
private List<CardBrandDetails> brands = new ArrayList<>();
43+
private List<CardBrandDetails> brands;
4444

4545
public static final String JSON_PROPERTY_FUNDING_SOURCE = "fundingSource";
4646
private String fundingSource;

‎src/main/java/com/adyen/model/checkout/CheckoutNativeRedirectAction.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@
4141

4242
public class CheckoutNativeRedirectAction {
4343
public static final String JSON_PROPERTY_DATA = "data";
44-
private Map<String, String> data = new HashMap<>();
44+
private Map<String, String> data;
4545

4646
public static final String JSON_PROPERTY_METHOD = "method";
4747
private String method;

‎src/main/java/com/adyen/model/checkout/CheckoutRedirectAction.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
public class CheckoutRedirectAction {
4242
public static final String JSON_PROPERTY_DATA = "data";
43-
private Map<String, String> data = new HashMap<>();
43+
private Map<String, String> data;
4444

4545
public static final String JSON_PROPERTY_METHOD = "method";
4646
private String method;

‎src/main/java/com/adyen/model/checkout/CheckoutSDKAction.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ public class CheckoutSDKAction {
4646
private String paymentMethodType;
4747

4848
public static final String JSON_PROPERTY_SDK_DATA = "sdkData";
49-
private Map<String, String> sdkData = new HashMap<>();
49+
private Map<String, String> sdkData;
5050

5151
/**
5252
* The type of the action.

‎src/main/java/com/adyen/model/checkout/CheckoutSessionInstallmentOption.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,13 @@ public static PlansEnum fromValue(String value) {
8989
}
9090

9191
public static final String JSON_PROPERTY_PLANS = "plans";
92-
private List<PlansEnum> plans = new ArrayList<>();
92+
private List<PlansEnum> plans;
9393

9494
public static final String JSON_PROPERTY_PRESELECTED_VALUE = "preselectedValue";
9595
private Integer preselectedValue;
9696

9797
public static final String JSON_PROPERTY_VALUES = "values";
98-
private List<Integer> values = new ArrayList<>();
98+
private List<Integer> values;
9999

100100
public CheckoutSessionInstallmentOption() {
101101
}

‎src/main/java/com/adyen/model/checkout/CreateCheckoutSessionRequest.java

+7-7
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,10 @@ public class CreateCheckoutSessionRequest {
124124
private Amount additionalAmount;
125125

126126
public static final String JSON_PROPERTY_ADDITIONAL_DATA = "additionalData";
127-
private Map<String, String> additionalData = new HashMap<>();
127+
private Map<String, String> additionalData;
128128

129129
public static final String JSON_PROPERTY_ALLOWED_PAYMENT_METHODS = "allowedPaymentMethods";
130-
private List<String> allowedPaymentMethods = new ArrayList<>();
130+
private List<String> allowedPaymentMethods;
131131

132132
public static final String JSON_PROPERTY_AMOUNT = "amount";
133133
private Amount amount;
@@ -142,7 +142,7 @@ public class CreateCheckoutSessionRequest {
142142
private BillingAddress billingAddress;
143143

144144
public static final String JSON_PROPERTY_BLOCKED_PAYMENT_METHODS = "blockedPaymentMethods";
145-
private List<String> blockedPaymentMethods = new ArrayList<>();
145+
private List<String> blockedPaymentMethods;
146146

147147
public static final String JSON_PROPERTY_CAPTURE_DELAY_HOURS = "captureDelayHours";
148148
private Integer captureDelayHours;
@@ -221,10 +221,10 @@ public static ChannelEnum fromValue(String value) {
221221
private FundRecipient fundRecipient;
222222

223223
public static final String JSON_PROPERTY_INSTALLMENT_OPTIONS = "installmentOptions";
224-
private Map<String, CheckoutSessionInstallmentOption> installmentOptions = new HashMap<>();
224+
private Map<String, CheckoutSessionInstallmentOption> installmentOptions;
225225

226226
public static final String JSON_PROPERTY_LINE_ITEMS = "lineItems";
227-
private List<LineItem> lineItems = new ArrayList<>();
227+
private List<LineItem> lineItems;
228228

229229
public static final String JSON_PROPERTY_MANDATE = "mandate";
230230
private Mandate mandate;
@@ -239,7 +239,7 @@ public static ChannelEnum fromValue(String value) {
239239
private String merchantOrderReference;
240240

241241
public static final String JSON_PROPERTY_METADATA = "metadata";
242-
private Map<String, String> metadata = new HashMap<>();
242+
private Map<String, String> metadata;
243243

244244
/**
245245
* Indicates the type of front end integration. Possible values: * **embedded** (default): Drop-in or Components integration * **hosted**: Hosted Checkout integration
@@ -419,7 +419,7 @@ public static ShopperInteractionEnum fromValue(String value) {
419419
private Boolean splitCardFundingSources = false;
420420

421421
public static final String JSON_PROPERTY_SPLITS = "splits";
422-
private List<Split> splits = new ArrayList<>();
422+
private List<Split> splits;
423423

424424
public static final String JSON_PROPERTY_STORE = "store";
425425
private String store;

‎src/main/java/com/adyen/model/checkout/CreateCheckoutSessionResponse.java

+7-7
Original file line numberDiff line numberDiff line change
@@ -126,10 +126,10 @@ public class CreateCheckoutSessionResponse {
126126
private Amount additionalAmount;
127127

128128
public static final String JSON_PROPERTY_ADDITIONAL_DATA = "additionalData";
129-
private Map<String, String> additionalData = new HashMap<>();
129+
private Map<String, String> additionalData;
130130

131131
public static final String JSON_PROPERTY_ALLOWED_PAYMENT_METHODS = "allowedPaymentMethods";
132-
private List<String> allowedPaymentMethods = new ArrayList<>();
132+
private List<String> allowedPaymentMethods;
133133

134134
public static final String JSON_PROPERTY_AMOUNT = "amount";
135135
private Amount amount;
@@ -144,7 +144,7 @@ public class CreateCheckoutSessionResponse {
144144
private BillingAddress billingAddress;
145145

146146
public static final String JSON_PROPERTY_BLOCKED_PAYMENT_METHODS = "blockedPaymentMethods";
147-
private List<String> blockedPaymentMethods = new ArrayList<>();
147+
private List<String> blockedPaymentMethods;
148148

149149
public static final String JSON_PROPERTY_CAPTURE_DELAY_HOURS = "captureDelayHours";
150150
private Integer captureDelayHours;
@@ -226,10 +226,10 @@ public static ChannelEnum fromValue(String value) {
226226
private String id;
227227

228228
public static final String JSON_PROPERTY_INSTALLMENT_OPTIONS = "installmentOptions";
229-
private Map<String, CheckoutSessionInstallmentOption> installmentOptions = new HashMap<>();
229+
private Map<String, CheckoutSessionInstallmentOption> installmentOptions;
230230

231231
public static final String JSON_PROPERTY_LINE_ITEMS = "lineItems";
232-
private List<LineItem> lineItems = new ArrayList<>();
232+
private List<LineItem> lineItems;
233233

234234
public static final String JSON_PROPERTY_MANDATE = "mandate";
235235
private Mandate mandate;
@@ -244,7 +244,7 @@ public static ChannelEnum fromValue(String value) {
244244
private String merchantOrderReference;
245245

246246
public static final String JSON_PROPERTY_METADATA = "metadata";
247-
private Map<String, String> metadata = new HashMap<>();
247+
private Map<String, String> metadata;
248248

249249
/**
250250
* Indicates the type of front end integration. Possible values: * **embedded** (default): Drop-in or Components integration * **hosted**: Hosted Checkout integration
@@ -427,7 +427,7 @@ public static ShopperInteractionEnum fromValue(String value) {
427427
private Boolean splitCardFundingSources = false;
428428

429429
public static final String JSON_PROPERTY_SPLITS = "splits";
430-
private List<Split> splits = new ArrayList<>();
430+
private List<Split> splits;
431431

432432
public static final String JSON_PROPERTY_STORE = "store";
433433
private String store;

‎src/main/java/com/adyen/model/checkout/CreateOrderResponse.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@
4747

4848
public class CreateOrderResponse {
4949
public static final String JSON_PROPERTY_ADDITIONAL_DATA = "additionalData";
50-
private Map<String, String> additionalData = new HashMap<>();
50+
private Map<String, String> additionalData;
5151

5252
public static final String JSON_PROPERTY_AMOUNT = "amount";
5353
private Amount amount;

‎src/main/java/com/adyen/model/checkout/DeviceRenderOptions.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ public static SdkUiTypeEnum fromValue(String value) {
118118
}
119119

120120
public static final String JSON_PROPERTY_SDK_UI_TYPE = "sdkUiType";
121-
private List<SdkUiTypeEnum> sdkUiType = new ArrayList<>();
121+
private List<SdkUiTypeEnum> sdkUiType;
122122

123123
public DeviceRenderOptions() {
124124
}

‎src/main/java/com/adyen/model/checkout/Donation.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ public class Donation {
4848
private Long maxRoundupAmount;
4949

5050
public static final String JSON_PROPERTY_VALUES = "values";
51-
private List<Long> values = new ArrayList<>();
51+
private List<Long> values;
5252

5353
public Donation() {
5454
}

‎src/main/java/com/adyen/model/checkout/DonationCampaignsResponse.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@
3737

3838
public class DonationCampaignsResponse {
3939
public static final String JSON_PROPERTY_DONATION_CAMPAIGNS = "donationCampaigns";
40-
private List<DonationCampaign> donationCampaigns = new ArrayList<>();
40+
private List<DonationCampaign> donationCampaigns;
4141

4242
public DonationCampaignsResponse() {
4343
}

‎src/main/java/com/adyen/model/checkout/DonationPaymentRequest.java

+3-3
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ public class DonationPaymentRequest {
9696
private AccountInfo accountInfo;
9797

9898
public static final String JSON_PROPERTY_ADDITIONAL_DATA = "additionalData";
99-
private Map<String, String> additionalData = new HashMap<>();
99+
private Map<String, String> additionalData;
100100

101101
public static final String JSON_PROPERTY_AMOUNT = "amount";
102102
private Amount amount;
@@ -188,7 +188,7 @@ public static ChannelEnum fromValue(String value) {
188188
private String donationToken;
189189

190190
public static final String JSON_PROPERTY_LINE_ITEMS = "lineItems";
191-
private List<LineItem> lineItems = new ArrayList<>();
191+
private List<LineItem> lineItems;
192192

193193
public static final String JSON_PROPERTY_MERCHANT_ACCOUNT = "merchantAccount";
194194
private String merchantAccount;
@@ -197,7 +197,7 @@ public static ChannelEnum fromValue(String value) {
197197
private MerchantRiskIndicator merchantRiskIndicator;
198198

199199
public static final String JSON_PROPERTY_METADATA = "metadata";
200-
private Map<String, String> metadata = new HashMap<>();
200+
private Map<String, String> metadata;
201201

202202
public static final String JSON_PROPERTY_MPI_DATA = "mpiData";
203203
private ThreeDSecureData mpiData;

‎src/main/java/com/adyen/model/checkout/FraudResult.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ public class FraudResult {
4141
private Integer accountScore;
4242

4343
public static final String JSON_PROPERTY_RESULTS = "results";
44-
private List<FraudCheckResult> results = new ArrayList<>();
44+
private List<FraudCheckResult> results;
4545

4646
public FraudResult() {
4747
}

‎src/main/java/com/adyen/model/checkout/InputDetail.java

+4-4
Original file line numberDiff line numberDiff line change
@@ -48,20 +48,20 @@
4848

4949
public class InputDetail {
5050
public static final String JSON_PROPERTY_CONFIGURATION = "configuration";
51-
private Map<String, String> configuration = new HashMap<>();
51+
private Map<String, String> configuration;
5252

5353
public static final String JSON_PROPERTY_DETAILS = "details";
54-
private List<SubInputDetail> details = new ArrayList<>();
54+
private List<SubInputDetail> details;
5555

5656
public static final String JSON_PROPERTY_INPUT_DETAILS = "inputDetails";
5757
@Deprecated // deprecated
58-
private List<SubInputDetail> inputDetails = new ArrayList<>();
58+
private List<SubInputDetail> inputDetails;
5959

6060
public static final String JSON_PROPERTY_ITEM_SEARCH_URL = "itemSearchUrl";
6161
private String itemSearchUrl;
6262

6363
public static final String JSON_PROPERTY_ITEMS = "items";
64-
private List<Item> items = new ArrayList<>();
64+
private List<Item> items;
6565

6666
public static final String JSON_PROPERTY_KEY = "key";
6767
private String key;

‎src/main/java/com/adyen/model/checkout/InstallmentOption.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -93,13 +93,13 @@ public static PlansEnum fromValue(String value) {
9393
}
9494

9595
public static final String JSON_PROPERTY_PLANS = "plans";
96-
private List<PlansEnum> plans = new ArrayList<>();
96+
private List<PlansEnum> plans;
9797

9898
public static final String JSON_PROPERTY_PRESELECTED_VALUE = "preselectedValue";
9999
private Integer preselectedValue;
100100

101101
public static final String JSON_PROPERTY_VALUES = "values";
102-
private List<Integer> values = new ArrayList<>();
102+
private List<Integer> values;
103103

104104
public InstallmentOption() {
105105
}

‎src/main/java/com/adyen/model/checkout/ListStoredPaymentMethodsResponse.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ public class ListStoredPaymentMethodsResponse {
4545
private String shopperReference;
4646

4747
public static final String JSON_PROPERTY_STORED_PAYMENT_METHODS = "storedPaymentMethods";
48-
private List<StoredPaymentMethodResource> storedPaymentMethods = new ArrayList<>();
48+
private List<StoredPaymentMethodResource> storedPaymentMethods;
4949

5050
public ListStoredPaymentMethodsResponse() {
5151
}

‎src/main/java/com/adyen/model/checkout/PaymentAmountUpdateRequest.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ public static IndustryUsageEnum fromValue(String value) {
9292
private IndustryUsageEnum industryUsage;
9393

9494
public static final String JSON_PROPERTY_LINE_ITEMS = "lineItems";
95-
private List<LineItem> lineItems = new ArrayList<>();
95+
private List<LineItem> lineItems;
9696

9797
public static final String JSON_PROPERTY_MERCHANT_ACCOUNT = "merchantAccount";
9898
private String merchantAccount;
@@ -101,7 +101,7 @@ public static IndustryUsageEnum fromValue(String value) {
101101
private String reference;
102102

103103
public static final String JSON_PROPERTY_SPLITS = "splits";
104-
private List<Split> splits = new ArrayList<>();
104+
private List<Split> splits;
105105

106106
public PaymentAmountUpdateRequest() {
107107
}

‎src/main/java/com/adyen/model/checkout/PaymentAmountUpdateResponse.java

+2-2
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ public static IndustryUsageEnum fromValue(String value) {
9090
private IndustryUsageEnum industryUsage;
9191

9292
public static final String JSON_PROPERTY_LINE_ITEMS = "lineItems";
93-
private List<LineItem> lineItems = new ArrayList<>();
93+
private List<LineItem> lineItems;
9494

9595
public static final String JSON_PROPERTY_MERCHANT_ACCOUNT = "merchantAccount";
9696
private String merchantAccount;
@@ -105,7 +105,7 @@ public static IndustryUsageEnum fromValue(String value) {
105105
private String reference;
106106

107107
public static final String JSON_PROPERTY_SPLITS = "splits";
108-
private List<Split> splits = new ArrayList<>();
108+
private List<Split> splits;
109109

110110
/**
111111
* The status of your request. This will always have the value **received**.

0 commit comments

Comments
 (0)