Skip to content

Eliminate hand-written macros when possible #316

@protz

Description

@protz

I am currently reviewing the macros -- as you pointed out in another issue @Lin23299, macros aren't great and we should try to avoid them.

  • slice_to_ref_array could be written in abstract syntax, as a polymorphic function, and then we wouldn't need slice_to_ref_array2, and we wouldn't need a macro
  • some iterators are currently written as macros, but I think we should be able to extract and compile them now; should we simply remove them from the glue, and wait for @Nadrieril to extract everything as needed by the crate (including core) for this to work automatically?
  • some functions from core::convert::num are written by hand in eurydice_glue.h; same question, could these be extracted?
  • the three definitions from core marked as DEPRECATED could probably go

Which of these proposals makes sense? In the long run, I think having the minimal number of macros would be great.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions