Execute triggers in parallel batches #2604
ci.yaml
on: pull_request
Build & Test Project
1m 23s
Annotations
4 warnings
|
Build & Test Project:
moss/src/client/mod.rs#L456
[clippy] reported by reviewdog 🐶
warning: returning the result of a `let` binding from a block
--> moss/src/client/mod.rs:460:21
|
456 | / let trigger_command = match trigger.handler() {
457 | | triggers::format::Handler::Run { run, .. } => run.clone(),
458 | | triggers::format::Handler::Delete { .. } => "delete operation".to_owned(),
459 | | };
| |______________________- unnecessary `let` binding
460 | trigger_command
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
456 ~
457 ~ match trigger.handler() {
458 + triggers::format::Handler::Run { run, .. } => run.clone(),
459 + triggers::format::Handler::Delete { .. } => "delete operation".to_owned(),
460 + }
|
Raw Output:
moss/src/client/mod.rs:456:21:w:warning: returning the result of a `let` binding from a block
--> moss/src/client/mod.rs:460:21
|
456 | / let trigger_command = match trigger.handler() {
457 | | triggers::format::Handler::Run { run, .. } => run.clone(),
458 | | triggers::format::Handler::Delete { .. } => "delete operation".to_owned(),
459 | | };
| |______________________- unnecessary `let` binding
460 | trigger_command
| ^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
456 ~
457 ~ match trigger.handler() {
458 + triggers::format::Handler::Run { run, .. } => run.clone(),
459 + triggers::format::Handler::Delete { .. } => "delete operation".to_owned(),
460 + }
|
__END__
|
|
Build & Test Project:
moss/src/client/mod.rs#L450
[clippy] reported by reviewdog 🐶
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> moss/src/client/mod.rs:450:107
|
450 | TriggerScope::System(install, scope) => postblit::execute_system_triggers(install, scope, &batch)?,
| ^^^^^^ help: change this to: `batch`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
Raw Output:
moss/src/client/mod.rs:450:107:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> moss/src/client/mod.rs:450:107
|
450 | TriggerScope::System(install, scope) => postblit::execute_system_triggers(install, scope, &batch)?,
| ^^^^^^ help: change this to: `batch`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
__END__
|
|
Build & Test Project:
moss/src/client/mod.rs#L448
[clippy] reported by reviewdog 🐶
warning: this expression creates a reference which is immediately dereferenced by the compiler
--> moss/src/client/mod.rs:448:76
|
448 | postblit::execute_transaction_triggers(install, scope, &batch)?
| ^^^^^^ help: change this to: `batch`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
Raw Output:
moss/src/client/mod.rs:448:76:w:warning: this expression creates a reference which is immediately dereferenced by the compiler
--> moss/src/client/mod.rs:448:76
|
448 | postblit::execute_transaction_triggers(install, scope, &batch)?
| ^^^^^^ help: change this to: `batch`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_borrow
= note: `#[warn(clippy::needless_borrow)]` on by default
__END__
|
|
Build & Test Project:
moss/src/client/mod.rs#L448
[clippy] reported by reviewdog 🐶
warning: consider adding a `;` to the last statement for consistent formatting
--> moss/src/client/mod.rs:448:21
|
448 | postblit::execute_transaction_triggers(install, scope, &batch)?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `postblit::execute_transaction_triggers(install, scope, &batch)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#semicolon_if_nothing_returned
= note: requested on the command line with `-W clippy::semicolon-if-nothing-returned`
Raw Output:
moss/src/client/mod.rs:448:21:w:warning: consider adding a `;` to the last statement for consistent formatting
--> moss/src/client/mod.rs:448:21
|
448 | postblit::execute_transaction_triggers(install, scope, &batch)?
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: add a `;` here: `postblit::execute_transaction_triggers(install, scope, &batch)?;`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#semicolon_if_nothing_returned
= note: requested on the command line with `-W clippy::semicolon-if-nothing-returned`
__END__
|