Merge branch 'main' into fix/ssrf-approval-callback-435

Author: 7vignesh

CHANGELOG.md

@@ -6,6 +6,74 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/)
 
 <!-- changelog:entries -->
 
+## [0.1.110-rc.4] - 2026-07-17
+
+
+### Fixed
+
+- Fix(control-plane): dashboard success rate defaults to 100% and actually covers 24h (#792)
+
+* fix(control-plane): dashboard success rate covers a rolling 24h window
+
+The summary endpoint computed success_rate from calendar-today (UTC)
+executions only, returned 0 when nothing had run, and counted in-flight
+executions as failures. An idle system therefore showed a red 0% under a
+label claiming "last 24 hours".
+
+Compute the rate over executions started in the rolling last-24h window,
+count only terminal executions in the denominator, and report 100 when
+none have finished - no completed runs means nothing has failed.
+
+Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
+
+* fix(web): stop double-scaling the dashboard success rate
+
+The summary endpoint returns success_rate as a 0-100 percentage, but the
+dashboard multiplied it by 100 again before display. The test fixtures
+mirrored the same wrong 0-1 scale, so the tautology passed while a real
+server response would have rendered 9100%. Align the fixtures with the
+actual API contract.
+
+Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
+
+---------
+
+Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (623084e)
+
+- Fix(desktop): correct Windows tray icon theme and DPI rendering (#791)
+
+* feat(desktop): generate multi-size ICO tray glyphs
+
+The Windows tray ignores PNG scale-factor representations
+(electron/electron#33044) and upscales the 16px bitmap on >100% displays,
+so make-icons.mjs now also emits one .ico per tray variant with
+16/20/24/32/48 frames (20 covers the common 125% scaling). The PNGs stay
+for the Linux representation path.
+
+Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
+
+* fix(desktop): render the Windows tray glyph correctly
+
+Two fixes for the washed-out / blurry tray icon on Windows:
+
+- Pick the light/dark glyph from the *system* (taskbar) theme via
+  nativeTheme.shouldUseDarkColorsForSystemIntegratedUI instead of
+  shouldUseDarkColors, which tracks the separately-configurable *apps*
+  theme. With mixed themes (dark taskbar + light apps is common) the
+  tray wore a near-invisible glyph that read as the offline icon. The
+  poll re-checks the theme too, since Windows does not reliably emit
+  nativeTheme 'updated' for system-theme-only flips.
+- Load the tray image from the multi-size .ico on win32 so Electron
+  serves a DPI-correct frame; scale-factor PNG representations are
+  ignored by the Windows tray (electron/electron#33044) and the 16px
+  bitmap got upscaled on >100% displays.
+
+Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
+
+---------
+
+Co-authored-by: Claude Fable 5 <noreply@anthropic.com> (6da0607)
+
 ## [0.1.110-rc.3] - 2026-07-17
 
 

VERSION

@@ -1 +1 @@
-0.1.110-rc.3
+0.1.110-rc.4

control-plane/internal/handlers/ui/coverage_dashboard_additional_test.go

@@ -215,6 +215,15 @@ func TestDashboardPureHelpersCoverage(t *testing.T) {
 			{Status: string(types.ExecutionStatusSucceeded)},
 			{Status: string(types.ExecutionStatusFailed)},
 		}))
+		require.Equal(t, 100.0, (&DashboardHandler{}).calculateSuccessRate(nil))
+		require.Equal(t, 100.0, (&DashboardHandler{}).calculateSuccessRate([]*types.Execution{
+			{Status: string(types.ExecutionStatusRunning)},
+		}))
+		require.Equal(t, 50.0, (&DashboardHandler{}).calculateSuccessRate([]*types.Execution{
+			{Status: string(types.ExecutionStatusSucceeded)},
+			{Status: string(types.ExecutionStatusFailed)},
+			{Status: string(types.ExecutionStatusRunning)},
+		}))
 	})
 }
 

control-plane/internal/handlers/ui/coverage_nodes_dashboard_summary_test.go

@@ -2,10 +2,12 @@ package ui
 
 import (
 	"context"
+	"encoding/json"
 	"errors"
 	"net/http"
 	"net/http/httptest"
 	"testing"
+	"time"
 
 	"github.com/Agent-Field/agentfield/control-plane/internal/core/domain"
 	"github.com/Agent-Field/agentfield/control-plane/internal/services"
@@ -23,7 +25,7 @@ func (s *dashboardOverrideStorage) QueryExecutionRecords(ctx context.Context, fi
 	if s.queryExecutionRecordsFn != nil {
 		return s.queryExecutionRecordsFn(ctx, filter)
 	}
-	return s.overrideStorage.StorageProvider.QueryExecutionRecords(ctx, filter)
+	return s.StorageProvider.QueryExecutionRecords(ctx, filter)
 }
 
 func TestNodesHandlerAdditionalCoverage(t *testing.T) {
@@ -98,6 +100,32 @@ func TestDashboardSummaryHandlerAdditionalCoverage(t *testing.T) {
 		require.Equal(t, http.StatusOK, resp.Code)
 	})
 
+	t.Run("idle system reports vacuous 100 percent success", func(t *testing.T) {
+		store := &dashboardOverrideStorage{overrideStorage: &overrideStorage{StorageProvider: setupTestStorage(t)}}
+		handler := NewDashboardHandler(store, &mockLifecycleAgentService{})
+		router := gin.New()
+		router.GET("/api/ui/v1/dashboard", handler.GetDashboardSummaryHandler)
+
+		store.queryExecutionRecordsFn = func(ctx context.Context, filter types.ExecutionFilter) ([]*types.Execution, error) {
+			return nil, nil
+		}
+		store.queryAgentPackagesFn = func(ctx context.Context, filters types.PackageFilters) ([]*types.AgentPackage, error) {
+			return nil, nil
+		}
+		store.listAgentsFn = func(ctx context.Context, filters types.AgentFilters) ([]*types.AgentNode, error) {
+			return nil, nil
+		}
+
+		resp := httptest.NewRecorder()
+		router.ServeHTTP(resp, httptest.NewRequest(http.MethodGet, "/api/ui/v1/dashboard", nil))
+		require.Equal(t, http.StatusOK, resp.Code)
+
+		var body DashboardSummaryResponse
+		require.NoError(t, json.Unmarshal(resp.Body.Bytes(), &body))
+		require.Equal(t, 100.0, body.SuccessRate)
+		require.Equal(t, 0, body.Executions.Today)
+	})
+
 	t.Run("error when collector fails", func(t *testing.T) {
 		store := &dashboardOverrideStorage{overrideStorage: &overrideStorage{StorageProvider: setupTestStorage(t)}}
 		handler := NewDashboardHandler(store, &mockLifecycleAgentService{})
@@ -119,3 +147,35 @@ func TestDashboardSummaryHandlerAdditionalCoverage(t *testing.T) {
 		require.Equal(t, http.StatusInternalServerError, resp.Code)
 	})
 }
+
+func TestExecutionsSummarySuccessRateRolling24h(t *testing.T) {
+	gin.SetMode(gin.TestMode)
+
+	store := &dashboardOverrideStorage{overrideStorage: &overrideStorage{StorageProvider: setupTestStorage(t)}}
+	handler := NewDashboardHandler(store, &mockLifecycleAgentService{})
+
+	// 01:00 UTC: the calendar-today window is only an hour old, so most of the
+	// rolling 24h window falls in yesterday's calendar window.
+	now := time.Date(2026, 7, 17, 1, 0, 0, 0, time.UTC)
+	today := time.Date(2026, 7, 17, 0, 0, 0, 0, time.UTC)
+
+	runningToday := &types.Execution{Status: string(types.ExecutionStatusRunning), StartedAt: now.Add(-15 * time.Minute)}
+	failedWithin24h := &types.Execution{Status: string(types.ExecutionStatusFailed), StartedAt: now.Add(-23 * time.Hour)}
+	succeededWithin24h := &types.Execution{Status: string(types.ExecutionStatusSucceeded), StartedAt: now.Add(-23*time.Hour - 30*time.Minute)}
+	succeededOutside24h := &types.Execution{Status: string(types.ExecutionStatusSucceeded), StartedAt: now.Add(-24*time.Hour - 30*time.Minute)}
+
+	store.queryExecutionRecordsFn = func(ctx context.Context, filter types.ExecutionFilter) ([]*types.Execution, error) {
+		if filter.StartTime != nil && filter.StartTime.Equal(today) {
+			return []*types.Execution{runningToday}, nil
+		}
+		return []*types.Execution{failedWithin24h, succeededWithin24h, succeededOutside24h}, nil
+	}
+
+	summary, rate, err := handler.getExecutionsSummaryAndSuccessRate(context.Background(), now)
+	require.NoError(t, err)
+	require.Equal(t, 1, summary.Today)
+	require.Equal(t, 3, summary.Yesterday)
+	// Rate basis: failedWithin24h + succeededWithin24h. The in-flight run does
+	// not count against the rate and the pre-window success is excluded.
+	require.Equal(t, 50.0, rate)
+}

control-plane/internal/handlers/ui/dashboard.go

@@ -36,10 +36,12 @@ func NewDashboardHandler(storage storage.StorageProvider, agentService interface
 
 // DashboardSummaryResponse represents the dashboard summary response
 type DashboardSummaryResponse struct {
-	Agents      AgentsSummary     `json:"agents"`
-	Executions  ExecutionsSummary `json:"executions"`
-	SuccessRate float64           `json:"success_rate"`
-	Packages    PackagesSummary   `json:"packages"`
+	Agents     AgentsSummary     `json:"agents"`
+	Executions ExecutionsSummary `json:"executions"`
+	// SuccessRate is the percentage (0-100) of terminal executions started in
+	// the last 24 hours that succeeded; 100 when none have finished.
+	SuccessRate float64         `json:"success_rate"`
+	Packages    PackagesSummary `json:"packages"`
 }
 
 // AgentsSummary represents agent statistics

control-plane/internal/handlers/ui/dashboard_aggregate.go

@@ -779,29 +779,48 @@ func (h *DashboardHandler) getExecutionsSummaryAndSuccessRate(ctx context.Contex
 		return ExecutionsSummary{}, 0, err
 	}
 
-	// Calculate success rate from today's executions
-	successRate := h.calculateSuccessRate(todayExecutions)
+	// Success rate covers the rolling last-24h window, which spans the tail of
+	// yesterday's calendar window plus all of today's.
+	cutoff := now.Add(-24 * time.Hour)
+	last24h := make([]*types.Execution, 0, len(todayExecutions)+len(yesterdayExecutions))
+	for _, exec := range todayExecutions {
+		if !exec.StartedAt.Before(cutoff) {
+			last24h = append(last24h, exec)
+		}
+	}
+	for _, exec := range yesterdayExecutions {
+		if !exec.StartedAt.Before(cutoff) {
+			last24h = append(last24h, exec)
+		}
+	}
+	successRate := h.calculateSuccessRate(last24h)
 
 	return ExecutionsSummary{
 		Today:     len(todayExecutions),
 		Yesterday: len(yesterdayExecutions),
 	}, successRate, nil
 }
 
-// calculateSuccessRate calculates the success rate from executions
+// calculateSuccessRate returns the percentage of terminal executions that
+// succeeded. In-flight executions don't count against the rate, and with no
+// terminal executions at all there is nothing failing, so it reports 100.
 func (h *DashboardHandler) calculateSuccessRate(executions []*types.Execution) float64 {
-	if len(executions) == 0 {
-		return 0.0
-	}
-
 	successCount := 0
+	terminalCount := 0
 	for _, exec := range executions {
+		if !types.IsTerminalExecutionStatus(exec.Status) {
+			continue
+		}
+		terminalCount++
 		if types.NormalizeExecutionStatus(exec.Status) == types.ExecutionStatusSucceeded {
 			successCount++
 		}
 	}
+	if terminalCount == 0 {
+		return 100.0
+	}
 
-	return float64(successCount) / float64(len(executions)) * 100.0
+	return float64(successCount) / float64(terminalCount) * 100.0
 }
 
 // getPackagesSummary collects package statistics

control-plane/internal/templates/go/go.mod.tmpl

@@ -2,4 +2,4 @@ module {{.GoModule}}
 
 go 1.23
 
-require github.com/Agent-Field/agentfield/sdk/go v0.1.110-rc.3
+require github.com/Agent-Field/agentfield/sdk/go v0.1.110-rc.4

control-plane/web/client/src/pages/NewDashboardPage.test.tsx

@@ -130,7 +130,7 @@ describe("NewDashboardPage", () => {
     });
     vi.mocked(getDashboardSummary).mockResolvedValue({
       executions: { today: 10 },
-      success_rate: 0.9,
+      success_rate: 90,
       agents: { running: 1 },
     });
   });
@@ -279,7 +279,7 @@ describe("NewDashboardPage", () => {
     });
     vi.mocked(getDashboardSummary).mockResolvedValue({
         executions: { today: 123 },
-        success_rate: 0.88,
+        success_rate: 88,
         agents: { running: 5 },
     });
 

control-plane/web/client/src/pages/NewDashboardPage.tsx

@@ -782,7 +782,7 @@ export function NewDashboardPage() {
           <Separator orientation="vertical" className="hidden h-6 sm:block" />
           <div className="flex items-center gap-1.5">
             <span className="text-2xl font-semibold tabular-nums">
-              {successRate != null ? `${(successRate * 100).toFixed(0)}%` : "—"}
+              {successRate != null ? `${successRate.toFixed(0)}%` : "—"}
             </span>
             <span className="text-muted-foreground">success</span>
           </div>

control-plane/web/client/src/test/pages/NewDashboardPage.test.tsx

@@ -10,7 +10,7 @@ const pageState = vi.hoisted(() => ({
   useQueryResult: {
     data: {
       executions: { today: 12 },
-      success_rate: 0.91,
+      success_rate: 91,
       agents: { running: 3 },
     },
     isLoading: false,
@@ -147,7 +147,7 @@ describe("NewDashboardPage", () => {
     pageState.useQueryResult = {
       data: {
         executions: { today: 12 },
-        success_rate: 0.91,
+        success_rate: 91,
         agents: { running: 3 },
       },
       isLoading: false,