Skip to content

Commit e745532

Browse files
Fix #469: wrap --ag-focus in rgba() to restore invisible focus rings (#472)
* Bump core version for v2/site * Fix #469: wrap --ag-focus in rgba() on collapsible summary:focus-visible --ag-focus is a raw RGB triplet, not a hex color, so it must be used as rgba(var(--ag-focus), 0.5) to produce a valid outline color. Matches the pattern already used by ag-accordion-item. * Fix #469: wrap --ag-focus in rgba() for Badge, Breadcrumb, Menu, IconButton Audit of v2/lib components revealed four more components using bare var(--ag-focus) as an outline color. Since --ag-focus is a raw RGB triplet, it must be wrapped in rgba() to produce a valid CSS color. Aligns all components with the correct pattern already used by Accordion, Button, Checkbox, Input, Link, Pagination, Radio, Toggle, and others.
1 parent 8c8c732 commit e745532

File tree

6 files changed

+9
-9
lines changed

6 files changed

+9
-9
lines changed

v2/lib/src/components/Badge/core/_Badge.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -108,7 +108,7 @@ export class AgBadge extends LitElement implements BadgeProps {
108108
filter: brightness(1.1);
109109
}
110110
:host([interactive]) .badge:focus-visible {
111-
outline: var(--ag-focus-width) solid var(--ag-focus);
111+
outline: var(--ag-focus-width) solid rgba(var(--ag-focus), 0.5);
112112
outline-offset: var(--ag-focus-offset);
113113
}
114114
:host([single-char]) .badge {

v2/lib/src/components/Breadcrumb/core/_Breadcrumb.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ export class AgBreadcrumb extends LitElement implements BreadcrumbProps {
145145
}
146146
147147
.ag-breadcrumb__link:focus-visible {
148-
outline: var(--ag-focus-width) solid var(--ag-focus);
148+
outline: var(--ag-focus-width) solid rgba(var(--ag-focus), 0.5);
149149
outline-offset: var(--ag-focus-offset);
150150
}
151151

v2/lib/src/components/Collapsible/core/_Collapsible.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ export class AgCollapsible extends LitElement implements CollapsibleProps {
8888
}
8989
9090
summary:focus-visible {
91-
outline: var(--ag-focus-width) solid var(--ag-focus);
91+
outline: var(--ag-focus-width) solid rgba(var(--ag-focus), 0.5);
9292
outline-offset: var(--ag-focus-offset);
9393
transition: outline var(--ag-motion-medium) ease;
9494
}

v2/lib/src/components/IconButton/core/_IconButton.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -152,7 +152,7 @@ export class AgIconButton extends LitElement implements IconButtonProps {
152152
153153
/* Focus state - High contrast, color-independent */
154154
button:focus-visible {
155-
outline: var(--ag-focus-width) solid var(--ag-focus);
155+
outline: var(--ag-focus-width) solid rgba(var(--ag-focus), 0.5);
156156
outline-offset: var(--ag-focus-offset);
157157
}
158158

v2/lib/src/components/Menu/core/_Menu.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -834,7 +834,7 @@ export class AgMenuItem extends LitElement implements MenuItemProps {
834834
button:focus,
835835
a:focus {
836836
background-color: var(--ag-background-secondary);
837-
outline: var(--ag-focus-width) solid var(--ag-focus);
837+
outline: var(--ag-focus-width) solid rgba(var(--ag-focus), 0.5);
838838
outline-offset: 0;
839839
}
840840

v2/site/package-lock.json

Lines changed: 4 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)