`bankSend` assumes the `validator` account is only possible sender

[anilhelvaci]

Problem Definition

Current bankSend only uses the validator account as its from account. There might be situations where an account other than the validator is needed to be the sender.

agoric-3-proposals/packages/synthetic-chain/src/lib/agd-lib.ts

Lines 136 to 143 in c9644d6

	export const bankSend = (addr: string, wanted: string) => {
	const chain = ['--chain-id', CHAINID];
	const from = ['--from', VALIDATORADDR];
	const testKeyring = ['--keyring-backend', 'test'];
	const noise = [...from, ...chain, ...testKeyring, '--yes'];
	return agd.tx('bank', 'send', VALIDATORADDR, addr, wanted, ...noise);
	};

Solution

In order not to break any existing code, I suggest an implementation like below:

export const bankSend = (addr, wanted, from = VALIDATORADDR) => {
  const chain = ['--chain-id', CHAINID];
  const fromArg = ['--from', from];
  const testKeyring = ['--keyring-backend', 'test'];
  const noise = [...fromArg, ...chain, ...testKeyring, '--yes'];

  return agd.tx('bank', 'send', from, addr, wanted, ...noise);
};