Skip to content

VALIDATORADDR is misnamed #212

Open
Open
@turadg

Description

@turadg

Problem

from @anilhelvaci in Agoric/agoric-sdk#10835 (comment)

VALIDATORADDR refers to the validator's "Application Key" whereas VALIDATOR_ADDRESS refers to the validator's "CometBFT Key". See https://hub.cosmos.network/main/validators/validator-faq.html#what-are-the-different-types-of-keys.

For example:

  • VALIDATORADDR: agoric1estsewt6jqsx77pwcxkn5ah0jqgu8rhgflwfdl
  • VALIDATOR_ADDRESS: agoricvaloper1estsewt6jqsx77pwcxkn5ah0jqgu8rhge8aq37

Solution

In env_setup.sh,

  • rename VALIDATORADDR to DELEGATOR_ADDRRESS
  • define actual VALIDATOR_ADDRESS

Update all proposals to handle this change

Work-around

Proposals have had this in their test.sh,

# XXX correct misnaming
DELEGATOR_ADDRRESS=$VALIDATORADDR
VALIDATOR_ADDRESS=$(agd query staking delegations "$DELEGATOR_ADDRRESS" --output json | jq -r ".delegation_responses[0].delegation.validator_address")
export VALIDATOR_ADDRESS

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions