Skip to content

Commit 71d6486

Browse files
authored
feat(test): Improve unit test coverage (#676)
1 parent 711157e commit 71d6486

File tree

2 files changed

+17
-13
lines changed

2 files changed

+17
-13
lines changed

cosid-core/src/main/java/me/ahoo/cosid/cosid/RadixCosIdGenerator.java

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -118,11 +118,5 @@ public synchronized CosIdState generateAsState() {
118118
lastTimestamp = currentTimestamp;
119119
return new CosIdState(lastTimestamp, machineId, sequence);
120120
}
121-
122-
@Nonnull
123-
@Override
124-
public String generateAsString() {
125-
CosIdState state = generateAsState();
126-
return stateParser.asString(state);
127-
}
121+
128122
}

cosid-core/src/test/java/me/ahoo/cosid/cosid/Radix62CosIdGeneratorTest.java

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727

2828
class Radix62CosIdGeneratorTest {
2929
private final Radix62CosIdGenerator radix62CosIdGenerator = new Radix62CosIdGenerator(1);
30-
30+
3131
@Test
3232
void generateAsString() {
3333
String id1 = radix62CosIdGenerator.generateAsString();
@@ -37,21 +37,21 @@ void generateAsString() {
3737
assertThat(id2.length(), equalTo(id1.length()));
3838
assertThat(radix62CosIdGenerator.getLastTimestamp(), greaterThan(0L));
3939
}
40-
40+
4141
@Test
4242
void generateAsState() {
4343
CosIdState state1 = radix62CosIdGenerator.generateAsState();
4444
CosIdState state2 = radix62CosIdGenerator.generateAsState();
4545
assertThat(state2, greaterThan(state1));
4646
}
47-
47+
4848
@Test
4949
void customizeOverflowMachineId() {
5050
Assertions.assertThrows(IllegalArgumentException.class, () -> {
5151
new Radix62CosIdGenerator(~(-1 << DEFAULT_MACHINE_BIT) + 1);
5252
});
5353
}
54-
54+
5555
@Test
5656
void generateSlow() {
5757
Radix62CosIdGenerator cosIdGenerator = new Radix62CosIdGenerator(DEFAULT_TIMESTAMP_BIT, DEFAULT_MACHINE_BIT, DEFAULT_SEQUENCE_BIT, 1, 2);
@@ -62,14 +62,24 @@ void generateSlow() {
6262
CosIdState state3 = cosIdGenerator.generateAsState();
6363
assertThat(state3, greaterThan(state2));
6464
assertThat(state2, greaterThan(state1));
65-
65+
6666
assertThat(state1.getSequence(), equalTo(1));
6767
assertThat(state2.getSequence(), equalTo(2));
6868
assertThat(state1.getSequence(), equalTo(1));
6969
}
70-
70+
7171
@Test
7272
public void generateWhenConcurrentString() {
7373
new ConcurrentGenerateStingSpec(new Radix62CosIdGenerator(1)).verify();
7474
}
75+
76+
@Test
77+
public void idConvert() {
78+
Assertions.assertThrows(UnsupportedOperationException.class, radix62CosIdGenerator::idConverter);
79+
}
80+
81+
@Test
82+
public void generate() {
83+
Assertions.assertThrows(UnsupportedOperationException.class, radix62CosIdGenerator::generate);
84+
}
7585
}

0 commit comments

Comments
 (0)