Improve test coverage

Author: hansott

library/sinks/Fetch.test.ts

@@ -99,8 +99,10 @@ t.test(
     };
     addHook("beforeOutboundRequest", hook);
     await fetch("http://app.aikido.dev");
+    await fetch(new Request("https://app.aikido.dev", { method: "POST" }));
     t.same(agent.getHostnames().asArray(), [
       { hostname: "app.aikido.dev", port: 80, hits: 1 },
+      { hostname: "app.aikido.dev", port: 443, hits: 1 },
     ]);
     agent.getHostnames().clear();
     t.same(hookArgs, [
@@ -109,6 +111,11 @@ t.test(
         method: "GET",
         port: 80,
       },
+      {
+        url: new URL("https://app.aikido.dev/"),
+        method: "POST",
+        port: 443,
+      },
     ]);
     removeHook("beforeOutboundRequest", hook);
 

library/sinks/Undici.tests.ts

@@ -83,8 +83,12 @@ export async function createUndiciTests(undiciPkgName: string, port: number) {
         pathname: "/my-path",
         search: "?a=b",
       });
+      await request(`http://localhost:${port}/api/internal`, {
+        method: "POST",
+      });
       t.same(agent.getHostnames().asArray(), [
         { hostname: "ssrf-redirects.testssandbox.com", port: 443, hits: 1 },
+        { hostname: "localhost", port: port, hits: 1 },
       ]);
       agent.getHostnames().clear();
       t.same(hookArgs, [
@@ -93,6 +97,11 @@ export async function createUndiciTests(undiciPkgName: string, port: number) {
           method: "GET",
           port: 443,
         },
+        {
+          url: new URL(`http://localhost:${port}/api/internal`),
+          method: "POST",
+          port: port,
+        },
       ]);
       removeHook("beforeOutboundRequest", beforeOutbound);
 

library/sinks/undici/buildURLFromObject.test.ts

@@ -2,6 +2,11 @@ import * as t from "tap";
 import { buildURLFromArgs } from "./buildURLFromObject";
 import { parse as parseUrl } from "url";
 
+t.test("empty", async (t) => {
+  const url = buildURLFromArgs([]);
+  t.same(url, undefined);
+});
+
 t.test("it returns an URL instance", async (t) => {
   const url = buildURLFromArgs(["http://localhost:4000"]);
   t.ok(url instanceof URL);
@@ -22,6 +27,21 @@ t.test("it returns the full url", async () => {
   );
 });
 
+t.test("origin ends with slash", async (t) => {
+  t.same(
+    buildURLFromArgs([
+      { origin: "http://localhost:4000/", pathname: "/api", search: "?page=1" },
+    ])?.toString(),
+    "http://localhost:4000/api?page=1"
+  );
+  t.same(
+    buildURLFromArgs([
+      { origin: "http://localhost:4000/", path: "/api?page=1" },
+    ])?.toString(),
+    "http://localhost:4000/api?page=1"
+  );
+});
+
 t.test("it works with url string", async (t) => {
   t.same(
     buildURLFromArgs(["http://localhost:4000"])?.toString(),