ci: gate publishing on typecheck, lint, tests and a compiled smoke test

The publish workflow ran only 'npm test --if-present' and then published.
Since the package now ships dist/ rather than a checked-in source file, it
also verifies that the compiled entry point starts and answers on STDIO
before anything reaches npm.

Also fixes the last stale docs references: README pointed at the old
server.test.mjs for loadServerAs(), PUBLISHING.md still named server.mjs as
the entry point.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

Author: Stephan Ferraro

.github/workflows/publish.yml

@@ -29,12 +29,28 @@ jobs:
           node-version: '22'
           registry-url: 'https://registry.npmjs.org'
 
+      # `prepare` compiles src/ -> dist/ as part of the install; `prepublishOnly`
+      # rebuilds and re-runs the suite before the publish itself.
       - name: Install dependencies
         run: npm ci
-        
-      - name: Run tests (if any)
-        run: npm test --if-present
-        
+
+      - name: Typecheck
+        run: npm run typecheck
+
+      - name: Lint
+        run: npm run lint
+
+      - name: Run tests
+        run: npm test
+
+      # dist/ is what actually ships — verify it starts before publishing it.
+      - name: Smoke-test the compiled server
+        run: |
+          echo '{"jsonrpc":"2.0","id":1,"method":"initialize","params":{"protocolVersion":"2024-11-05","capabilities":{},"clientInfo":{"name":"ci","version":"1"}}}' \
+            | MCP_SILENT=true node bin/mcp-ssh.js \
+            | grep -q '"serverInfo"'
+
+
       - name: Bump version (if manual trigger)
         if: github.event_name == 'workflow_dispatch'
         run: npm version ${{ github.event.inputs.version }} --no-git-tag-version

PUBLISHING.md

@@ -71,4 +71,4 @@ The package is configured with:
 - Scoped name: `@aiondadotcom/mcp-ssh`
 - Public access
 - Binary: `mcp-ssh` command
-- Entry point: `server.mjs`
+- Entry point: `dist/server.js`, compiled from `src/` (`prepublishOnly` runs the build and the test suite)

README.md

@@ -55,9 +55,11 @@ npm install -g @aiondadotcom/mcp-ssh
 ```bash
 git clone https://github.com/aiondadotcom/mcp-ssh.git
 cd mcp-ssh
-npm install
+npm install   # also compiles src/ -> dist/
 npm start
 ```
+The server is TypeScript under `src/`; `npm install` builds it. After editing sources run
+`npm run build` (or `npm test`, which reads `src/` directly).
 
 ## Example Usage
 
@@ -683,7 +685,7 @@ Three things to know before opening a PR:
   reports an empty string, see issue #10) or for `timeout || DEFAULT`.
 - **CI runs on Linux and Windows** across Node 20, 22 and 24. Platform-specific code paths are
   tested from either OS by re-importing the module with `process.platform` faked — see
-  `loadServerAs()` in `server.test.mjs` — rather than by skipping tests on one platform.
+  `loadServerAs()` in `src/test-helpers.ts` — rather than by skipping tests on one platform.
 
 ## License