Re-enable Checkstyle, fix errors, add suppressions

Author: C0urante

config/checkstyle/google_checks.xml

@@ -24,4 +24,11 @@
         "http://www.puppycrawl.com/dtds/suppressions_1_1.dtd">
 
 <suppressions>
+    <suppress checks="MissingJavadocType" files=".*" />
+    <suppress checks="MissingJavadocMethod" files=".*" />
+    <suppress checks="SummaryJavadoc" files="." />
+    <suppress checks="JavadocTagContinuationIndentation" files=".*" />
+    <suppress checks="NonEmptyAtclauseDescription" files=".*" />
+
+    <suppress checks="LineLength" files=".*" />
 </suppressions>

config/checkstyle/suppressions.xml

@@ -21,20 +21,20 @@
 
 
 /**
- *  Enum class for Kafka schema or record type, either value or key.
+ * Enum class for Kafka schema or record type, either value or key.
  */
 public enum KafkaSchemaRecordType {
 
-    VALUE("value"),
-    KEY("key");
+  VALUE("value"),
+  KEY("key");
 
-    private final String str;
+  private final String str;
 
-    KafkaSchemaRecordType(String str) {
-        this.str = str;
-    }
+  KafkaSchemaRecordType(String str) {
+    this.str = str;
+  }
 
-    public String toString() {
-        return this.str;
-    }
+  public String toString() {
+    return this.str;
+  }
 }

kcbq-api/src/main/java/com/wepay/kafka/connect/bigquery/api/KafkaSchemaRecordType.java

@@ -19,11 +19,10 @@
 
 package com.wepay.kafka.connect.bigquery.api;
 
+import java.util.Map;
 import org.apache.kafka.connect.data.Schema;
 import org.apache.kafka.connect.sink.SinkRecord;
 
-import java.util.Map;
-
 /**
  * Interface for retrieving the most up-to-date schemas for a given Sink Record. Used in
  * automatic table creation and schema updates.
@@ -32,19 +31,22 @@ public interface SchemaRetriever {
   /**
    * Called with all of the configuration settings passed to the connector via its
    * {@link org.apache.kafka.connect.sink.SinkConnector#start(Map)} method.
+   *
    * @param properties The configuration settings of the connector.
    */
   void configure(Map<String, String> properties);
 
   /**
    * Retrieve the most current key schema for the given sink record.
+   *
    * @param record The record to retrieve a key schema for.
    * @return The key Schema for the given record.
    */
   Schema retrieveKeySchema(SinkRecord record);
 
   /**
    * Retrieve the most current value schema for the given sink record.
+   *
    * @param record The record to retrieve a value schema for.
    * @return The value Schema for the given record.
    */

kcbq-api/src/main/java/com/wepay/kafka/connect/bigquery/api/SchemaRetriever.java

@@ -19,7 +19,8 @@
     under the License.
 
 -->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+<project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
+         xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
     <modelVersion>4.0.0</modelVersion>
 
     <parent>

kcbq-connector/pom.xml

@@ -22,6 +22,10 @@
 import com.wepay.kafka.connect.bigquery.config.BigQuerySinkConfig;
 import com.wepay.kafka.connect.bigquery.config.BigQuerySinkTaskConfig;
 import com.wepay.kafka.connect.bigquery.utils.Version;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
 import org.apache.kafka.common.config.Config;
 import org.apache.kafka.common.config.ConfigDef;
 import org.apache.kafka.common.config.ConfigValue;
@@ -30,22 +34,16 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.List;
-import java.util.Map;
-
 /**
  * A {@link SinkConnector} used to delegate BigQuery data writes to
  * {@link org.apache.kafka.connect.sink.SinkTask SinkTasks}.
  */
 public class BigQuerySinkConnector extends SinkConnector {
 
+  private static final Logger logger = LoggerFactory.getLogger(BigQuerySinkConnector.class);
   private BigQuerySinkConfig config;
   private Map<String, String> configProperties;
 
-  private static final Logger logger = LoggerFactory.getLogger(BigQuerySinkConnector.class);
-
   @Override
   public ConfigDef config() {
     logger.trace("connector.config()");