Updating proto runtime path (#1170)

* Updating proto runtime path

* Updating proto runtime path

* Updating proto runtime path

* Updating proto runtime path

Author: muralibasani

src/karapace/kafka_rest_apis/consumer_manager.py

@@ -551,11 +551,18 @@ async def fetch(self, internal_name: tuple[str, str], content_type: str, formats
                 try:
                     key = await self.deserialize(msg.key(), request_format) if msg.key() else None
                 except DeserializationError as e:
-                    KarapaceBase.unprocessable_entity(
-                        message=f"key deserialization error for format {request_format}: {e}",
-                        sub_code=RESTErrorCodes.HTTP_UNPROCESSABLE_ENTITY.value,
-                        content_type=content_type,
-                    )
+                    if request_format == "avro":
+                        LOG.warning("Cannot process non-empty key using avro deserializer, falling back to binary.")
+                        key = await self.deserialize(msg.key(), "binary")
+                    if request_format == "protobuf":
+                        LOG.warning("Cannot process non-empty key using protobuf deserializer, falling back to binary.")
+                        key = await self.deserialize(msg.key(), "binary")
+                    else:
+                        KarapaceBase.unprocessable_entity(
+                            message=f"key deserialization error for format {request_format}: {e}",
+                            sub_code=RESTErrorCodes.HTTP_UNPROCESSABLE_ENTITY.value,
+                            content_type=content_type,
+                        )
                 try:
                     value = await self.deserialize(msg.value(), request_format) if msg.value() else None
                 except DeserializationError as e:

src/karapace/protobuf/io.py

@@ -133,7 +133,7 @@ def get_protobuf_class_instance(
                 cwd=work_dir,
             )
 
-    runtime_proto_path = f"./runtime/{proto_name}"
+    runtime_proto_path = str(work_dir.resolve())
     if runtime_proto_path not in sys.path:
         # todo: This will leave residues on sys.path in case of exceptions. If really must
         # mutate sys.path, we should at least wrap in try-finally.

src/karapace/schema_models.py

@@ -27,7 +27,7 @@
 from karapace.schema_type import SchemaType
 from karapace.typing import JsonObject, SchemaId, Subject, Version, VersionTag
 from karapace.utils import assert_never, json_decode, json_encode, JSONDecodeError
-from typing import Any, cast, Final, final
+from typing import Any, cast, Final, final, Union
 
 import hashlib
 import logging
@@ -53,11 +53,12 @@ def parse_jsonschema_definition(schema_definition: str) -> Draft7Validator:
     Raises:
         SchemaError: If `schema_definition` is not a valid Draft7 schema.
     """
-    schema = json_decode(schema_definition)
+    raw_schema = json_decode(schema_definition)
+    schema = cast(Union[Mapping[str, Any], bool], raw_schema)
     # TODO: Annotations dictate Mapping[str, Any] here, but we have unit tests that
     #  use bool values and fail if we assert isinstance(_, dict).
-    Draft7Validator.check_schema(schema)  # type: ignore[arg-type]
-    return Draft7Validator(schema)  # type: ignore[arg-type]
+    Draft7Validator.check_schema(schema)
+    return Draft7Validator(schema)
 
 
 def _format_protobuf(schema: str, dependencies: Collection[Dependency], name: str = "schema.proto") -> str: