Merge pull request #468 from aiven/jjaakola-aiven-fix-schema-listing-endpoint

fix: schema list endpoint to iterate subject schemas

Author: tvainika

karapace/schema_registry_apis.py

@@ -362,18 +362,20 @@ async def schemas_list(self, content_type: str, *, request: HTTPRequest, user: O
 
         schemas = await self.schema_registry.schemas_list(include_deleted=deleted, latest_only=latest_only)
         response_schemas = []
-        for subject, schema in schemas.items():
+        for subject, schema_data in schemas.items():
             if self._auth and not self._auth.check_authorization(user, Operation.Read, f"Subject:{subject}"):
                 continue
-            response_schemas.append(
-                {
-                    "subject": subject,
-                    "version": schema["version"],
-                    "id": schema["id"],
-                    "schemaType": schema.get("schemaType", "AVRO"),
-                    "schema": schema["schema"].schema_str,
-                }
-            )
+            for schema in schema_data:
+                response_schemas.append(
+                    {
+                        "subject": subject,
+                        "version": schema["version"],
+                        "id": schema["id"],
+                        "schemaType": schema.get("schemaType", "AVRO"),
+                        "schema": schema["schema"].schema_str,
+                    }
+                )
+
         self.r(
             body=response_schemas,
             content_type=content_type,

tests/integration/test_schema.py

@@ -1255,6 +1255,33 @@ async def test_schema_types(registry_async_client: Client, trail: str) -> None:
     assert "PROTOBUF" in json_res
 
 
+@pytest.mark.parametrize("trail", ["", "/"])
+async def test_schema_list_endpoint(registry_async_client: Client, trail: str) -> None:
+    """Test schema endpoint list"""
+    subject = create_subject_name_factory(f"test_schema_subject_list_endpoint-{trail}")()
+    unique_field_factory = create_field_name_factory(trail)
+
+    unique = unique_field_factory()
+    schema_str = json.dumps({"type": "string", "unique": unique})
+    res = await registry_async_client.post(
+        f"subjects/{subject}/versions{trail}",
+        json={"schema": schema_str},
+    )
+    assert res.status_code == 200
+    assert "id" in res.json()
+    schema_id = res.json()["id"]
+
+    res = await registry_async_client.get("schemas")
+    assert res.status_code == 200
+    result_json = res.json()
+    assert len(result_json) == 1
+    schema_data = result_json[0]
+    assert schema_data.get("id") == schema_id
+    assert schema_data.get("subject") == subject
+    assert schema_data.get("version") == 1
+    assert schema_data.get("schema") == schema_str
+
+
 @pytest.mark.parametrize("trail", ["", "/"])
 async def test_schema_repost(registry_async_client: Client, trail: str) -> None:
     """ "