Skip to content

Commit ce51b80

Browse files
authored
Bug fix: when creating new users with username being a email id as pattern (#2363)
* Fix saas pattern Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io> * Fix saas pattern Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io> * Fix variable Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io> --------- Signed-off-by: Muralidhar Basani <muralidhar.basani@aiven.io>
1 parent 191919e commit ce51b80

6 files changed

Lines changed: 9 additions & 7 deletions

File tree

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
version = 2.8.0
1+
version = 2.8.1
22
NODE = node
33

44
# Sets a custom hook path in the local git config.

bin/run-klaw.bat

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ SET CURRENTDIR="%cd%"
44
set DIR=%~dp0..\
55
cd %DIR%
66

7-
set version=2.8.0
7+
set version=2.8.1
88
set core_lib=.\core\target\klaw-%version%.jar
99
set cluster_lib=.\cluster-api\target\cluster-api-%version%.jar
1010
set core_config=.\core\target\classes\application.properties

bin/run-klaw.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ WORKING_DIR="$(dirname "$0")"/..
44
cd $WORKING_DIR
55

66
# Declarations
7-
version=2.8.0
7+
version=2.8.1
88
core_lib=./core/target/klaw-${version}.jar
99
cluster_lib=./cluster-api/target/cluster-api-${version}.jar
1010
core_config=./core/target/classes/application.properties

core/src/main/java/io/aiven/klaw/service/UsersTeamsControllerService.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,7 @@ public class UsersTeamsControllerService {
7272
public static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();
7373
public static final String MASKED_PWD = "********";
7474
public static final String UNUSED_PASSWD = "unusedpasswd";
75+
private static final Pattern emailUsernamePattern = Pattern.compile("^[A-Za-z0-9+_.-]+@(.+)$");
7576

7677
@Value("${klaw.login.authentication.type}")
7778
private String authenticationType;
@@ -1096,8 +1097,9 @@ private Object getPrincipal() {
10961097
}
10971098

10981099
private boolean userNamePatternValidation(String userName) {
1099-
Matcher m1 = defaultPattern.matcher(userName);
1100-
return m1.matches();
1100+
Matcher m1 = emailUsernamePattern.matcher(userName);
1101+
Matcher m2 = defaultPattern.matcher(userName);
1102+
return m1.matches() || m2.matches();
11011103
}
11021104

11031105
public List<TeamModelResponse> getSwitchTeams(String userId) {

openapi.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"name" : "Apache 2.0",
1111
"url" : "https://www.apache.org/licenses/LICENSE-2.0.html"
1212
},
13-
"version" : "2.8.0"
13+
"version" : "2.8.1"
1414
},
1515
"externalDocs" : {
1616
"description" : "Klaw documentation",

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@
4242
</parent>
4343

4444
<properties>
45-
<revision>2.8.0</revision>
45+
<revision>2.8.1</revision>
4646
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
4747
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
4848
<java.version>17</java.version>

0 commit comments

Comments
 (0)