refactor: consolidate CLI flags into Config struct

- Replace global flag variables with Config struct
- Move flag declarations from package level to main() function
- Update function signatures to accept Config instead of individual
  parameters
- Pass Config to execCount, sendQuery, and runInteractive functions
- Add concurrency field to TUI model for query execution
- Update warnInvalidFlagPlacement to accept flags parameter
- Return empty results instead of searching for "*" in TUI when query
  is empty

This change improves code organization by grouping related
configuration values and reduces function parameter counts, making
the codebase more maintainable.

Author: Ajnasz

loggly.go

@@ -57,19 +57,17 @@ const usage = `
     /Black(Berry)?/
 `
 
-// Command options.
-var flags = flag.NewFlagSet("loggly", flag.ExitOnError)
-var count = flags.Bool("count", false, "")
-var concurrency = flags.Int("concurrency", 3, "")
-var versionQuery = flags.Bool("version", false, "")
-var tui = flags.Bool("tui", false, "")
-var account = flags.String("account", "", "")
-var maxPages = flags.Int64("maxPages", 3, "")
-var token = flags.String("token", "", "")
-var size = flags.Int("size", 100, "")
-var from = flags.String("from", "-24h", "")
-var to = flags.String("to", "now", "")
-var allMsg = flags.Bool("all", false, "")
+type Config struct {
+	Account     string
+	Token       string
+	Size        int
+	From        string
+	To          string
+	Count       bool
+	AllMsg      bool
+	MaxPages    int64
+	Concurrency int
+}
 
 // Print usage and exit.
 func printUsage() {
@@ -121,9 +119,9 @@ func printLogMSG(events []any) error {
 	return printJSON(ret)
 }
 
-func execCount(ctx context.Context, query string, from string, to string) {
-	c := search.New(*account, *token)
-	q := search.NewQuery(query).Size(1).From(from).To(to)
+func execCount(ctx context.Context, config Config, query string) {
+	c := search.New(config.Account, config.Token)
+	q := search.NewQuery(query).Size(1).From(config.From).To(config.To)
 	res, err := c.Fetch(ctx, *q)
 	for {
 		select {
@@ -140,8 +138,8 @@ func execCount(ctx context.Context, query string, from string, to string) {
 	}
 }
 
-func printRes(res search.Response) {
-	if *allMsg {
+func printRes(allMsg bool, res search.Response) {
+	if allMsg {
 		check(printJSON(res.Events))
 		return
 	}
@@ -153,15 +151,11 @@ func printRes(res search.Response) {
 
 func sendQuery(
 	ctx context.Context,
+	config Config,
 	query string,
-	size int,
-	from string,
-	to string,
-	maxPages int64,
-	concurrency int,
 ) {
-	c := search.New(*account, *token).SetConcurrency(concurrency)
-	q := search.NewQuery(query).Size(size).From(from).To(to).MaxPage(maxPages)
+	c := search.New(config.Account, config.Token).SetConcurrency(config.Concurrency)
+	q := search.NewQuery(query).Size(config.Size).From(config.From).To(config.To).MaxPage(config.MaxPages)
 	res, err := c.Fetch(ctx, *q)
 
 	for {
@@ -170,7 +164,7 @@ func sendQuery(
 			check(ctx.Err())
 			return
 		case r := <-res:
-			printRes(r)
+			printRes(config.AllMsg, r)
 		case e := <-err:
 			check(e)
 			return
@@ -179,7 +173,7 @@ func sendQuery(
 
 }
 
-func warnInvalidFlagPlacement(args []string) {
+func warnInvalidFlagPlacement(flags *flag.FlagSet, args []string) {
 	currentFlags := make(map[string]bool)
 	flags.VisitAll(func(f *flag.Flag) {
 		currentFlags["-"+f.Name] = true
@@ -220,6 +214,19 @@ func contextWithInterrupt(ctx context.Context) (context.Context, context.CancelF
 }
 
 func main() {
+	// Command options.
+	var flags = flag.NewFlagSet("loggly", flag.ExitOnError)
+	var count = flags.Bool("count", false, "")
+	var concurrency = flags.Int("concurrency", 3, "")
+	var versionQuery = flags.Bool("version", false, "")
+	var tui = flags.Bool("tui", false, "")
+	var account = flags.String("account", "", "")
+	var maxPages = flags.Int64("maxPages", 3, "")
+	var token = flags.String("token", "", "")
+	var size = flags.Int("size", 100, "")
+	var from = flags.String("from", "-24h", "")
+	var to = flags.String("to", "now", "")
+	var allMsg = flags.Bool("all", false, "")
 	flags.Usage = printUsage
 	flags.Parse(os.Args[1:])
 
@@ -229,7 +236,7 @@ func main() {
 	}
 
 	args := flags.Args()
-	warnInvalidFlagPlacement(args)
+	warnInvalidFlagPlacement(flags, args)
 	warnHighConcurrency(*concurrency)
 	query := strings.Join(args, " ")
 	ctx, cancel := contextWithInterrupt(context.Background())
@@ -238,15 +245,27 @@ func main() {
 	assert(*account != "", "-account required")
 	assert(*token != "", "-token required")
 
+	config := Config{
+		Account:     *account,
+		Token:       *token,
+		Size:        *size,
+		From:        *from,
+		To:          *to,
+		Count:       *count,
+		AllMsg:      *allMsg,
+		MaxPages:    *maxPages,
+		Concurrency: *concurrency,
+	}
+
 	if *tui {
-		runInteractive(ctx, *account, *token, *size, *maxPages, query, *from, *to)
+		runInteractive(ctx, config, query)
 		return
 	}
 
 	if *count {
-		execCount(ctx, query, *from, *to)
+		execCount(ctx, config, query)
 		return
 	}
 
-	sendQuery(ctx, query, *size, *from, *to, *maxPages, *concurrency)
+	sendQuery(ctx, config, query)
 }

tui.go

@@ -134,13 +134,14 @@ func (i valueItem) Title() string       { return i.value }
 func (i valueItem) Description() string { return fmt.Sprintf("%d occurrences", i.count) }
 
 type model struct {
-	ctx      context.Context
-	account  string
-	token    string
-	from     string
-	to       string
-	size     int
-	maxPages int64
+	ctx         context.Context
+	account     string
+	token       string
+	from        string
+	concurrency int
+	to          string
+	size        int
+	maxPages    int64
 
 	queryInput  textinput.Model
 	fieldsList  list.Model
@@ -196,7 +197,7 @@ var (
 			Foreground(lipgloss.Color("241"))
 )
 
-func initialModel(ctx context.Context, account, token string, size int, maxPages int64, query, from, to string) model {
+func initialModel(ctx context.Context, config Config, query string) model {
 	ti := textinput.New()
 	ti.Placeholder = "Enter your Loggly query..."
 	ti.Focus()
@@ -228,12 +229,13 @@ func initialModel(ctx context.Context, account, token string, size int, maxPages
 
 	return model{
 		ctx:           ctx,
-		account:       account,
-		token:         token,
-		size:          size,
-		maxPages:      maxPages,
-		from:          from,
-		to:            to,
+		account:       config.Account,
+		token:         config.Token,
+		size:          config.Size,
+		maxPages:      config.MaxPages,
+		from:          config.From,
+		to:            config.To,
+		concurrency:   config.Concurrency,
 		queryInput:    ti,
 		fieldsList:    fieldsList,
 		valuesList:    valuesList,
@@ -512,10 +514,10 @@ func (m *model) executeQuery() tea.Cmd {
 	return func() tea.Msg {
 		query := m.queryInput.Value()
 		if query == "" {
-			query = "*"
+			return resultsMsg{results: []map[string]any{}}
 		}
 
-		c := search.New(m.account, m.token).SetConcurrency(1)
+		c := search.New(m.account, m.token).SetConcurrency(m.concurrency)
 		q := search.NewQuery(query).Size(m.size).From(m.from).To(m.to).MaxPage(m.maxPages)
 		resChan, errChan := c.Fetch(m.ctx, *q)
 
@@ -722,9 +724,9 @@ func (m *model) showDetailView(item resultItem) {
 	m.detailView.SetContent(string(data))
 }
 
-func runInteractive(ctx context.Context, account, token string, size int, maxPages int64, query, from, to string) {
+func runInteractive(ctx context.Context, config Config, query string) {
 	p := tea.NewProgram(
-		initialModel(ctx, account, token, size, maxPages, query, from, to),
+		initialModel(ctx, config, query),
 		tea.WithAltScreen(),
 	)