Restrict vote comment action (#59)

alexrlpz · fblupi · web-flow · commit 6bfa9c2452cb · 2025-10-08T11:52:49.000+03:00
* Restrict vote_comment action

* Update translations

* Lint

---------

Co-authored-by: Fran Bolívar &lt;francisco.bolivar@nazaries.com&gt;
diff --git a/decidim-accountability/config/locales/ca.yml b/decidim-accountability/config/locales/ca.yml
@@ -252,6 +252,7 @@ ca:
       accountability:
         actions:
           comment: Comentar
+          vote_comment: Votar el comentari
         name: Seguiment
         settings:
           global:
diff --git a/decidim-accountability/config/locales/en.yml b/decidim-accountability/config/locales/en.yml
@@ -253,6 +253,7 @@ en:
       accountability:
         actions:
           comment: Comment
+          vote_comment: Vote comment
         name: Accountability
         settings:
           global:
diff --git a/decidim-accountability/config/locales/es.yml b/decidim-accountability/config/locales/es.yml
@@ -252,6 +252,7 @@ es:
       accountability:
         actions:
           comment: Comentar
+          vote_comment: Votar comentario
         name: Seguimiento
         settings:
           global:
diff --git a/decidim-accountability/lib/decidim/accountability/component.rb b/decidim-accountability/lib/decidim/accountability/component.rb
@@ -14,14 +14,14 @@
   end
 
   # These actions permissions can be configured in the admin panel
-  component.actions = %w(comment)
+  component.actions = %w(comment vote_comment)
 
   component.register_resource(:result) do |resource|
     resource.model_class_name = "Decidim::Accountability::Result"
     resource.template = "decidim/accountability/results/linked_results"
     resource.card = "decidim/accountability/result"
     resource.searchable = false
-    resource.actions = %w(comment)
+    resource.actions = %w(comment vote_comment)
   end
 
   component.settings(:global) do |settings|
diff --git a/decidim-blogs/config/locales/ca.yml b/decidim-blogs/config/locales/ca.yml
@@ -76,6 +76,7 @@ ca:
           destroy: Esborrar
           endorse: Adherir-se
           update: Actualitzar
+          vote_comment: Votar el comentari
         name: Blog
         settings:
           global:
diff --git a/decidim-blogs/config/locales/en.yml b/decidim-blogs/config/locales/en.yml
@@ -76,6 +76,7 @@ en:
           destroy: Delete
           endorse: Endorse
           update: Update
+          vote_comment: Vote comment
         name: Blog
         settings:
           global:
diff --git a/decidim-blogs/config/locales/es.yml b/decidim-blogs/config/locales/es.yml
@@ -76,6 +76,7 @@ es:
           destroy: Borrar
           endorse: Adherirse
           update: Actualizar
+          vote_comment: Votar comentario
         name: Blog
         settings:
           global:
diff --git a/decidim-blogs/lib/decidim/blogs/component.rb b/decidim-blogs/lib/decidim/blogs/component.rb
@@ -35,7 +35,7 @@
   component.register_resource(:blogpost) do |resource|
     resource.model_class_name = "Decidim::Blogs::Post"
     resource.card = "decidim/blogs/post"
-    resource.actions = %w(endorse comment)
+    resource.actions = %w(endorse comment vote_comment)
     resource.searchable = true
   end
 
diff --git a/decidim-budgets/config/locales/ca.yml b/decidim-budgets/config/locales/ca.yml
@@ -341,6 +341,7 @@ ca:
         actions:
           comment: Comentar
           vote: Vota
+          vote_comment: Votar el comentari
         name: Pressupostos
         settings:
           global:
diff --git a/decidim-budgets/config/locales/en.yml b/decidim-budgets/config/locales/en.yml
@@ -339,6 +339,7 @@ en:
         actions:
           comment: Comment
           vote: Vote
+          vote_comment: Vote comment
         name: Budgets
         settings:
           global:
diff --git a/decidim-budgets/config/locales/es.yml b/decidim-budgets/config/locales/es.yml
@@ -341,6 +341,7 @@ es:
         actions:
           comment: Comentar
           vote: Vota
+          vote_comment: Votar comentario
         name: Presupuestos
         settings:
           global:
diff --git a/decidim-budgets/lib/decidim/budgets/component.rb b/decidim-budgets/lib/decidim/budgets/component.rb
@@ -15,7 +15,7 @@
 
   component.query_type = "Decidim::Budgets::BudgetsType"
 
-  component.actions = %w(vote comment)
+  component.actions = %w(vote comment vote_comment)
 
   component.on(:before_destroy) do |instance|
     raise StandardError, "Cannot remove this component" if Decidim::Budgets::Budget.where(component: instance).any?
diff --git a/decidim-comments/lib/decidim/comments/commentable_with_component.rb b/decidim-comments/lib/decidim/comments/commentable_with_component.rb
@@ -29,6 +29,15 @@ def user_allowed_to_comment?(user)
 
           ActionAuthorizer.new(user, "comment", component, self).authorize.ok?
         end
+
+        # Public: Whether the user can vote comments or not.
+        # Checks for vote_comment permissions on the component.
+        def user_allowed_to_vote_comment?(user)
+          return false unless accepts_new_comments?
+          return false unless can_participate?(user)
+
+          ActionAuthorizer.new(user, "vote_comment", component, self).authorize.ok?
+        end
       end
     end
   end
diff --git a/decidim-debates/config/locales/ca.yml b/decidim-debates/config/locales/ca.yml
@@ -32,6 +32,7 @@ ca:
           comment: Comentar
           create: Crear un debat
           endorse: Adherir-se
+          vote_comment: Votar el comentari
         name: Debats
         settings:
           global:
diff --git a/decidim-debates/config/locales/en.yml b/decidim-debates/config/locales/en.yml
@@ -32,6 +32,7 @@ en:
           comment: Comment
           create: Create a debate
           endorse: Endorse
+          vote_comment: Vote comment
         name: Debates
         settings:
           global:
diff --git a/decidim-debates/config/locales/es.yml b/decidim-debates/config/locales/es.yml
@@ -32,6 +32,7 @@ es:
           comment: Comentar
           create: Crear un debate
           endorse: Adherirse
+          vote_comment: Votar comentario
         name: Debates
         settings:
           global:
diff --git a/decidim-debates/lib/decidim/debates/component.rb b/decidim-debates/lib/decidim/debates/component.rb
@@ -51,10 +51,10 @@
     resource.card = "decidim/debates/debate"
     resource.reported_content_cell = "decidim/debates/reported_content"
     resource.searchable = true
-    resource.actions = %w(create endorse comment)
+    resource.actions = %w(create endorse comment vote_comment)
   end
 
-  component.actions = %w(create endorse comment)
+  component.actions = %w(create endorse comment vote_comment)
 
   component.exports :comments do |exports|
     exports.collection do |component_instance|
diff --git a/decidim-dev/app/models/decidim/dev/dummy_resource.rb b/decidim-dev/app/models/decidim/dev/dummy_resource.rb
@@ -70,7 +70,10 @@ def user_allowed_to_comment?(user)
 
       # Public: Whether the object can have new comment votes or not.
       def user_allowed_to_vote_comment?(user)
-        component.can_participate_in_space?(user)
+        return false unless accepts_new_comments?
+        return unless component.can_participate_in_space?(user)
+
+        ActionAuthorizer.new(user, "vote_comment", component, self).authorize.ok?
       end
 
       def self.user_collection(user)
diff --git a/decidim-initiatives/app/models/decidim/initiative.rb b/decidim-initiatives/app/models/decidim/initiative.rb
@@ -465,6 +465,10 @@ def user_allowed_to_comment?(user)
       ActionAuthorizer.new(user, "comment", self, nil).authorize.ok?
     end
 
+    def user_allowed_to_vote_comment?(user)
+      ActionAuthorizer.new(user, "vote_comment", self, nil).authorize.ok?
+    end
+
     def self.ransack(params = {}, options = {})
       Initiatives::InitiativeSearch.new(self, params, options)
     end
diff --git a/decidim-initiatives/config/locales/ca.yml b/decidim-initiatives/config/locales/ca.yml
@@ -605,6 +605,7 @@ ca:
       initiative:
         actions:
           comment: Comentar
+          vote_comment: Votar el comentari
       initiatives_type:
         actions:
           create: Crear una iniciativa
diff --git a/decidim-initiatives/config/locales/en.yml b/decidim-initiatives/config/locales/en.yml
@@ -604,6 +604,7 @@ en:
       initiative:
         actions:
           comment: Comment
+          vote_comment: Vote comment
       initiatives_type:
         actions:
           create: Create an initiative
diff --git a/decidim-initiatives/config/locales/es.yml b/decidim-initiatives/config/locales/es.yml
@@ -605,6 +605,7 @@ es:
       initiative:
         actions:
           comment: Comentar
+          vote_comment: Votar comentario
       initiatives_type:
         actions:
           create: Crear una iniciativa
diff --git a/decidim-initiatives/lib/decidim/initiatives/participatory_space.rb b/decidim-initiatives/lib/decidim/initiatives/participatory_space.rb
@@ -23,7 +23,7 @@
   participatory_space.breadcrumb_cell = "decidim/initiatives/initiative_dropdown_metadata"
 
   participatory_space.register_resource(:initiative) do |resource|
-    resource.actions = %w(comment)
+    resource.actions = %w(comment vote_comment)
     resource.permissions_class_name = "Decidim::Initiatives::Permissions"
     resource.model_class_name = "Decidim::Initiative"
     resource.card = "decidim/initiatives/initiative"
diff --git a/decidim-meetings/config/locales/ca.yml b/decidim-meetings/config/locales/ca.yml
@@ -148,6 +148,7 @@ ca:
           comment: Comentar
           join: Inscriu-t'hi
           reply_poll: Respondre el sondeig/consulta en directe
+          vote_comment: Votar el comentari
         name: Trobades
         settings:
           global:
diff --git a/decidim-meetings/config/locales/en.yml b/decidim-meetings/config/locales/en.yml
@@ -148,6 +148,7 @@ en:
           comment: Comment
           join: Join
           reply_poll: Reply poll
+          vote_comment: Vote comment
         name: Meetings
         settings:
           global:
diff --git a/decidim-meetings/config/locales/es.yml b/decidim-meetings/config/locales/es.yml
@@ -148,6 +148,7 @@ es:
           comment: Comentar
           join: Unirse
           reply_poll: Responder la consulta
+          vote_comment: Votar comentario
         name: Encuentros
         settings:
           global:
diff --git a/decidim-meetings/lib/decidim/meetings/component.rb b/decidim-meetings/lib/decidim/meetings/component.rb
@@ -19,7 +19,7 @@
     resource.template = "decidim/meetings/meetings/linked_meetings"
     resource.card = "decidim/meetings/meeting"
     resource.reported_content_cell = "decidim/meetings/reported_content"
-    resource.actions = %w(join comment reply_poll)
+    resource.actions = %w(join comment reply_poll vote_comment)
     resource.searchable = true
   end
 
diff --git a/decidim-proposals/lib/decidim/proposals/commentable_proposal.rb b/decidim-proposals/lib/decidim/proposals/commentable_proposal.rb
@@ -24,12 +24,6 @@ def users_to_notify_on_comment_created
 
           followers
         end
-
-        def user_allowed_to_vote_comment?(user)
-          return unless can_participate_in_space?(user)
-
-          ActionAuthorizer.new(user, "vote_comment", component, self).authorize.ok?
-        end
       end
     end
   end
diff --git a/decidim-sortitions/config/locales/ca.yml b/decidim-sortitions/config/locales/ca.yml
@@ -22,6 +22,7 @@ ca:
       sortitions:
         actions:
           comment: Comentar
+          vote_comment: Votar el comentari
         name: Sortejos
         settings:
           global:
diff --git a/decidim-sortitions/config/locales/en.yml b/decidim-sortitions/config/locales/en.yml
@@ -22,6 +22,7 @@ en:
       sortitions:
         actions:
           comment: Comment
+          vote_comment: Vote comment
         name: Sortitions
         settings:
           global:
diff --git a/decidim-sortitions/config/locales/es.yml b/decidim-sortitions/config/locales/es.yml
@@ -22,6 +22,7 @@ es:
       sortitions:
         actions:
           comment: Comentar
+          vote_comment: Votar comentario
         name: Sorteos
         settings:
           global:
diff --git a/decidim-sortitions/lib/decidim/sortitions/component.rb b/decidim-sortitions/lib/decidim/sortitions/component.rb
@@ -26,7 +26,7 @@
     resource.model_class_name = "Decidim::Sortitions::Sortition"
     resource.template = "decidim/sortitions/sortitions/linked_sortitions"
     resource.card = "decidim/sortitions/sortition"
-    resource.actions = %w(comment)
+    resource.actions = %w(comment vote_comment)
   end
 
   component.register_stat :sortitions_count, primary: true, priority: Decidim::StatsRegistry::HIGH_PRIORITY do |components, start_at, end_at|
