feat: add comprehensive list of native throwing functions and improve identifier search

Author: Akronae

scripts/node-runtime-scan.ts

@@ -57,3 +57,23 @@ await testFile(
 );
 await testFile("src/rules/might-throw/tests/generic-ok.ts", [rule.name], []);
 await testFile("src/rules/might-throw/tests/tsx-ok.tsx", [rule.name], []);
+await testFile(
+  "src/rules/might-throw/tests/native-funcs-err.ts",
+  [rule.name],
+  [
+    {
+      messageId: "mightThrow",
+      line: 4,
+    },
+  ]
+);
+await testFile(
+  "src/rules/might-throw/tests/native-funcs-err-2.ts",
+  [rule.name],
+  [
+    {
+      messageId: "mightThrow",
+      line: 4,
+    },
+  ]
+);

src/rules/might-throw/might-throw.spec.ts

@@ -1,8 +1,8 @@
-import { findInParent, isFunctionDeclaration } from "@/src/utils";
-import { getFunctionId } from "@/src/utils/get-function-id";
-import { getCallExprId } from "@/src/utils/get-call-expr-id";
 import { createRule } from "@/src/rules/create-rule";
+import { findInParent, isFunctionDeclaration } from "@/src/utils";
 import { canFuncThrow, canFuncThrowClear } from "@/src/utils/can-func-throw";
+import { getCallExprId } from "@/src/utils/get-call-expr-id";
+import { getFunctionId } from "@/src/utils/get-function-id";
 
 const name = "might-throw";
 const rule = createRule({

src/rules/might-throw/might-throw.ts

@@ -0,0 +1,7 @@
+import { createHash } from "node:crypto";
+
+function hashFile(filePath: string, outputFile?: string) {
+  const hash = createHash("sha256");
+  const digest = hash.digest("hex");
+  console.log(digest);
+}

src/rules/might-throw/tests/native-funcs-err-2.ts

@@ -0,0 +1,8 @@
+import { existsSync } from "fs";
+
+export function hashFile() {
+  if (!existsSync("fullPath")) {
+    console.error(`File not found: ${"fullPath"}`);
+    process.exit(1);
+  }
+}

src/rules/might-throw/tests/native-funcs-err.ts

@@ -14,7 +14,6 @@ export function exploreChildren<T>(
     node: TSESTree.Node,
     parent?: TSESTree.Node
   ): T | undefined => {
-    // console.log({ node });
     let rtrn = null;
     predicate(node, parent, (args) => {
       rtrn = args;
@@ -26,6 +25,7 @@ export function exploreChildren<T>(
         | TSESTree.Node
         | TSESTree.Node[]
         | undefined;
+
       if (val && typeof val === "object") {
         if (Array.isArray(val)) {
           for (const v of val) {

src/utils/explore-children.ts

@@ -6,7 +6,9 @@ export const findIdentifierInParents = (
   node: TSESTree.Node
 ): TSESTree.Identifier | null => {
   if (!node.parent) return null;
-  const ids = findIdentifiersInChildren(name, [node.parent]);
+  const ids = findIdentifiersInChildren(name, [node.parent]).filter(
+    (x) => x != node
+  );
   if (ids.length) {
     return ids[0];
   }

src/utils/find-identifier-in-parents.ts

@@ -1,5 +1,3 @@
-import { TSESTree } from "@typescript-eslint/utils";
-import { isIdentifier } from "@typescript-eslint/utils/ast-utils";
 import {
   isArrowFunctionExpression,
   isBlockStatement,
@@ -14,6 +12,8 @@ import {
   isVariableDeclaration,
   isVariableDeclarator,
 } from "@/src/utils/ast-guards";
+import { TSESTree } from "@typescript-eslint/utils";
+import { isIdentifier } from "@typescript-eslint/utils/ast-utils";
 
 export const findIdentifiersInChildren = (
   name: string,

src/utils/find-identifiers-in-children.ts

@@ -1,14 +1,18 @@
 import { TSESTree } from "@typescript-eslint/types";
-import { InferGuardType } from "./infer-guard-type";
 import { exploreChildren } from "./explore-children";
+import { InferGuardType } from "./infer-guard-type";
 
 export function findInChildrenAll<
   T extends TSESTree.Node,
   F extends (x: TSESTree.Node) => x is T
->(node: TSESTree.Node, predicate: F) {
+>(
+  node: TSESTree.Node,
+  predicate: F,
+  filter?: (node: InferGuardType<F>) => boolean
+) {
   const result: InferGuardType<F>[] = [];
   exploreChildren(node, (child) => {
-    if (predicate(child)) {
+    if (predicate(child) && (!filter || filter(child as InferGuardType<F>))) {
       result.push(child as InferGuardType<F>);
     }
   });