Skip to content

Commit 5d4db2e

Browse files
committed
fix: remove legacy avatar naming conventions for clarity
1 parent 88a884a commit 5d4db2e

File tree

3 files changed

+36
-31
lines changed

3 files changed

+36
-31
lines changed

src/styles/auro-tail-group.scss

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,14 @@ $group-sizes: tokens.$tail-group-sizes;
99
*/
1010
@each $size in $group-sizes {
1111
:host([layout="horizontal"][size="#{$size}"]) {
12-
/* Account for avatar widths, border on each tail, and overlap */
12+
/* Account for container widths, border on each tail, and overlap */
1313
width: calc(
14-
2 * var(--avatar-width-#{$size}) +
14+
2 * var(--container-width-#{$size}) +
1515
2 * var(--group-horizontal-border-width-#{$size}) +
1616
var(--group-horizontal-overlap-#{$size})
1717
);
18-
height: calc(var(--avatar-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
19-
min-height: calc(var(--avatar-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
18+
height: calc(var(--container-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
19+
min-height: calc(var(--container-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
2020
}
2121
}
2222

@@ -45,8 +45,8 @@ $group-sizes: tokens.$tail-group-sizes;
4545
:host([layout="horizontal"][size="#{$size}"]) .group.horizontal ::slotted(auro-tail) {
4646
--border-width: var(--group-horizontal-border-width-#{$size});
4747
/* Expand host width to include borders on both sides */
48-
width: calc(var(--avatar-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
49-
min-width: calc(var(--avatar-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
48+
width: calc(var(--container-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
49+
min-width: calc(var(--container-width-#{$size}) + 2 * var(--group-horizontal-border-width-#{$size}));
5050
}
5151

5252
:host([layout="horizontal"][size="#{$size}"]) .group.horizontal ::slotted(auro-tail:first-child) {

src/styles/auro-tail.scss

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,8 @@
66
flex-direction: column;
77
align-items: center;
88
vertical-align: middle;
9-
min-width: var(--avatar-width);
10-
min-height: var(--avatar-width);
9+
min-width: var(--container-width);
10+
min-height: var(--container-width);
1111
}
1212

1313
/* hyperlink styling */
@@ -16,24 +16,24 @@
1616
flex-direction: column;
1717
align-items: center;
1818
text-decoration: none;
19-
min-width: var(--avatar-width);
20-
min-height: var(--avatar-width);
19+
min-width: var(--container-width);
20+
min-height: var(--container-width);
2121
}
2222

2323
.tail > .tail-hyperlink .label {
2424
display: block;
2525
margin-top: var(--href-label-gap);
2626
text-align: center;
27-
min-width: var(--avatar-width);
27+
min-width: var(--container-width);
2828
white-space: nowrap;
2929
overflow: visible;
3030
text-overflow: clip;
3131
}
3232

3333
.border {
3434
position: relative;
35-
width: var(--avatar-width);
36-
height: var(--avatar-width);
35+
width: var(--container-width);
36+
height: var(--container-width);
3737
border-radius: var(--border-radius-full);
3838
display: grid;
3939
place-items: center;
@@ -49,18 +49,18 @@
4949

5050
/* Expand host dimensions to include border */
5151
:host {
52-
width: calc(var(--avatar-width) + 2 * var(--border-width, 0px));
53-
height: calc(var(--avatar-width) + 2 * var(--border-width, 0px));
54-
min-width: calc(var(--avatar-width) + 2 * var(--border-width, 0px));
55-
min-height: calc(var(--avatar-width) + 2 * var(--border-width, 0px));
52+
width: calc(var(--container-width) + 2 * var(--border-width, 0px));
53+
height: calc(var(--container-width) + 2 * var(--border-width, 0px));
54+
min-width: calc(var(--container-width) + 2 * var(--border-width, 0px));
55+
min-height: calc(var(--container-width) + 2 * var(--border-width, 0px));
5656
}
5757

5858
.container {
5959
position: relative;
6060
width: 100%;
6161
height: 100%;
6262
border-radius: var(--border-radius-full);
63-
background: var(--avatar-gradient);
63+
background: var(--container-gradient);
6464
display: grid;
6565
place-items: center;
6666
overflow: hidden;

src/styles/tokens.scss

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,13 @@ $tail-sizes-with-href: (md, lg, xl, 2xl);
99
$tail-group-sizes: (xs, sm, md, lg);
1010
$tail-variants: (as, ha, oa);
1111

12+
/* Naming Convention:
13+
* - "container": The circular container/background that holds the tail icon
14+
* - "tail": The actual airline livery SVG icon displayed within the container
15+
*/
16+
1217
/* Size Maps */
13-
$avatar-width: (
18+
$container-width: (
1419
'xs': 24px,
1520
'sm': 32px,
1621
'md': 48px,
@@ -28,7 +33,7 @@ $tail-width: (
2833
'2xl': 107px
2934
);
3035

31-
/* Adjust vertical offset to visually center tail icon within circular avatar
36+
/* Adjust vertical offset to visually center tail icon within circular container
3237
* Based on optical centering from design spec, not mathematical centering */
3338
$tail-offset-y: (
3439
'xs': 3px,
@@ -77,14 +82,14 @@ $group-horizontal: (
7782
:host {
7883
display: inline-block;
7984
/* Host dimensions to match container */
80-
width: var(--avatar-width);
81-
height: var(--avatar-width);
82-
min-width: var(--avatar-width);
83-
min-height: var(--avatar-width);
84-
85+
width: var(--container-width);
86+
height: var(--container-width);
87+
min-width: var(--container-width);
88+
min-height: var(--container-width);
89+
8590
/* Default Values */
86-
--avatar-width: var(--avatar-width-lg);
87-
--avatar-gradient: var(--gradient-oa);
91+
--container-width: var(--container-width-lg);
92+
--container-gradient: var(--gradient-oa);
8893
--tail-width: var(--tail-width-lg);
8994
--tail-offset-y: var(--tail-offset-y-lg);
9095
--href-label-gap: var(--href-label-gap-lg);
@@ -102,7 +107,7 @@ $group-horizontal: (
102107
--tail-outline-color: var(--border-color-default);
103108
--tail-outline-width: 1px;
104109

105-
/* Avatar Gradients */
110+
/* Container Gradients */
106111
--gradient-as: linear-gradient(180deg, #6899C6 0%, #CFE0EF 100%);
107112
--gradient-ha: linear-gradient(181deg, #CCB7ED -6.38%, #F9C2E7 99.46%);
108113
--gradient-oa: linear-gradient(181deg, #C5D0D9 -6.38%, #E8F1F8 99.46%);
@@ -124,7 +129,7 @@ $group-horizontal: (
124129

125130
/* Generate Tail size-based tokens */
126131
@each $property, $map in (
127-
'avatar-width': $avatar-width,
132+
'container-width': $container-width,
128133
'tail-width': $tail-width,
129134
'tail-offset-y': $tail-offset-y,
130135
'href-label-gap': $href-label-gap,
@@ -156,7 +161,7 @@ $group-horizontal: (
156161
/* Apply tokens to tail sizes */
157162
@each $size in $tail-sizes {
158163
:host([size="#{$size}"]) {
159-
--avatar-width: var(--avatar-width-#{$size});
164+
--container-width: var(--container-width-#{$size});
160165
--tail-width: var(--tail-width-#{$size});
161166
--tail-offset-y: var(--tail-offset-y-#{$size});
162167

@@ -177,6 +182,6 @@ $group-horizontal: (
177182
@each $variant in $tail-variants {
178183
:host([tail="#{$variant}"]),
179184
:host([tail="#{string.to-upper-case($variant)}"]) {
180-
--avatar-gradient: var(--gradient-#{$variant});
185+
--container-gradient: var(--gradient-#{$variant});
181186
}
182187
}

0 commit comments

Comments
 (0)